Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 24 Oct 2025 15:31:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Joe Conway <mail@joeconway.com>
Subject: Re: contrib/sepgsql regression tests have been broken for months
Message-ID: <aPsdPEGEfhiu2oz4@paquier.xyz>
References: <1613232.1761255361@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="n27PDkXewF7kCb3/"
Content-Disposition: inline
In-Reply-To: <1613232.1761255361@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aPsdPEGEfhiu2oz4%40paquier.xyz>
Precedence: bulk


--n27PDkXewF7kCb3/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 23, 2025 at 05:36:01PM -0400, Tom Lane wrote:
> So, okay, that's a perfectly respectable thing to do, and I can't
> really fault Michael or Jian for not having tested its effects on
> sepgsql.  But how come it took this long to notice?

Oops.  I would have taken care of that should I have known...  I check
the compilation of sepgsql, but the tests require dependencies that
are too heavy so it has always been some copy-paste operation when the
buildfarm got angry on this test suite (combined with hopes to not
break the tests).

> I think that rhinoceros is the only BF member testing with
> --with-selinux.

I recall so, yes.

> Anyway, we seem to need the attached in v18 and HEAD,
> and we really ought to get BF coverage going again.

Thanks for sending a patch (and 0758111f5d35)!
--
Michael

--n27PDkXewF7kCb3/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmj7HTwACgkQnvQgOdby
QH1R2xAAiH8+xsH45idqH2T4Wd4Wm2CPFebOekA2rwohkdwzpu64863kDyQVyOra
0hYCTLdaWMcwfsMUZ+8USaZJK267vkq7n1MV9xMFQ4b/i3y/S/yBkkxxlOD0joLD
UzGwJyanKNQmpqU6LJ5FvnLtaikvc3PRVjuXdKzDZ8kAnMqn7torq5PhYQrmJCFR
q35/dHlvFjHZjAQUqfjsUz1QoxNmpIVtaLkdXtYteGPOkkgQrkx1XdPmGe/rnJ2q
wrjPoM1WKnnGndD3VkJXMEFpiqQDsCkNGMUTsTFHnaPdmbtSeqjddqVKUi+HQxdN
chxUY21m51YwVyoK9XikBajZBNNaG6lR/fngaMzy9D8CldmnCY+uFDcVeR2e+zhM
+4CyaADMoz2ahIV88LfqEuRE0MSUbtByfq2SsiMo/dV2eWtsJ2RzXicfVmLWp5Wr
dyhKYu/RNFPCJbQ8B3BkkXCRuXQOvITJHrstYguq7WbHivbnLH4rSyJsZphDa98W
c1IwRVeh/sDJi8zUEMRvOubKE8lhwgY73CiOrDyedYyerO3Ui3Ek1q1ETqjIAwGp
/w36V1orVdZZ73FNzqgEGhnsuzfKGDjVPPqeff2NjxWz+RuqDpOPukqlksMXaab1
LcAcKmAoNF6dsTv0mSe055EDXD0YIRtXXdmDTGLTs+6UeDXoHYA=
=Wj0c
-----END PGP SIGNATURE-----

--n27PDkXewF7kCb3/--