Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vDWkX-00Ar7x-8L for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Oct 2025 23:35:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1vDWkW-009qki-67 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Oct 2025 23:35:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vDWkV-009qka-Sk for pgsql-hackers@lists.postgresql.org; Mon, 27 Oct 2025 23:35:38 +0000 Received: from fout-a4-smtp.messagingengine.com ([103.168.172.147]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vDWkS-004bGo-0H for pgsql-hackers@lists.postgresql.org; Mon, 27 Oct 2025 23:35:38 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id C2E5FEC02E1; Mon, 27 Oct 2025 19:35:34 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Mon, 27 Oct 2025 19:35:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1761608134; x=1761694534; bh=WAVA+par5H H4nsrfaoDiHh3ZbuGftco89LnYfoRzvnk=; b=d4FH11/PxJexU1ne32zx3fBZpc u7EEi6T0gOXGqb2t29sIBeEYiy/CT7RTnwlhgimwiXSx0W5NlPwmIHxCW1zliszX kH0F1ZyjX+RQ3Lb+d1lxoW7iARR4Q1Kgc5zAptcdrgh9WOu46BKyhG3AnNvDzrS/ +xkJnLkfISqlxNYAj8Te4wt0+aVqpYzfVd3zR2QQca9PsW9GfHJA4mFwWuUp9ERR 6lCvqM0Nfm3RccDeltHPy2X4JIHAi/3tiMXveK4jRfuTTxt1YVdpA9tmYfqSrKqO +sAodMrmKVz5rq9vKygomz5CYYcdNWufwbu+PwT9afQJ4XA6d+dTOkokFSAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1761608134; x=1761694534; bh=WAVA+par5HH4nsrfaoDiHh3ZbuGftco89Ln YfoRzvnk=; b=fv5duEK8sHaXBo14s/6LQWw9UX70iOGAhX+klCAyygsiykIWrsU K/Z1U2sGpsDSjrN6gbUOoelvDSviO9jSekbgeuTmW9b/4ARdumHtaqKY1+66JX0K 3CuAu+X6FGXf0jq5LwYRhbEx61r4Uvz7f9YjNRjplhnq35XLyLsiYfISyLFkLATC IvFZdXtlrdLtxjLbC6GVqhsq+wzRZdi0cKsbnGWEMd+xq/q9CuJ3r2WrRJaY72vy JVV/klh61pqh5pQQIYF+C3hyq4b4T7cw2qsha81dZ+pbZ20qB95IpgYcuaATgaJ5 Y5r1GCvFlpQrLyjUNDvfWWiA2K7jJHFsh1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduheelfedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepnhgrth hhrghnuggsohhsshgrrhhtsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghlvghkshgr nhguvghrsehtihhgvghruggrthgrrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtg hkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtoheprghr shgvnhhihidrmhhukhhhihhnrdguvghvsehgmhgrihhlrdgtohhmpdhrtghpthhtohepsg hruhgtvgesmhhomhhjihgrnhdruhhs X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Oct 2025 19:35:32 -0400 (EDT) Date: Tue, 28 Oct 2025 08:35:15 +0900 From: Michael Paquier To: Nathan Bossart Cc: Aleksander Alekseev , PostgreSQL Hackers , Arseniy Mukhin , Bruce Momjian Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3kOFwQapHykvUcbS" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --3kOFwQapHykvUcbS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote: > /* > * DISABLE_LEADER_PARTICIPATION disables the leader's participation in > * parallel index builds. This may be useful as a debugging aid. > -#undef DISABLE_LEADER_PARTICIPATION > + *#undef DISABLE_LEADER_PARTICIPATION > */ >=20 > IMHO we should either remove this line or move it out of the comment. > AFAICT we ordinarily don't #undef debugging stuff like this, presumably so > you can change it with compile flags. I would put this one on a separate line, outside the comment. It's minor, still we use this style in pg_config_manual.h. See around REALLOCATE_BITMAPSETS. -- Michael --3kOFwQapHykvUcbS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkAAbMACgkQnvQgOdby QH3jnw//WcnzT/U1LsMsxWdEHw/yEhJgKBHGIqDBHva0lPuINkOErWr3YMswG7pK IDsR2EwfoHM13FLB2Hb79RIjt1gjHlrikhh1gtlqrGjbv+fPuKE7GSvuQ/pAsDMu cEvfH2Us0G4v29KlB0o0WlasOPyYg3fiiIcEJs97AVeimzYEHULw4NyTleOaBMgU r4nF0KTTJGOxInCBkFEnBNB/3vvtU1Sg1Gs84VrgQ0YB1lkMjH8yJwXuyAV+0B49 ScrtzCAuCBobVIfFx/beD91XVByf4YRPRXkGcL/oEkdZKlcIwUlwDm+qIZZKH4Lv bpOfwtttNn34q06uzODNVd2/D8WrvRKCKYb4OvvqIwqm4JbfsGq86xROaDekGaNp gTdTnhysSZpmZDzeM7vys560V68GPiBh0vKf2qM2PLUlkOsFMvzY08BzsSpjhX69 vQo/HaVY3Q33rHHabSR/f2b3QcPmEVjxW2FAd7M0EqkI0TAGkRuH1tHX7rds6Cn3 DFtN5pUFgflEgE6/nm4rrcyQ40/qpgt44ug9LE/0uc3JruW0N6yZ6XXfIACAnzUA mAcBUtJ6ANWQiJGN/kRYh7bQJnH064wYKiZ+3w4Ux9LjSV64LSBQO6RRZavW30Lr NJ3NrsYKCGMZTXqMg8RHZAUC1EaavzFjVhGdXgqn+1thNV+i9os= =aTDs -----END PGP SIGNATURE----- --3kOFwQapHykvUcbS--