Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vDazN-00C1Xh-Js for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Oct 2025 04:07:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1vDazL-00Adpg-Hx for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Oct 2025 04:07:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vDazL-00AdpX-8C for pgsql-hackers@lists.postgresql.org; Tue, 28 Oct 2025 04:07:14 +0000 Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1vDazI-0048pV-1i for pgsql-hackers@postgresql.org; Tue, 28 Oct 2025 04:07:13 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 388A9EC02D9; Tue, 28 Oct 2025 00:07:12 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Tue, 28 Oct 2025 00:07:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1761624432; x=1761710832; bh=RXNwwY+FcR MLyGkG0x77pp8A2xeO/XkixXAFTBEcN3E=; b=NlbYHDU2Cv8wMgThtRiFK+wKil 81C+2BUdslIvLi0UF4TGq3QhCXcB0bAEJH0hB8F/cAah30fhNOdxYtLNlyYMOthA UYCB7zx+8j/VEj0o/yM7GkZ8UWb8iUChbHg/GHqA/AMz9ZGPA8qhquS4mtBaJzIp 2OLKrltohi+HAbDiukQkE17M3TrTrrNC4f8lUASo/3QtZAL5q4aUc/MI4bXwFxB2 /VTUw1i4vXjolBQp/hBOOjP2BQc28K6Dvvv1V3HJfD3UiAciVk9mjELZ7xDWe6t7 NOaUAKLgEq/y/Yqz3XYYJ9j33fr6L9X/JU/sq2CuzZFHKFEy9pN1Gs4JS+bA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1761624432; x=1761710832; bh=RXNwwY+FcRMLyGkG0x77pp8A2xeO/XkixXA FTBEcN3E=; b=fNFmUkuNI35+CIZKPdf85FJP5PgFsf+sPmzitlfrtWUpdq3/hjU Cgm5qaqUm1h/VBBPmFfqQ+Y3YLjaDd/lYTNlmhRXMtSlrmXxxtQ4u/9wKctM1inZ 46Mtu0Z+aW2qGOksNw2TR+BeCbrm3EIAnmJejTqforsBH5RoJqjB0wSJQ3Mou9N2 0PIJhC1AmW+oA08etS3QzT3DL5J/VFH4JmK2O9dTGAiziQ8u9942Qw+yHwSeIT2+ SMytXSDAcQTaVunUZQh/ri956Tp+SiTKhY+83Kccgfyqe2OUtZGgbawdSujTKqhq FN6ES45sQHnD9JyC4HD82pUeL24bWAPQZhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduheelkeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteetgedvvdevueeiudduveekffev vedtudelheellefftddvgeefgedtjeettdeknecuffhomhgrihhnpehpohhsthhgrhdrvg hsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhi tghhrggvlhesphgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohepjedpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepohhrlhhovhhmghesghhmrghilhdrtghomhdprhgt phhtthhopegrnhgurhgvshesrghnrghrrgiivghlrdguvgdprhgtphhtthhopehhlhhinh hnrghkrgesihhkihdrfhhipdhrtghpthhtohepnhhorghhsehlvggruggsohgrthdrtgho mhdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehpohhsthhgrhgvshhqlhdroh hrghdprhgtphhtthhopehrohgsvghrthhmhhgrrghssehgmhgrihhlrdgtohhmpdhrtghp thhtohepthhhohhmrghsrdhmuhhnrhhosehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Oct 2025 00:07:09 -0400 (EDT) Date: Tue, 28 Oct 2025 13:06:53 +0900 From: Michael Paquier To: Maxim Orlov Cc: Andres Freund , Heikki Linnakangas , Noah Misch , pgsql-hackers@postgresql.org, Robert Haas , Thomas Munro Subject: Re: AIO writes vs hint bits vs checksums Message-ID: References: <20240924194340.92.nmisch@google.com> <6f921677-570e-492b-95fc-4d5d9b4179f5@iki.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9YdjGJ+FK43oZXBG" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --9YdjGJ+FK43oZXBG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 27, 2025 at 02:48:43PM +0300, Maxim Orlov wrote: > I think there is one thing that could be improved here. The isolation > test index-killtuples (377b7ab1452) adds a new dependency: > contrib/btree_gin. contrib/btree_gist. This must be taken into > account in the makefile. Also mentioned here: https://postgr.es/m/aKJsWedftW7UX1WM@paquier.xyz It looks that the conclusion would be to move this test into its own test module to avoid the external contrib/ dependency in src/test/isolation/, as duplicated Makefile rules in src/test/isolation/Makefile are unpleasant. -- Michael --9YdjGJ+FK43oZXBG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkAQV0ACgkQnvQgOdby QH3HTg//RCTZrH984euwmd39RXsT0IKl6X+a9Nj/FDKitwybEoGetvQHwHLEeu5Y 1U5T75e0woZLbap3mmUeNyPI8DUWRlKTVQzIBQAELDxKg+lNgFIR3gYjBsrbpsLY D9rUCDMCNIi2crERgnGUo0oCUoCQwSIHt+vHpjVc8Elnu9bvrdJ3ervHuOGV3NOv 7gqVzzSoB0WtnbXceZ5mR+qz4OULdxPXUTT/o2lJtB3Bw7ZLvtswsPsbRAU3nwtF Ng7iqL444weWKALnZczsm2IGKlIDxZVOEUiz8j589HbWFGYOif0vFck5gimaAK5z FLr0FvoYdxigUIzfBIAfbLUTzsPsoYCm2CbRoWIU8iMcbvY3WFuBQidRRMXfaEel MPxnN5xU38ZxhRYZAYsMsYVRfZ0T5cvhezn1UITHxSbfN6sG2ub+E+BbMsIVmY8C ebhE0JlzCvwqaMcBWEK1/+RUTT7wFT/jKx7FxxBsR3Gj8Qw2YkRqrG7AUHJmITX7 Vo3ledVac+gAq22iUymrRBx21VNlh1CinFNLaznHRRlrg4GJBgzd4gXk64dBoHwQ RlQDiCl52QO/hd3Gq9nH7AlAI/Ysg0z/GqF2+j4/x1+kZhNpU+Q/DX2YQNgGO1+Z h9sl9CkLysjQqo11gNsFeUDikLvwmQjGkkp7Xreue+EeHGirZCA= =R6+0 -----END PGP SIGNATURE----- --9YdjGJ+FK43oZXBG--