Date: Tue, 28 Oct 2025 16:20:50 +0100
From: Christoph Berg <myon@debian.org>
To: Tomas Vondra <tomas@vondra.me>
Cc: Jakub Wartak <jakub.wartak@enterprisedb.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: failed NUMA pages inquiry status: Operation not permitted
Message-ID: <aQDfUo7pkcfUSCod@msg.df7cb.de>
References: <E1u1tr8-003BbN-2E@gemulon.postgresql.org>
 <aPDZOxjrmEo_1JRG@msg.df7cb.de>
 <7bbc582b-cc70-4a6f-bbf2-b5fd9b13a867@vondra.me>
 <aPEHINwaAxsQNAIP@msg.df7cb.de>
 <aPEJ7yH7ZJAF_MYW@msg.df7cb.de>
 <aPENGAkcrLyB_NLC@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="J3H232Pne8aWMmeW"
Content-Disposition: inline
In-Reply-To: <aPENGAkcrLyB_NLC@msg.df7cb.de>
Archived-At: 
 <https://www.postgresql.org/message-id/aQDfUo7pkcfUSCod%40msg.df7cb.de>
Precedence: bulk


--J3H232Pne8aWMmeW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Re: To Tomas Vondra
> So maybe PG should implement numa_available itself like that.

Following our discussion at pgconf.eu last week, I just implemented
that. The numa and pg_buffercache tests pass in Docker on Debian
bookworm now.

Christoph

--J3H232Pne8aWMmeW
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v2-0001-Make-pg_numa_init-cope-with-Docker.patch"

From 0b0088145b42a4316fb15a0ea4363bbebfabdfd7 Mon Sep 17 00:00:00 2001
From: Christoph Berg <myon@debian.org>
Date: Thu, 16 Oct 2025 13:24:56 +0200
Subject: [PATCH v2] Make pg_numa_init() cope with Docker

In seccomp-restricted environments like Docker, numactl versions before
2.0.19 would not properly catch EPERM. As the numa_available()
implementation is very short, just inline in here with the proper fix.

Upstream fix: https://github.com/numactl/numactl/commit/0ab9c7a0d857bea1724139c48e2e58ed6a81647f
---
 src/port/pg_numa.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/src/port/pg_numa.c b/src/port/pg_numa.c
index 3368a43a338..932099be1e5 100644
--- a/src/port/pg_numa.c
+++ b/src/port/pg_numa.c
@@ -43,13 +43,20 @@
 #define NUMA_QUERY_CHUNK_SIZE 1024
 #endif
 
-/* libnuma requires initialization as per numa(3) on Linux */
+/*
+ * libnuma requires initialization as per numa(3) on Linux.
+ *
+ * This should ideally just return numa_available(), but numactl versions
+ * before 2.0.19 ignored EPERM from get_mempolicy(), leading to ugly error
+ * messages when used in seccomp-restricted environments like Docker. We just
+ * inline the 2.0.19 version of numa_available() here.
+ */
 int
 pg_numa_init(void)
 {
-	int			r = numa_available();
-
-	return r;
+	if (get_mempolicy(NULL, NULL, 0, 0, 0) < 0 && (errno == ENOSYS || errno == EPERM))
+		return -1;
+	return 0;
 }
 
 /*
-- 
2.39.5


--J3H232Pne8aWMmeW--