Date: Fri, 31 Oct 2025 09:09:36 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	"David E. Wheeler" <david@justatheory.com>,
	Mankirat Singh <mankiratsingh1315@gmail.com>, pg@bowt.ie,
	andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: abi-compliance-check failure due to recent changes to
 pg_{clear,restore}_{attribute,relation}_stats()
Message-ID: <aQTDIO2xjmFKK0QV@nathan>
References: <aPZnY0Icgw1RGaGP@nathan>
 <334460.1760980024@sss.pgh.pa.us>
 <aPZt4b5beRPxjgI-@nathan>
 <aPZ_2a1EQvofxeci@nathan>
 <351026.1760988833@sss.pgh.pa.us>
 <aPahAGpqBTtvX3YG@nathan>
 <1A5A7BE9-4A1B-4A1E-9182-02EBE9A54721@justatheory.com>
 <aPfDOD6F4FaJJd7M@nathan>
 <655240.1761077617@sss.pgh.pa.us>
 <61bd5c85-aaee-4a73-aba6-5b725eacdf27@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <61bd5c85-aaee-4a73-aba6-5b725eacdf27@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/aQTDIO2xjmFKK0QV%40nathan>
Precedence: bulk

On Fri, Oct 31, 2025 at 12:02:10PM +0100, Peter Eisentraut wrote:
> What is the reason that this file is supposed to contain the history of
> relevant changes, rather than just the last one?
> 
> If you want the history, you could look at the git log of the file itself,
> no?

I think either way would ultimately be fine.  I might argue that keeping
the full history in a file with detailed explanations is more accessible
than requiring folks to run

	git log .abi-compliance-history

(Plus, if someone doesn't bother to put details in the commit message, you
then have to sleuth further to figure out what changed.)

-- 
nathan