Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 9 Nov 2025 08:33:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: relfilenode statistics
Message-ID: <aQ_TYhsZG72QkS_A@paquier.xyz>
References: 
 <CALdSSPhFaLEWXG9Mn8-tZoS68rE52647a2oZ6jrUNSBtwadD0A@mail.gmail.com>
 <Z07d850Yp7Sd9Qqq@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z3gN3bwUMijyV4I0@ip-10-97-1-34.eu-west-3.compute.internal>
 <CALdSSPh76=ACN=z68oM44ZMgZsQxTTYVF8qvi1F6TGA5Mn6uiQ@mail.gmail.com>
 <aMkHSeitgUPtMyA2@paquier.xyz>
 <aNutZbziBycskOYR@ip-10-97-1-34.eu-west-3.compute.internal>
 <aNxiLG0JTCYnpqx6@paquier.xyz>
 <aN07p71KNFR2HdaD@ip-10-97-1-34.eu-west-3.compute.internal>
 <aN3T_5NBv0XKFbs7@paquier.xyz>
 <aQ3X20hbqoThQXgp@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RRN2RoCcDjmpnwv/"
Content-Disposition: inline
In-Reply-To: <aQ3X20hbqoThQXgp@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/aQ_TYhsZG72QkS_A%40paquier.xyz>
Precedence: bulk


--RRN2RoCcDjmpnwv/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 07, 2025 at 11:28:27AM +0000, Bertrand Drouvot wrote:
> While there are existing rewrite tests, the stats behavior during rewrites
> doesn't have a good coverage. This patch adds some tests to record some s=
tats
> after different rewrite scenarios.
>=20
> That way, we'll be able to test that the stats are still the ones we
> expect after rewrites. Note that it generates a new stats_1.out (which is=
 quite
> large), so we may want to move those new tests to "isolation" instead.

Looking at this part of the patch set for now, not looked at the rest
yet.  This new stats_1.out is 2k lines long, introduced for the tests
related to rewrites as an effect of 2PC.  It seems to me that a split=20
into a new stats_rewrite would be justified for this case, to reduce
the output duplication.
--
Michael

--RRN2RoCcDjmpnwv/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkP02IACgkQnvQgOdby
QH0ILg//ah1CUpfEccbomrb52UPJ6ohgcJtKUu4Idd8ZiuNyT64cvYjduyyxUuZ9
2g3wPcLKTKUcHb/PFIbpN9OmZABksJLpPOV0uOme/SnJOKfTM8Od0e6hge1wY8Wi
5FbNrkv8ZN4wZ0S4LWrgFbTnJWXCZIFfDacZmQkLML5TMT4+l0XXTXz+rGw3TQD3
mvAr76JkdUsz7QdjDDxCIFLH0u244XASJfEipX0Xo+xazBg0+Hgw+7WvMu1Fp8il
4MrLuk9EOJjPsGx7rXvvddHHsDIpgepBJLt1IRGdDMOdZ3XzmFQYg4a9jkY2m+cd
tmpincrO+3JimsFefh132qJmbCxJgaZAtw/2D0gQlX+52zIM7KFPkVL1aWmzLNZz
ZD97GsXmNPvmpE1/5ox0+QE6CtBCBs3sTBzco7OpN4rLJVsU0ap8KGSmHIExMyAv
kHlFKAAGftlZCj+ZJ7uK8IGhX93vEnR729op+h5dd0gkHiq7b57YEqAiK6cajbrP
htXDTd7JL9UoiDJRH1f/qONEKCGd9IJpq0ZYVzWCFVFNvKNFeNGgN9aJoa/XdyuV
eVKC2Uh8sp0xfQxwXo+7gDEFSbj2+AXCSOm63wuiW2vBr317o0m99SAvwdXpeviV
PIKnim0OpDlMrepfSrO+qd3Zw8w5sJpVxN+NkJSU+0ySK6U8SiA=
=U45B
-----END PGP SIGNATURE-----

--RRN2RoCcDjmpnwv/--