Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 6 Nov 2025 17:26:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Tomas Vondra <tomas@vondra.me>, jian he <jian.universality@gmail.com>,
	pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: Extended Statistics set/restore/clear functions.
Message-ID: <aQxb0rHuckPSBeLO@paquier.xyz>
References: 
 <CADkLM=eM0VA-muiu+JMM4-B8eL5ZscPeGtTxh7UtmM+iVO7C=A@mail.gmail.com>
 <CADkLM=daHJhUf-sO1iD=UTaymbBVEgEW4Sxm8PtHWWDEGWW9jQ@mail.gmail.com>
 <CADkLM=d_=STa4RHWHk7AGZ1RAZYKMtJxGMsw0Mrdb8s6CHdvbw@mail.gmail.com>
 <CADkLM=f2B8cDpx3V2bZW07GN5JHaP7kFe7G0cmJMSPVUQ4eHhQ@mail.gmail.com>
 <CADkLM=cWJTOnhC4jbKUvFgjMd=Hc252FXbampsjuYekBvmMVAg@mail.gmail.com>
 <aPcetUfI2NJDqYxZ@paquier.xyz>
 <CADkLM=efY2h8Bio=bE8O2Tnd=WUdyKDL1Zrtz9h+at16E4HVUA@mail.gmail.com>
 <aPls00-bu3fPcuk-@paquier.xyz>
 <439a9947-e6a1-4ea9-84d8-1f843deaf6b1@vondra.me>
 <CADkLM=cTVN3g7OzdSXfnBHEYNVQiGMJ8cdx1v=zJa86w1A9ULA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="o79IQc5QQwHFeIZc"
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=cTVN3g7OzdSXfnBHEYNVQiGMJ8cdx1v=zJa86w1A9ULA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aQxb0rHuckPSBeLO%40paquier.xyz>
Precedence: bulk


--o79IQc5QQwHFeIZc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 05, 2025 at 01:38:56AM -0500, Corey Huinker wrote:
> Paquier's response got sidetracked because of an errant subject line
> change, so I will try to recap:

That was a typo that found its way into the email subject.  Sorry
about that, that broke gmail's tracking at least.

> in that off-list discussion I proposed (though I was mostly echoing what I
> thought Paquier wanted):
>=20
> 1. pg_ndistinct output function change.
> 2. pg_ndistinct input function addition.
> 3. pg_dependencies output function change
> 4. pg_dependencies input function
> 5. Expose attribute statistics function and rename them attstat_* or
> statatt_*   (edit: and fix lack of comments on the enums and arrays)
> 6. pg_restore_extended_stats
> 7. pg_dump with no ability to fetch old-format pg_ndistinct/pg_dependence=
s.
> (edit: and fix inherited bug)
> 8. pg_dump working back as far as possible

Thanks.  I have begun reviewing it (more a bit later, still need to
study more the structure of the code).  For now, I have extracted some
of the comment changes in 0005 and applied these independently.

> Given that the pg_dump code no longer seems as bad, and Tomas is very much
> in support of it, I've opted not to split out steps 7/8.

That sounds like a way forward to me, then, in terms of using a new
format and make pg_dump intelligent enough to deal with it based on
what's in the past versions.
--
Michael

--o79IQc5QQwHFeIZc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkMW9IACgkQnvQgOdby
QH1yfA/+Nn7lVj3/UdRhRmCru3iomKWMz8dDge/sj/0RQBXEfFIuDIvxpxuYGvCd
IUENWmnM5/ZI0d1PUH3uCXj4kB52UpHDDGUFS5JGSCAHcJrAs9syR0asGAwImUBC
fqw36zxGdl5mSLkbgRwLdyJhyCy6isSc3QjomWLAEoMatrrSapMhwmx7yuCVH8qD
Tdh4sgvjZ0jNpPp/78+rfY5yF2bziNG4PFcp0v4MJ1Iaek1GzhSLbwAxKX5dGKTT
sZkC9CxgROejMAxL4RGzvC8i+kzZlSSFzpwQzBuppFAmapu8jwwUVSUSjD/2N0+s
jBA15o3TrOvMPFFF/Fd/zxT6HbetipS/feYv6R3EgtQXZz/6ohUdmBvVrzZTqw/q
R8AQKdG7E+lcpywD7U/WYdFj3GwxvV9UFSASJh0WTNx/sXaKlhoRqorHIg3OaJ/V
h41blMyyBHmN1ULqhD2WBSg5IaC47awlJRfCnelqaHEuvPHYBA1KyBEs6uu6RxkB
q4i5HY18jpbfKSY11BtVMp6oy6Vj5ibujZOihBjmv5dN7YAOWfL2vZT0noBN+EW2
yZE4mMetUnnBhCMw4CGI3MaZxvNJ8+69h4TqywZD5WpI1FcJ5I4eRrunMMf4AGQ3
vJ3PthtVJmdGHI6l6rd+A9SP51YzH+AT3YZMerlKWEfmI0TDNbo=
=s551
-----END PGP SIGNATURE-----

--o79IQc5QQwHFeIZc--