Date: Thu, 20 Nov 2025 16:16:13 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: vacuumdb: add --dry-run
Message-ID: <aR-TLculrOb2hbRy@nathan>
References: 
 <CADkLM=ckHkX7Of5SrK7g0LokPUwJ=kk8JU1GXGF5pZ1eBVr0=Q@mail.gmail.com>
 <aRJW2_Yy9ALMkZUa@nathan>
 <CADkLM=fo48tbJ75VPDDNgMV3f-QWLCk2TPujGP4ockxVDFRiTQ@mail.gmail.com>
 <3DB353E5-944D-4E18-9DA2-4151F44AA59B@gmail.com>
 <CADkLM=dgpe7wgjLhnpTycPRzUn6_U9Tk8qNAxHALi4-JqgPp=g@mail.gmail.com>
 <aR5IMz4cngn8hkXI@nathan>
 <CADkLM=dwBjL5fK-Dq_2qhAuHsHPab_Kt+R7KZTA9w_X0K6bENg@mail.gmail.com>
 <CADkLM=d+XROe3JgM5gZno0JGEgxnDDCYsEHgQjg5x7d0OQp5vA@mail.gmail.com>
 <aR-MQgYi_FtSsy66@nathan>
 <CADkLM=ejhuvk9TOmYe09kaWdUoCzPci1aYa9+ADOwzP22e1XeA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=ejhuvk9TOmYe09kaWdUoCzPci1aYa9+ADOwzP22e1XeA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aR-TLculrOb2hbRy%40nathan>
Precedence: bulk

On Thu, Nov 20, 2025 at 05:09:54PM -0500, Corey Huinker wrote:
> I have no objections to, but I am curious about the factors that went into
> making dry_run an independent boolean rather than part of vacopts.

My thinking was that it's closer to "echo" and "quiet" than anything in
vacuumingOptions.  Most of that stuff seems geared towards controlling the
precise behavior of the commands rather than the behavior of the
application.  TBH I think it'd be fine either way.  We could probably even
move "echo" and "quiet" into vacuumingOptions if we really wanted to.

-- 
nathan