Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 19 Nov 2025 11:30:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: make -C src/test/isolation failure in index-killtuples due to
 btree_gist
Message-ID: <aR0rxogaaoBOVDXn@paquier.xyz>
References: <lmhmhxxwchxqogb3kybp5w2myvtsamtjkz6y2buowktd3sc3hg@pw5ebya2gifc>
 <414029.1755531482@sss.pgh.pa.us>
 <qbpxtt77f7adpvbb7kjpvlk7amdvizwe4xvjds2to5qzwopck6@iywnuo6w4pnx>
 <aQB3BUxe23YiIOyx@paquier.xyz>
 <rej3pew44i4bgpyk3hl42ftjo7vndesbppjbklqiijo6k4gb2b@cc5vxjt6nvio>
 <aQQF1N23rkKRHMZA@paquier.xyz>
 <CAN55FZ25NO86hpRoZ+vNNpzLU=7TBPg+i92qj+y16Dx0ZhBtig@mail.gmail.com>
 <aRuwXU1QZtl5p3OH@paquier.xyz>
 <aRuyfhvdPXzTJSpx@paquier.xyz>
 <rsgolpgcheedmh62mhvrpbka4skgczw5x7gf3wjdzyye7mnm4m@uimvk3wrq5ni>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rzhyENHJqY3R11y3"
Content-Disposition: inline
In-Reply-To: <rsgolpgcheedmh62mhvrpbka4skgczw5x7gf3wjdzyye7mnm4m@uimvk3wrq5ni>
Archived-At: 
 <https://www.postgresql.org/message-id/aR0rxogaaoBOVDXn%40paquier.xyz>
Precedence: bulk


--rzhyENHJqY3R11y3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 18, 2025 at 09:00:39AM -0500, Andres Freund wrote:
> On 2025-11-18 08:40:46 +0900, Michael Paquier wrote:
>> By the way, an extra argument in favor of an isolation test here: the
>> proposed TAP tests only wants to make sure that replay is able to
>> finish on a standby, we don't query it.
>=20
> I think we should eventually extend the test to run amcheck etc on both
> primary and standby.

It's also something that I was wondering we could do after a main
regression test run for some subset of objects.  Not sure that it has
to be part of one test.

>> We are already doing the same in 027_stream_regress.pl for the main
>> regression test suite, and we could expand this TAP test or add a new one
>> that grabs the isolation test suite and runs it in a TAP test with a sta=
ndby
>> plugged.
>=20
> I don't think we should add new things to 027_stream_regress, it's alread=
y one
> of the two slowest tests and, at least for me, often the test that takes =
the
> longest to complete in a testrun.

Of course, agreed.  That's the part about adding a completely new TAP
test that's able to run one or more isolation test suites, and this
isolation test would be part of it when running things across a
standby and a primary.  You're the author of the original test, so
your opinion takes priority over mine, for sure.
--
Michael

--rzhyENHJqY3R11y3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkdK8YACgkQnvQgOdby
QH26pBAAqN1D0cESz/1wQmJQ/kSnkTRz+rlilWn2KTGvBvBdA+DNwQ4AwCAd/AIL
GbYmdATqlSE3Ogr7iYqd0VQ4kq9Pj3Wj8z388TSupaLbL7s/ML93f5ezZ5HlTZfk
71ZvFqoTXI1vR8jCjdY4jfms96zW3d5if1ueQgvHKeMhtbpFbOoxQOMG4dO7xCaG
8hZav9NphWO2erfk+WJ1+DNB2lQuHn8b8BWuPBngq9F/GFMh25WFBTFmHNmalJVF
N20wSDYvrOdQ44PLwYcKU0hMSiWuiBP9RhHprj2RARM9uYdDeSfg5kv9/83bFPyg
utsWwu/n0HiweCtfsQTRtY3GZiUOE3ci06vBhaq6pkIHREsUQacSC1Ai39Xei4D4
2v/mmfsoP/54CsaOkRnUrGTyR75LDIcVwTwvNy9ehXXy0USg75csvRdLnZ+OVQO4
H14+Zx/iaDYmeEJJDsmA5ooKbPghGSZlOCTxD1zyEnlSt8q7yhkHokWxa7/1xxIx
muYtH3dpmOApC2qojLdyGEu5Y/AK0dZ4fzT2zozNKTsjrcizmCBx864lMZJ5X148
bd5Y6Z75M6MoQ9pbfEvjWh3kVNfoDEg9M59s0zPlNUrvzV+bMCoVThkjDm1siMBS
x9+97zq9mKqKHY7fRVSduXPAWUOHaVc2BPob2UalL28P/PNRDHo=
=0vb0
-----END PGP SIGNATURE-----

--rzhyENHJqY3R11y3--