Date: Wed, 19 Nov 2025 16:44:03 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: vacuumdb: add --dry-run
Message-ID: <aR5IMz4cngn8hkXI@nathan>
References: 
 <CADkLM=ckHkX7Of5SrK7g0LokPUwJ=kk8JU1GXGF5pZ1eBVr0=Q@mail.gmail.com>
 <aRJW2_Yy9ALMkZUa@nathan>
 <CADkLM=fo48tbJ75VPDDNgMV3f-QWLCk2TPujGP4ockxVDFRiTQ@mail.gmail.com>
 <3DB353E5-944D-4E18-9DA2-4151F44AA59B@gmail.com>
 <CADkLM=dgpe7wgjLhnpTycPRzUn6_U9Tk8qNAxHALi4-JqgPp=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=dgpe7wgjLhnpTycPRzUn6_U9Tk8qNAxHALi4-JqgPp=g@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aR5IMz4cngn8hkXI%40nathan>
Precedence: bulk

On Wed, Nov 19, 2025 at 05:23:48PM -0500, Corey Huinker wrote:
> Now with zero hangs and some test cases. I didn't create a function (yet)
> as it seemed trivial.

I still think it could be worth moving the dry-run code into
run_vacuum_command() (which might entail moving the calls to
ParallelSlotSetHandler() there, too).  We can probably piggy-back on the
"if (echo)" branch in that function.

Also, we can probably skip the executeCommand() calls for
--analyze-in-stages.

-- 
nathan