Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJ5g8-00AF1w-1q for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Nov 2025 07:54:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vJ5g6-009zDe-0v for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Nov 2025 07:54:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJ5g5-009zDW-2R for pgsql-hackers@lists.postgresql.org; Wed, 12 Nov 2025 07:54:06 +0000 Received: from fout-a5-smtp.messagingengine.com ([103.168.172.148]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJ5g3-007ItF-0t for pgsql-hackers@lists.postgresql.org; Wed, 12 Nov 2025 07:54:05 +0000 Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id D5C66EC008A; Wed, 12 Nov 2025 02:54:00 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Wed, 12 Nov 2025 02:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1762934040; x=1763020440; bh=U2Sv0fqvJJ UDtsQp3N+7M+DZLGDypzRy+hWa9cAoZIk=; b=qMCCiR1LmcaHmMPyhx/UQGSb1M 1mK9idPFIHVwa7SODkvvAsC5C2cdcTskADi8kqdVkI0JeG0AAlEMJET05xp/mv7C J3joBkL5ChVi+be5tfaxqxiTHE27hQ1l6hdzdALafnvjOhVdg0eKdi/uUVCjxy4B ci0WjkOT636NpYNLQM5xGAEFwUwjKmmImUzimzya+E07TzXYDM//3gPafWIsSNq4 nK4thnCTvzvb5hS7zuoTcGuNNza9tntIf/kSDB0h7uyZWKonoVhuKyJDCazLYE7b 9aC56k5jes3NnqHbSQayYnCKGwrGUPJE2rH6Fi9oFGRc5bHNN4AKb303GmIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1762934040; x=1763020440; bh=U2Sv0fqvJJUDtsQp3N+7M+DZLGDypzRy+hW a9cAoZIk=; b=eLxD8TrA4dLPkw5GdtZEHAsuQ/efp0pWoSCSk9ZJyTtXgd6oBU9 FQBvBTTt1dGMHOX2W+aqUQL8vvDv0PzzE6wxGt4R9Za+0h37Tw0LJe17CQPBiJsh c97/FmmeWAOXVMlLfVeMQa7xqBKzSSvYWnYVo97C9cJmMku+9PPShPE8qgaU6J0E nI4kqFsosgjz5YurYCgPW+is3bzNzrTs8VcVYg2S/3DYyRn3O5yWcVjoNxtPhEfA RK3kfo4wENLyfQIZU7eJxgXukT74O9J2QXvGda0wR/jvUsC7dvbymF+8r4RGBz5o GhwnEm6bB7gniIz5jAu9yPVBG1D2MUHqyEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdefhedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheptghorh gvhidrhhhuihhnkhgvrhesghhmrghilhdrtghomhdprhgtphhtthhopehtohhmrghssehv ohhnughrrgdrmhgvpdhrtghpthhtohepjhhirghnrdhunhhivhgvrhhsrghlihhthiesgh hmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhs rdhpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthhopehtghhlsehsshhsrdhpghhhrd hprgdruhhs X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Nov 2025 02:53:58 -0500 (EST) Date: Wed, 12 Nov 2025 16:53:50 +0900 From: Michael Paquier To: Corey Huinker Cc: Tomas Vondra , jian he , pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us Subject: Re: Extended Statistics set/restore/clear functions. Message-ID: References: <439a9947-e6a1-4ea9-84d8-1f843deaf6b1@vondra.me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="27p6DFZsSkBnH8sb" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --27p6DFZsSkBnH8sb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 12, 2025 at 01:47:33AM -0500, Corey Huinker wrote: >> Thanks for the new patch. And FWIW I disagree with this approach: >> cleanup and refactoring pieces make more sense if done first, as these >> lead to less code churn in the final result. So... I've begun to put >> my hands on the patch set. The whole has been restructured a bit, as >> per the attached. Patch 0001 to 0004 feel OK here, these include two >> code moves and the two output functions: >> - Two new files for adt/, that I'm planning to apply soon as a >> separate cleanup. >=20 > Agreed, 0001-0004 all look good. Applied 0001 and 0002 for now. -- Michael --27p6DFZsSkBnH8sb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkUPQ4ACgkQnvQgOdby QH18TBAAiXeOH9GfJByvGVweFAXbSycjfQo/R5b4lDSsvgoV4bF/kgaZhNagXc69 u2Ie53dylbOITVyehp+Fh5/qRNPZYa6O8QekvwV854ElPqyDB57tvde0rfYP1Tgh 37jZRTdKpdmXR8ewnvhKiVxhAtTVXSTx/1P+a4TcruqHryutB+6+YEuU0AvoNeBB LknVaOdpj+eZ82BAPl6qf/XP58jZcdyoUpSSmPu9CW0N6iVCKrgJ1dZZWWG6du3d /rWKTXydpZ40kz5jVHNHiDtAplKhX8yGLQeDA+zrR7kxeeAdH2I3yuGdUrhVCR0S GjT7VYgC6CVLElbTlTBP0ACJSW2D56tZn+yBtbg+UuPvsflF3eaebHBP+aVZp1W9 mmHUq0mC1/VAP3GVEEEdtgb5W5FUuP16xnKXV0smz4W2nSlAykuvTlVUtkdU+5zB 4bIt0ZdWPIIuzy1INGymaYOkRRZXfHSANjhpQiw0rvGHd5nMHhNQQ7C7gWQI3meG 2rnKDUEfeh8j1rtc8t0LlDwD5CuaExkhh/Aq5kWaLBu0E4HJnPvS4ItYS9C0LsP6 yPNZcYBY1shQ6EwKuOkE1ZAvgeknPYGTnMQUuwdiN2Yi3OPhe8lEFeYHJM6YrTYO 9Ot0LCdqCXbVVEC/hgeaVPKM37AqvqgXA136hBUz2bJjyb9Uf2U= =zDH7 -----END PGP SIGNATURE----- --27p6DFZsSkBnH8sb--