Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vK1Uf-00CMne-2z for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 21:38:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vK1Ud-008Hgt-1a for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 21:38:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vK1Ud-008Hgl-0c for pgsql-hackers@lists.postgresql.org; Fri, 14 Nov 2025 21:38:07 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vK1Ub-007mqj-0M for pgsql-hackers@postgresql.org; Fri, 14 Nov 2025 21:38:06 +0000 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-93e7d3648a8so88830039f.2 for ; Fri, 14 Nov 2025 13:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763156283; x=1763761083; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wOUTsn8fcjhy0TWzXdI+IorahuEZrfoEebtp4NCSyIQ=; b=Ej8DJcbTtEsaKtMT/2rvlxVO32LI6WHsT54ZdE8+/DgSAS4uksMiPUy41RGFo7R8WK k8BALS7jldYxizp3RRwWpB6bhxUdosEHGafC2iHy5MBZxS8a0aWiRr6kTCSiSh4Hm9LS 8I23qDUxrK2Ck+7QyN0mznuFX5bdS3I8mXu46uaLw94DQEa1RZI7Yjf/IZySXQQbALJO 2dSTtrQ2TOfmiBWw5wShSz84pAEW+LGkB140Gey79O6o+rWqJ6sWDh0CKrAgEd4dD9SK HvAHEoV2p7QC8aoXURFebCVVGtoKpWe03Y8om4t5iSpQGIoKzbVQSNXZHZxIb0NuyoSK vH0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763156283; x=1763761083; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wOUTsn8fcjhy0TWzXdI+IorahuEZrfoEebtp4NCSyIQ=; b=d2wCh084zeKjnRm6bVKGzbTmJNqVlihWHZhsLkLx/PAq1pl784eUp+6TxonyOsP7MW bV7WcI45/YBjyU/vSxoarcGbz1DB3Eysqr3qV7cjsf1VJGZpQUfazlnynFiNIQNk41cr Q8fxYKm3kmMlk7IvZ3RsfOvfuKCoyrGHL9rqpZ7+DFl22ALAXt6+90b+HtcrQqODcOk2 vj9+8CXxW3vSxVvIpjcwiZx3TZW95ipQNzPxb+UDuvUxqjISMu7NP3MLo9txjFr/BBBY pDsCQdWZXDpO9Gans53Qb2deGVdkvi1CrI9NdOlh9/fqjyWZ94JE7APG3Ro2WPOp8K1v u+OQ== X-Gm-Message-State: AOJu0YxpUxpXCE8XwrbBSl03+h9dvCp+tJdiN6F/9X8eyGXXHGLSLOwK Vx90+fhWG5sn1Q98H+ka+iPBskpjpwFuvwkxqT0l+ilfuFJOR2k+NhOs X-Gm-Gg: ASbGncuZE7UCspRw6eFtukvpu0OD5gd51JFhRthSSBkGtrG1Hltt6rK1eUNBxABZNP0 alNMLIcLa7ky1M7DU4bE0FNsomKuiEZhb23BAnIqI2apQ62Wz9MjdG653WYt8Aftx0pIDr2Thb0 6cjTGZ0I81zUrzwx0XQ/YwjSL2I3dAgypKgmgSE0CMLovKq6LygcKWZ/0bcHDEzjKPKKxD3onfe wwaDQKgHqzX4iDGbgwEJKKFt+LZ328xB7kSkv1Ye2Ss+wXzgvrQe11ODHwBF2d4n+GYP87nLzFE 9tEZX4pN+ObiSW8asIv5JtYzXbrZqg/lOEsscpP6iL4o8qHbOHxoUOz1e1Jq26PTR3Q1uARiqrw J1HoqdWPVB5LZW+30Pmjz5t0wWU8/3whpqg36S1fYEotTkrXBchy3oS79HHRi7dR0F5h5TsRkwu 4MxbDlaraDfAQsEjbllmwLWnzHMAcI9L+UszYQ2ipvN3LQw71Ok6M56PyXMGaEsZufLQ== X-Google-Smtp-Source: AGHT+IHgZTj6t3MghE7iWVlJtH1GUiFdRPMwYvKLP9Vko3WFZEE0f5Ko5p1om5KRS2DVB+sBnSJPMA== X-Received: by 2002:a05:6e02:3388:b0:432:10f9:5e0a with SMTP id e9e14a558f8ab-4348c93b625mr63158255ab.19.1763156283049; Fri, 14 Nov 2025 13:38:03 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-434833c5ef5sm33872145ab.3.2025.11.14.13.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 13:38:02 -0800 (PST) Date: Fri, 14 Nov 2025 15:38:01 -0600 From: Nathan Bossart To: Tom Lane Cc: pgsql-hackers@postgresql.org Subject: Re: postgresql.conf.sample tab width Message-ID: References: <3230808.1763151915@sss.pgh.pa.us> <3238135.1763156048@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3238135.1763156048@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Nov 14, 2025 at 04:34:08PM -0500, Tom Lane wrote: > Works for me. Do we need any special .gitattributes for the file > at all, if we're relying on the TAP test to catch this? We'd at least need -whitespace (I think), but I figured we might as well highlight beginning-of-line tabs and trailing whitespace in diffs, too. The TAP test wouldn't catch the latter. -- nathan