Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vL3Db-001zAG-2b for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Nov 2025 17:40:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vL3CZ-001J3E-1I for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Nov 2025 17:39:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vL3CZ-001J2y-08 for pgsql-hackers@lists.postgresql.org; Mon, 17 Nov 2025 17:39:43 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vL3CW-00029q-2B for pgsql-hackers@lists.postgresql.org; Mon, 17 Nov 2025 17:39:42 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-47796a837c7so14887425e9.0 for ; Mon, 17 Nov 2025 09:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763401180; x=1764005980; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VvseZ+kJgCQ6GjsedTTlimo8HRyyNz1LHr1cNC9P3H0=; b=WFn/puBe2sz5eWkbYFvW3xW8OjjBSynqnYuRMgJLG3Sw9zbbjGJYPefoYkOxhpFgr4 uPQ269kjefqMvWWokLnToLiJqdd9ddeYA6+LujSrkAIIvrjFjZUGohAHBbocIK5CiSMK bC+pjdf1hMUA3SickYpyNV/LjsSWDYH0+8LLyQBb5dqeNHPE+fNSvQS8LNauRuYnb4An WLmr/y9Lznx0iUK6o0Dz1t51pMjOn6b8CsRP/v0/DDF2Htv1w5qJr54VGfLUqyACnhee 0TAaFXag4jhsSGot6ziDV+FChSII0xOmNAtM35ndO2JkfxbM24Hb2+F++S5GW6MjDm78 VKOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763401180; x=1764005980; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VvseZ+kJgCQ6GjsedTTlimo8HRyyNz1LHr1cNC9P3H0=; b=Encb89+EAgRabxWKoG+cUmDih+lvfwFP3dd1KQXNShJPJaO3q3njK39csM88VY3IM3 nfqn1PsIt4qMn1/ejXTLGqVbk+Lo4Tptrx+B33XF+hPNa8F1diademWufPATSbJ1/1oV O1pTajmO+2WrfkWDGEr4ZD68rR9OMeAcUYKyHq6NLNVcd3XsXa7CYJvvCKetpog+ZtrE iwNIZghsuqWU98WkYhUtXK2e0NvkL4YFbYVUoL8Zojo1D2Q93CVMrXQMTj14PfWat23P Id3x8tiR3PrXr0GzSCYZjys52nJUrPtNwuXR7EJRMSo8tFSQFbQqpRCtleDMwxKAp6Si 7r4A== X-Forwarded-Encrypted: i=1; AJvYcCW7AbvrZUQRMUCiZXQ8ac4EXlX6auMp5QRDt6KaCwv1/geavgYUcq1Q70FAGRdC+hMPd3L8MO5O0/3TvL6Z@lists.postgresql.org X-Gm-Message-State: AOJu0YyDUPNlJd14avZ6H7QbCqqgTe/LUL5M7B20t2KiUuh2JHwszNSM +sUvM9yedYMUsAvWBPIMPBpIkfdFOzvyJPwZE8hJ2b3NPAEiggq/EoTJ X-Gm-Gg: ASbGncsUUknQSWdtDLrf5IVHWR3Bk5LIirMULUk09T38dK/EMtGuglZBlkTWZCQDMXQ Lcqc4yPRL5yZtYy3dc5ZxAPjDDg9Y8DyDR+68UemP9Mm6R0eWyBdCPpjgrwzTaYRRSRm/fwFd2r fZl8qWE/tVBOCTaXI4JKTk1t70ocDILke4XZJl/5/sPccBIvDw4C4v1+YPQnm4ZtFaeSGnqtXKE GWQqP7jFomkIFdD0UcN498MIu38EJpqfZgPKH3jP8RF9WwwiNrYZnTB6xGvKi9OYeyqxpJRObI8 JL1vo7FoNsl6r5WXcz9TAYICbQL44kv/wtCJXiA7rMQzW4b5vs1mEBdta8sKSv8HBo3+UGjOFSr S7YOS/hG1U/2lZb2lv1KJmZOziqVERYGkiMOPkpGY0z6GBjPBBVD8JJpQ6jyDXvh0sk5SaZatMA 6MyQmDbsyOkmujT3tnhPXEM/V1xmi9M9SxY+GRjI2L31xcU8EySDTKzEhO7TMhTYWvmY69KtQYE eYmKx22OZFiYLzSQmoTH9wTTwW6ByIfSqU= X-Google-Smtp-Source: AGHT+IHwZZiBbNteyZ5BYTZMAk+OOvkUSS1cTMF0mO6s+bpkgMFbuyqwFwu0zVc4wn6Td8gYi0MSAg== X-Received: by 2002:a05:600c:6b15:b0:477:97ca:b727 with SMTP id 5b1f17b1804b1-47797cabba9mr57966025e9.19.1763401179422; Mon, 17 Nov 2025 09:39:39 -0800 (PST) Received: from ip-10-97-1-34.eu-west-3.compute.internal (ec2-15-237-181-182.eu-west-3.compute.amazonaws.com. [15.237.181.182]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b62dsm27408474f8f.24.2025.11.17.09.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 09:39:38 -0800 (PST) Date: Mon, 17 Nov 2025 17:39:37 +0000 From: Bertrand Drouvot To: =?iso-8859-1?Q?=C1lvaro?= Herrera Cc: Peter Eisentraut , Michael Paquier , Heikki Linnakangas , Quan Zongliang , pgsql-hackers@lists.postgresql.org Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro Message-ID: References: <202511131242.kcbmff4tc5ss@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="YfygNfEzRppWnjH+" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --YfygNfEzRppWnjH+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Mon, Nov 17, 2025 at 01:12:24PM +0000, Bertrand Drouvot wrote: > The script has been updated and the patch too (finding a new replacement in > gist.c). Finally, adding GistNSN to the game (as a typedef XLogRecPtr) gives the attached. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com --YfygNfEzRppWnjH+ Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v10-0001-Replace-literal-0-with-InvalidXLogRecPtr-for-XLo.patch"