Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 23 Nov 2025 15:57:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>,
	pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: Extended Statistics set/restore/clear functions.
Message-ID: <aSKwW00LiORNNoxC@paquier.xyz>
References: 
 <CADkLM=d_mmTn3+ChL-z_ZomwOKT-BssQU+=6_a8WDv6A4b7uAA@mail.gmail.com>
 <aRbLV7Tru3ulO5ru@paquier.xyz>
 <aRrHBj7I4CeV21dj@paquier.xyz>
 <CACJufxGGzkb58BU+YyTa9cBAawhybwk2cPFZ1XupS-8xuAzN9A@mail.gmail.com>
 <aRwGeN7o22HJclg5@paquier.xyz>
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Xg5dpgeMDPnGA/sN"
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aSKwW00LiORNNoxC%40paquier.xyz>
Precedence: bulk


--Xg5dpgeMDPnGA/sN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 22, 2025 at 03:26:19AM -0500, Corey Huinker wrote:
> I'm open to it, but there was significant pushback to having tight validi=
ty
> checks on other stats types.

Yeah, I am not sure that there is much value in having strict checks
for the values.  Some control over the arguments listed in a single
object is much more valuable as these are easy to check in the input
functions.=20

> The more things that we make errors, the more chances we have to breaking=
 a
> dump/restore. Granted, such values should never happen, but odd things do
> happen.

Indeed.  Like the existing import functions, these should not lead to
hard failures, but WARNING-level reports.
--
Michael

--Xg5dpgeMDPnGA/sN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkisFsACgkQnvQgOdby
QH2nxA/9FDj5Mo0ALHrUBQ6EOe6wSboXtSCXBfb+oyqs+0zUaFPunyI54Pt7hdOK
M3dOSz4oFm2Htcn38sbJjXkgtIIP+79v5nGE4hetpOpvsCflrQ+iboOn5JJAjkec
Mznj5a8G1bH368SWk9004pxtuj5Rv6r/Y6TfhFnReYZID28dET0EYusR3ykSDTqW
p8I7iO6F6rWPSbebsKhpSIPAurSTzB2iAFA3HWDvBfFMi/45xaaWk8NdbWIs9azy
xgCJWm9+gkVcpraNd8GawAP7WuSDRscAOsExf9ldRtsYYVtkQN0zZwrgSN83/g4u
7GJbeVykSz+R0oeb+E69a+t348Kgl3CIADjszbJVA6eD/uI5wbr3ZSxEza9Ehft0
rREclHFD3Ra55p+56bgcy86s0nZYd4hgbXE58oa6K3JUfZqzzBmhatvYtrldy6er
vefP3MY7Y3B4zi5fbC6FSsKFnYj7AEKbdjfdQE4YtZRzmY1YveYYwhsgVtibntXd
mrKqyvU3yM2BugnwbGdQ936J97ZyMbId/Xewz79A7quDtls238v9gXfFs7TJnLWf
2Y9Gs3Egj136aHxMRJFhhga6EuVEBGw5zCCeyTdoKs7Q1IUWk3q9gNdB045Y6exi
S57z3z3buyTCSaJA8wC0Q3lRjMivJ/a3nOZKn81Ed1SUGlZjmFA=
=GJzt
-----END PGP SIGNATURE-----

--Xg5dpgeMDPnGA/sN--