Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 24 Nov 2025 09:10:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [Proposal] Adding callback support for custom statistics kinds
Message-ID: <aSOidfDnBT4lbtHp@paquier.xyz>
References: 
 <CAA5RZ0s9SDOu+Z6veoJCHWk+kDeTktAtC-KY9fQ9Z6BJdDUirQ@mail.gmail.com>
 <aPmh7uoW6_EmxFHd@paquier.xyz>
 <CAA5RZ0ux07=E97mJ3JCy2jhs349NKzj7SPJNbDWZ11m9BDkTQQ@mail.gmail.com>
 <CAA5RZ0tnopAS4MCcoxXdJShYoGxYZgsoDXCjcie0Q-2TBPuJwA@mail.gmail.com>
 <aRJzdl_cSc3XHX85@paquier.xyz>
 <CAA5RZ0skT-uWwgrCg3Hj3AQaBbQdN0h72scD9GBLxH1nEKSNwQ@mail.gmail.com>
 <CAA5RZ0tH6ih3anQ=Lcwttm+8BURJ8VkBoy_9V8Ty73ZA1r384Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="nAdqnbw1ulEdny0F"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0tH6ih3anQ=Lcwttm+8BURJ8VkBoy_9V8Ty73ZA1r384Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aSOidfDnBT4lbtHp%40paquier.xyz>
Precedence: bulk


--nAdqnbw1ulEdny0F
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 19, 2025 at 08:10:43PM -0600, Sami Imseih wrote:
> It just occurred to me that the documentation [0] should be
> updated to describe the callbacks. I will do that in the next
> revision.
>=20
> [0] https://www.postgresql.org/docs/current/xfunc-c.html#XFUNC-ADDIN-CUST=
OM-CUMULATIVE-STATISTICS

Hmm.  Based on what I can read from the patch, you are still enforcing
file name patterns in the backend, as of:
+          extra->statfiles[i] =3D psprintf("%s/pgstat.%d.%d.stat",
+                        PGSTAT_STAT_PERMANENT_DIRECTORY, kind, i);

My take (also mentioned upthread) is that this design should go the
other way around, where modules have the possibility to define their
own file names, and some of them could be generated on-the-fly when
writing the files, for example for a per-file database split, or the
object ID itself.

The important part for variable-numbered stats is that the keys of the
entries have to be in the main pgstats file.  Then, the extra data is
loaded back based on the data in the entry key, based on a file name
that only a custom stats kind knows about (fd and file name).  It
means that the custom stats kind needs to track the files it has to
clean up by itself in this scheme.  We could pass back to the startup
process some fds that it cleans up, but it feels simpler here to let
the custom code do what they want, instead, rather than having an
array that tracks the file names and/or their fds.
--
Michael

--nAdqnbw1ulEdny0F
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkjonUACgkQnvQgOdby
QH1LEA/6AqjO4fuHsEEWsMw29LQCbDfkWvl9nqIVu6UzCaQxI/upcgbWw2I/KGOf
MG/0gxw+rxp3yDRxhcxGGMHtw78inHqdgVs9mz7m7cx/q2wd2fpaQCI+4sZrs8vh
MB+T94c/u2za6CdhIpezKcQ7mHTvs3YwBYey7VSCd9BWkCkdGO2GuOcAWErF+2ee
SOHhEelfDFkTUVLOZ9Lz7r1sUaq2qYlmni24JpH0CcWLf5piq4PEXO45+Pvc543t
RyBIDp0ETupZ9XtMHmi/Mq13nWJtDpf1GSsmgYJkQ90MQ2S0cT2r1+uSG+wj9juW
Yjh7DaR/yAFQkRVoOQS3jByTBwFQ/SCUO3PVzmsQ2P6sWCIpwnf46gMsOiYKrrxy
+EUgohQfgCKPNJqNVze6q2fyH6HOR/+BLh6YgEBhMqu2m98ju5G41UXvAK+Gf/g3
K6F3oxg1QF4zY7yDtxwqzxdyU8zSgEK3B0xQT/Llovl+sXvBc07zLdj6yg518QDp
XvZ2Z3FmEBnFefSNgG3lCHi+UfwGuVmqQBAGZSWVc0vyQ0S8sens9VhOKRJoi/95
/lui+XjmqlJr+TmG35RY82XIy/2f+nH8dYe3cEIjFSXRVoStNO6tzV8dpn7+Nu72
cPkjGJfuOMe6DcK/FavleVGF67r4KgsZWaXNaVTfi6Tep8+73zg=
=Ju+Q
-----END PGP SIGNATURE-----

--nAdqnbw1ulEdny0F--