Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 25 Nov 2025 19:06:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
	jian he <jian.universality@gmail.com>,
	Tomas Vondra <tomas@vondra.me>, pgsql-hackers@lists.postgresql.org,
	tgl@sss.pgh.pa.us
Subject: Re: Extended Statistics set/restore/clear functions.
Message-ID: <aSV_kS5_pL4DYw1J@paquier.xyz>
References: <aRrHBj7I4CeV21dj@paquier.xyz>
 <CACJufxGGzkb58BU+YyTa9cBAawhybwk2cPFZ1XupS-8xuAzN9A@mail.gmail.com>
 <aRwGeN7o22HJclg5@paquier.xyz>
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
 <aSVas5CIr1mvR2VK@paquier.xyz>
 <EFE9F959-01C6-45D3-9EEE-F06C766EF3CA@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="CO/qdnVhXxD3Mb9z"
Content-Disposition: inline
In-Reply-To: <EFE9F959-01C6-45D3-9EEE-F06C766EF3CA@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aSV_kS5_pL4DYw1J%40paquier.xyz>
Precedence: bulk


--CO/qdnVhXxD3Mb9z
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 25, 2025 at 04:59:28PM +0800, Chao Li wrote:
> I don=E2=80=99t see any of my comments are addressed in v18.

Sorry about that, I thought that v17 was addressing these.  I have
reviewed your latest email posted here:
https://www.postgresql.org/message-id/2C8A20C7-4E08-41F4-B30E-AD9F8B007AE5@=
gmail.com

And well, this presents a bunch of issues I have already fixed (break
after return, one error message incorrect, some descriptions).  The
comments on top of the functions are actually true as they stand (aka
ndistinct_array_end() fails if we don't have an array).  There is no
need to reset state vars upon a JSON_SEM_ACTION_FAILED AFAIK.
Finally, the consts are non-appealing for me for functions that are
internally used in these files.  And forgot one:
valid_subsequent_attnum()'s duplication is actually adapted IMO, the
argument lists could have different assumptions depending on the type
of extended stats we are dealing with.  I did not check the comments
for 0003~0005.  Perhaps you are right that these need adjustments.

Thanks,
--
Michael

--CO/qdnVhXxD3Mb9z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmklf5EACgkQnvQgOdby
QH3tpQ/9HFcZQ02drofY6JiwPROFmf9vfCZesYo6x3SmbKbS92do+3coufLECJxC
oeTB6jw9JasEFbGWD/y/EcOmLJAMyc030Tv6tZDp88gJ6cZ5sZsWWj5U8N81l5ZP
FVfsNpFl83aERsRxhrxE6vMaldjIuIPK5X/7f9+UwS7FVa4Wt1ci/ThyOpvXiwTD
boHRTBBWrHgIiclWPl44eakcHHm7yb8frDk/V8EyoLhondLgyfqwzdGY4jLDUnMp
vjvumRm6MTeU2sSNqEemEwqMVpMUhayNaPTtk1FKQk+NiNNCF8lSomYXmlGMEIne
6DyzxaAHbYM3ZzKYspzGRFujMwqHbDIauGk+m4wN41twnP7spyQBcPi6gWMOy7h8
kUXcuOenGZnSdFX0qIQLnwPPNAvFeCYRkcujIOiRa6yuPcu8cUgea2fLFLd8VZ5F
pqu/69JISD4JFbztM5dhzLY4IYamAwz4lrMvw0OZya+ONnZNZf+vUTpPaYfms/oQ
v5SQkBmFOlBwuC6PMLQktWPp6HugwmGRTROWe9RbS8KbHOn4UyBgDsmKiJGB/Nof
SwLHBElqofdETehq/k5LrA6KalYOuD31anrDFN01BlTZDOlgJz8A4+DLkDbc7ntB
3LMQKI1d9AkIEMgXqylMKU74CfoCJM/C4rS7g863oJiiv2zvAsc=
=FWm0
-----END PGP SIGNATURE-----

--CO/qdnVhXxD3Mb9z--