Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 26 Nov 2025 11:06:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>,
	pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: Extended Statistics set/restore/clear functions.
Message-ID: <aSZgkssl7NT1jI2h@paquier.xyz>
References: <aRbLV7Tru3ulO5ru@paquier.xyz>
 <aRrHBj7I4CeV21dj@paquier.xyz>
 <CACJufxGGzkb58BU+YyTa9cBAawhybwk2cPFZ1XupS-8xuAzN9A@mail.gmail.com>
 <aRwGeN7o22HJclg5@paquier.xyz>
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
 <aSVas5CIr1mvR2VK@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="M8U1wBIgaGXBcIPi"
Content-Disposition: inline
In-Reply-To: <aSVas5CIr1mvR2VK@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aSZgkssl7NT1jI2h%40paquier.xyz>
Precedence: bulk


--M8U1wBIgaGXBcIPi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 25, 2025 at 04:28:51PM +0900, Michael Paquier wrote:
> With that said, a v18 for the first two patches with the input
> functions.  Comments and/or opinions?

Okay.  I have gone other these two and after an extra round of
polishing, mainly around comments (some suggested by Chao, actually),
style, a fix for the test with valid UTF8 sequences failing in
non-UTF8 databases, plus a few more tests that were missing, I have
applied the two patches for the input functions.

Perhaps these will need some adjustments, but I also see little point
in moving on with these based on the coverage we have and how the code
is shaped.  Could you rebase the rest of the patch set for the three
remaining pieces, Corey?  You will also need to address some of the
comments from Chao based on a review of v16, that were not addressed
as of v17.=20
--
Michael

--M8U1wBIgaGXBcIPi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkmYJIACgkQnvQgOdby
QH2vqxAAgOyepYrlqtY8XbdRJ9gptVon1lHsZ9dcPZA/Fs746ArhAHZsgp+9R28M
ms6LKHr37OIc8+iNCg9Mr6z14TtO8OtONQan+2vqLkdLlxYTslc0ViHrWMkiuQUq
ksfP2FdmkZZKOIfYKNoCL6MBvE6iQSe22+kJHun1G/gtDtMP6Ezmfw0GrNH2G1cP
krzxV1JQXLsMC0sq4FWn9Ak/Nzo/qZN4yvGY1plnMzknoM12bIbYMJUnrmeeP26q
gzdUG97Hh69+ExO/OnR/0PkiZ8/N6917mgjhL5igjvEL0fv9OdUZys62+IyvfCre
lmuso2q5ICxlGPpvKzNN33+SaRwg+pL1KFSxhC3lUwuRC+ZYdqDtMQHB9QGn3LsH
UhYA5mrt5gi8WliJoUi/KJyPmEoXUY1rBsRnmfuTpBA9JSvsIXr7JJ/pc1gQs7of
LrC+ep0KKedM+pPaIpY/cnJDQ/Xl6N/bNiM9hl/Ehn7KRNe3ENFjU9pKMHoWYk7n
eZYCV4IvDi2mRw6R9xMmZ8TRJKwFnS/Wf14+KcyAuLNXJ9Cw5AaAt3G/Hz9PqBCM
UbpqshVzrJHW2gapiVihcij3DfLYn2/3EKWxeNuWp75usqF1jK69G638StS8JxUb
9RxGdCcgw6c2bXSNT0jmptBYKF0f3FyCVbpp7AGLdx/HFTjMoGc=
=8Vhh
-----END PGP SIGNATURE-----

--M8U1wBIgaGXBcIPi--