Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vO8Kb-00BXVF-0P for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Nov 2025 05:44:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vO8KY-00E975-2N for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Nov 2025 05:44:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vO8KY-00E96u-1R for pgsql-hackers@lists.postgresql.org; Wed, 26 Nov 2025 05:44:42 +0000 Received: from fout-b2-smtp.messagingengine.com ([202.12.124.145]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vO8KW-001YAI-2c for pgsql-hackers@lists.postgresql.org; Wed, 26 Nov 2025 05:44:42 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id A06951D0016F; Wed, 26 Nov 2025 00:44:37 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 26 Nov 2025 00:44:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1764135877; x=1764222277; bh=LHOPc1NIOF B9VuMqWQPNkVP3cQZ4JFH5/DQ8laXZVwE=; b=eEuX/jv6GeE9624GbYZq4AbWmy KdhHsKo/3jf4JT4u1pbCWhxTIXvFL7ruQAtI2zLKOZ6t53yqCaYeLI0PQgdKQt1x 6UQMcCEHM5lA8A6BPVEUpME9QLxzrKUFUAhk32ZB8nuW+8Ce7IdIuZoewS+y6VA3 BXebyXjvR1cQUMUs7StFaFD9lHqOAIfUtKfL4SHqI7MjzAfiTGxYrBkU18wudSwB AACGzIpfZhp32pSu+CxdY221mvlEK7A81CmKgCA5A6tlfUuLkYq3KAzKDKm/H2/P elWHd1CfGyH1NxHmtiM4nAqK5eB/igJnLgNjhCMd4+QLI9Sk9TrUQr7xga/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1764135877; x=1764222277; bh=LHOPc1NIOFB9VuMqWQPNkVP3cQZ4JFH5/DQ 8laXZVwE=; b=ovAJ5yzm/vHClxJdFdc1LwnsGg6RcGIU3JtFozhu5sVV9syzi2t i0+1jfwOpc7e0R2kr5yvEffcelKgwjjenmE75NIqTTh/BRFNERzG8gfZsvMEbbhr XxV68wSYmPykjflC+TUA6uKYQ2gvfeHd6PaiMK8RRmG87g3jCJFMxylJWMRlm1uj KOEq0vV4DQn+uynXBbEI63mZFTyy+vh7Cva4kOBJCXnsKtxmrvEaSsO4j9InQU0e dWrZN15DQ7UB4/Vkt2ptaY8NWLfuzvd2BioXWu98sRA9JKG0IhCWMgBQCHpj6xoY 92EW7GCsG/6HPhaMQkBe++6bV9obfvfDr0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeefheegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheptghorh gvhidrhhhuihhnkhgvrhesghhmrghilhdrtghomhdprhgtphhtthhopehjihgrnhdruhhn ihhvvghrshgrlhhithihsehgmhgrihhlrdgtohhmpdhrtghpthhtohepthhomhgrshesvh honhgurhgrrdhmvgdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhs rdhpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthhopehtghhlsehsshhsrdhpghhhrd hprgdruhhs X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Nov 2025 00:44:35 -0500 (EST) Date: Wed, 26 Nov 2025 14:44:23 +0900 From: Michael Paquier To: Corey Huinker Cc: jian he , Tomas Vondra , pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us Subject: Re: Extended Statistics set/restore/clear functions. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WKejuVaAcJYh3KYi" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --WKejuVaAcJYh3KYi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 25, 2025 at 11:37:09PM -0600, Corey Huinker wrote: > I've reviewed what you committed and it looks good to me aside from the one > nitpick I already made. I was not really excited about these as it concerns only code local to each file where the input functions are located, no routines that are actually published for consumption by other parts of the backend. -- Michael --WKejuVaAcJYh3KYi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkmk7cACgkQnvQgOdby QH0iOw/+IthVtywoMz8OUXer26Bf1fA3UYxgSdu65Wtas/npwHyGNaQUpsnFhKh4 SA8plK2Z9i52h0a8eRYIcgC5w8R3HpXHgS7E400u4HAQ4JnGrl9W3+Ccmhtn3NWQ VUBYM3QTwlOeQMCQqfSoRUVmRFDKQ7ZT9WTU/vzDMrLePByPZqCfLtG/IpK0+R2T WsBB7+ikChp4CDAvTAFoibfmNDMZNTrGFD+mXqOr10Yh3RBMq2zheA8PzAbgfoyH ERGPJeWASdXzT4NFwJJkfT7bQ8i4srKhrwyZt2cdvJdPAkvnPd/lMI15T3jqyaF3 iaxUsdElo8UpWWn/mgZ4JansCOCn/xWUVM57m9unVedUDOIDQLZBbQLpwgBiTEM0 /CHNCp6CiVJEDuqQW32l0kwGKTo5f0ABnw5AbtS2KBqrjX9jHL/qmejMQCz2WGQ1 5tH7RkeuHG43DxRXu6rTn8KsZg9PVhps+0gS6nfO96adp955Mu0M7Hnl78JmT92f M22T1FkuJV0CocoWOAeWHLuLAgaRgXDV7KyomfRQhIvE05i12MqGdj8SYQMoxXVp wOdbPgJW10LByLpq+wDo7kexRZglquouUvuTrBbMFH3bfqYC4jePuHjEGcq/kECj 9hjeADkBnK4FOHWA0LWyeCPic5eHZ4Dhi2BJRvzlN2pgIaG2nGM= =x6Eo -----END PGP SIGNATURE----- --WKejuVaAcJYh3KYi--