Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 26 Nov 2025 15:16:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>,
	pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: Extended Statistics set/restore/clear functions.
Message-ID: <aSabVhUnU8E4VPF7@paquier.xyz>
References: 
 <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
 <CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
 <CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
 <CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
 <CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
 <aSVas5CIr1mvR2VK@paquier.xyz>
 <aSZgkssl7NT1jI2h@paquier.xyz>
 <CADkLM=dJzKGDK6aTEaO6NUFmSZ6wTc9Mtkho7KOEaQzjVQy60Q@mail.gmail.com>
 <aSaTt-f5KL9BKkD-@paquier.xyz>
 <CADkLM=eLYkp=MUTLeu9C5wawON=+DbYyQedOkSH0fwpLS5m=tQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Sl+yheKr3QDaT+P3"
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=eLYkp=MUTLeu9C5wawON=+DbYyQedOkSH0fwpLS5m=tQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aSabVhUnU8E4VPF7%40paquier.xyz>
Precedence: bulk


--Sl+yheKr3QDaT+P3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 25, 2025 at 11:50:14PM -0600, Corey Huinker wrote:
> So if a function were previously static to one page, but now had utility
> outside of that file, you would then consider changing the function
> signature to add the consts? I ask because this may become relevant with
> the statatt_* functions being moved in the remaining patches.

That's the kind of analysis that requires a case-by-case lookup.  The
input functions were not really that worth bothering to me based on
their logic being very isolated.  The refactoring pieces with
attribute stats that you are suggesting in 0003 may be indeed more
relevant if done this way.
--
Michael

--Sl+yheKr3QDaT+P3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkmm1YACgkQnvQgOdby
QH0SUw//awVben4dED+cMqL5U909mB/kCTC1eXvgGxkDy7ZV2XwnD0WGoWxjwNI6
kk58UXSg9FFh7PErfl0I/sxMU+Wi6tqcjccsEexux+6VYRT+tlvpVZGRrsNG8GGt
rjE+OIcdS5sE+JtHuP9Ee7mAkP9GmjeB9A3iOj/54cIZvCKfngpgwf6SM6D0Au8O
e5sPQGGozRtp8s1jJaovSVLmExIG38QRqOLsMwox2ulmfR63vRCLeguKSzrzMmOR
DovuzTtS9eHmnAzM7CfcgXpxK2krx6A28lK23ViUHsr2Rk4ey6yADBZPOyfmKep2
nh1B1WU2STkQBoAEOM26xS8cq6aXb5azfSmKT69rKOFEmrTy8ckB9ntt/qyos8wl
Ws5Y9aIJ8zNdWBZfNkXqvmbR38wNSAc9RHo8IxJkjDvhrBobtDKlhqnz9BNVdjWO
DTqCgq/IP8KqBzuav6LX5F8q78dJbaYfT5H5IdY4YS1Syb0o0mUJWdK968NKbVxI
DdbcMjpTYzATWskaBTtE6MH/OfGV2KeL4npVjlJGBA6oZZ99nk47Xj+GV5b1IaMx
mZaxInsMoR00UE7fbi8XgtDDDsAjFCWH8En4zcgcNB1rTIFSCvCQm+EjYUVj7bId
1g+Keq0wc1vE8PE8gljU+qyTQSuOzPmjmAJkG0DlHeLqvZPNT10=
=X/bI
-----END PGP SIGNATURE-----

--Sl+yheKr3QDaT+P3--