Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 15 Dec 2025 09:55:43 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [Proposal] Adding callback support for custom statistics kinds
Message-ID: <aT9cjx1fgtXyCKZG@paquier.xyz>
References: 
 <CAA5RZ0vQvmatp8VAk6zroyeKDCw+QVq4XmoRNAFogQo6bJEbNQ@mail.gmail.com>
 <4E61FDC4-CFBB-4116-980F-75ADD245A1F6@gmail.com>
 <CAA5RZ0swDCK+7M2KQip0tqUsBK3LUHd3F0ytpsKdDCfygHksKg@mail.gmail.com>
 <aTkpgP9Xe5QJ5sDu@paquier.xyz>
 <CAA5RZ0uC4j2QGK85ma6bkF6YOWBrYX9J3dV2CEMg3d0CBLpHSA@mail.gmail.com>
 <aTuE7kyeDCggXqVf@paquier.xyz>
 <aTvi5ceF-pB1IbDR@paquier.xyz>
 <CAA5RZ0ubfcmkkY7i07CmrkY12H8BsRXDoOutYXjYz0gsq7hm-w@mail.gmail.com>
 <aTzIvl7_aXnBzH-t@paquier.xyz>
 <CAA5RZ0sqBonHZfwRi97Nn+sq-16Ab4wOZ8+z1PoBmhcmxHD6Dg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="T2h1pKBLsXtHPvIw"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0sqBonHZfwRi97Nn+sq-16Ab4wOZ8+z1PoBmhcmxHD6Dg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aT9cjx1fgtXyCKZG%40paquier.xyz>
Precedence: bulk


--T2h1pKBLsXtHPvIw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Dec 13, 2025 at 06:33:41PM -0600, Sami Imseih wrote:
> I just remembered that we should document the new callbacks in [0] with a
> brief explanation of their purpose and a reference to test_custom_stats
> as an example of usage. What do you think?

I'd rather keep the documentation simpler, pointing only to the
code templates we have and pgstat_internal.h.  One reason is that code
in the documentation tends to rot very easily, particularly when
applied to plugin APIs.  If you think that some of the callbacks of
pgstat_internal.h deserve more documentation or explanation, let's do
that directly in the header.

Saying that, I have tweaked a bit more the patch this morning and
applied the result after splitting things in two: one for the core
backend changes and one for the tests of the new APIs.  Some comments
and error strings have been simplified and I have noticed some more
inconsistencies after a follow-up read.

Another thing that I did not like is the use of "long" for the offset,
which is not portable.  We have a drop-in portable replacement for
seeks and offsets: fseeko() and pgoff_t.  That was in the test code,
but still let's keep things more portable in the long run without a
4-byte limitation on WIN32.

I guess that we are done for this thread then.
--
Michael

--T2h1pKBLsXtHPvIw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk/XI8ACgkQnvQgOdby
QH2JxA//b+kIeURLMh0Ra/bTWh7dQRd4/Ku0us3XJKifYEZ6iR64kj3BZPWx3A6y
5Kb2ADMWhBcmp3Z9FN5f3RQsiamKnxCN79aAFKc+9EC54J9x5xT+EQ8NDkC8LHL2
At23jWrOGSsm2++Ii1R1ia6twCmh7xSxsxPRrZK8lsy0zcZDJYMVXYbQkkLsfMRb
1pYYGFxdcOAFEy7Q7ejFuYPw3K9JXMDvi8FMg6lrajSTjCnQCNGOx4QLRv2BLBrB
arOX0PM7fFl3eA4ND3shAc6iLwy+8s/YprrcUzxtrKekQg/aVA7KxuGFn0oCI302
Mi9/vIXf7Qx+NJCUBtwFhiCN4UzwX12jjqS8rf4vdHLLbrMYt85i30nDQJ8E7A2W
CB13L76IbfxpyVk+ww7KhPj361kPKMnINGJX5msZ5wJee0uOJ/Gy45y/9haBBuwH
RfOfZMPjHARC2frW/Iv3UZ1mNyoua39SwpVx8JRq3SgkvZUrqrqBRikgdJpoP9Qy
4JID80F/J73rhFMKQX/Czc6eQeLWdguKlr273JAxQO4qN4Zr12PrHDbdJsYg52xL
PydVjdPAiXLZ+oXfNqIyr6xI1iLHqehtUEFvX9OVuuBGQrN1D5ONOBN2uhPl5j9C
dsayXwh7ldUEHyGqoebsRdTB5Hon9H08BRGaFXICg+zfAlfrSGg=
=3lRt
-----END PGP SIGNATURE-----

--T2h1pKBLsXtHPvIw--