Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 4 Dec 2025 09:56:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Chao Li <li.evan.chao@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Cleanup shadows variable warnings, round 1
Message-ID: <aTDcJ_BokHcQXRcW@paquier.xyz>
References: 
 <CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com>
 <70eaa01a-2699-43c3-b175-ada78aed5448@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NT0XW5LBkIty3vw7"
Content-Disposition: inline
In-Reply-To: <70eaa01a-2699-43c3-b175-ada78aed5448@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/aTDcJ_BokHcQXRcW%40paquier.xyz>
Precedence: bulk


--NT0XW5LBkIty3vw7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 28, 2025 at 11:11:04AM +0200, Heikki Linnakangas wrote:
> I don't know if we've agreed on a goal of getting rid of all shadowing, it's
> a lot of code churn. I agree shadowing is often confusing and error-prone,
> so maybe it's worth it.

(Providing my own context with more information on the matter, Peter
E. mentioning this commit upthread.)

As far as I know, the latest consensus with shadow variables was that
-Wshadow=compatible-local was OK for now, 0fe954c28584 mentioning that
we could consider a tighter -Wshadow=local later on.  I don't recall a
clear objection about doing a tighter move, just that it was a lot of
work for unclear gains especially when it comes to the extra
backpatching noise.
--
Michael

--NT0XW5LBkIty3vw7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkw3CcACgkQnvQgOdby
QH2ghg//TxGqYF16ON/LEJXH52cQhKmrS3IDMduIgMsCZJaE5586gUSkerzo4cvp
eNOngXWeUed2ZInEuu4wEWSV0kBn5mNaL4r4aST5lg8PxarkWQTSePp5ZhNynLA/
4NVW1X9tBuu4+1dFl4pRB03eiSBYvjfoxdjwOHxKXQZmCdei//rapagKqbDgieo9
5GiFdwNS3eh+d1zR0pD5pgVGp1P6HiNZsI9na6oFErT1fR1CgH27PqpulmIvmFiy
qv+1Y2kgOtUMzqUloPy4rf6aQniGQhc28zFFYDEml3fCrpSpli7NOnB8Zn5CbgGM
K4QmjJUPfllrRrgIeHM19P0jTKt0ReWBVQmav5P72LcjkWOgQTDhM6gbmNMOSw5Y
gtddXpOIjZ2J4bWorynibzanjomfjXmXxMXrKgdIzRVv70C3IWLxOPf29WhomBQ4
S3TZ+TbiyAgmC61lBY9q2bWCcbH2X8hRmiM9FM60lLYhKaQ5WwM9UEjrDotTbGu+
qZmIWmz3usYT/wud1F234mA9Eqt3L3LFszrx0kmqgJ21IdpEy0UzFCy+5P+sCb1Q
+ww+inR4q7Dmu5UK8bVazbApAWQ14PjB95lGXG7k9SK3XKak8udnuZbJnH+ykEMV
LWwB8lUjzvfKSKf+qESWUsIEQW6wJq4vi0wJIxfr5uYdTk8UMdU=
=SBQG
-----END PGP SIGNATURE-----

--NT0XW5LBkIty3vw7--