Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 5 Dec 2025 08:14:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [Proposal] Adding callback support for custom statistics kinds
Message-ID: <aTIV8qfcIkht1Hgv@paquier.xyz>
References: 
 <CAA5RZ0tH6ih3anQ=Lcwttm+8BURJ8VkBoy_9V8Ty73ZA1r384Q@mail.gmail.com>
 <aSOidfDnBT4lbtHp@paquier.xyz>
 <CAA5RZ0tvDvHYYLnu-T0DRK0xv1qv2_EK1yHjth5uAqDWz_GvfA@mail.gmail.com>
 <CAA5RZ0thcqk_r_SCB3TdXP9hVV5mG_29yc9GaGr4ujPQmcLDEQ@mail.gmail.com>
 <aSUOaqT53UBIYTKh@paquier.xyz>
 <CAA5RZ0ufds2r3H7QUro_yJDrnUmsQ4ocufqgcsRGoZvxQKeMrA@mail.gmail.com>
 <4FEEC2B8-D9CF-4BD0-AA7E-44CE3E27ADD8@gmail.com>
 <aS_QrGCgB7AMlSdU@paquier.xyz>
 <5EC13E39-B41E-464A-B382-0ACEB18A15BB@gmail.com>
 <CAA5RZ0sJgO6GAwgFxmzg9MVP=rM7Us8KKcWpuqxe-f5qxmpE0g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="n8d/eIvv8Bq15NV2"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0sJgO6GAwgFxmzg9MVP=rM7Us8KKcWpuqxe-f5qxmpE0g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aTIV8qfcIkht1Hgv%40paquier.xyz>
Precedence: bulk


--n8d/eIvv8Bq15NV2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 04, 2025 at 05:00:10PM -0600, Sami Imseih wrote:
> Thanks for the input! Yes, this is a trade-off between putting
> responsibility on the
> extension vs core. The initial thought I had was exactly like yours, but it will
> be easier to get something pushed if we make the core changes as minimal as
> possible. If there are enough complaints in the future, this can be revisited.
> Particularly if there is a common patterns for file cleanup, this
> could be turned
> into a core utility.

Another way to shape it would be to have an in-core routine that
provides a default logic for the actions to take depending on the
write, read or discard state, with the state and a FILE* as arguments.
The main pgstats file would call that, modules may decide to use it.

> However, as discussed off-list, I do think moving the custom kind tests from
> injection points to the new test module is a prerequisite. I rather
> not have us push a new test module that is doing duplicate work as the injection
> stats tests.
> I worked on this refactoring today and plan to have a patch ready for review
> by tomorrow.

Cool, thanks!
--
Michael

--n8d/eIvv8Bq15NV2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkyFfIACgkQnvQgOdby
QH1jsw/+If2AyYBtVvXj0esBKIDiZpTpPoEWJSKYL4HyoCipPW+ziN+h5O3P1PpW
jeS84JTC+T8yhcARN46QGQWQpcsiwFjzQTeeSxUkYjq6jrYpBaH7EcNa/KZV4sHT
sdSt33m8+pN6MNsAYsM/feheMBZwbxmiWMYt36qfgWyaHwM7onQrzIDaxRmJKNml
07e/it1WE4if3/9IXiWBdBX1TvKFnq6vUTtiKAqFgyM7Geb2yML4UPbIYsW8tWpb
mRWmGg/hsXzDysAO4YbaecT4QL3tU3BUPO+AZ67VYvH4lQfxAHJtEIEhPrC9pclI
FTlg/bjtKgjRnlD7/godoxxvyDE5kLGpoaaaA+oweq4uMk4IT3mcd3GgUgfTiFUb
LxZx2Fg0X9dw2UAtQh/MS5UBgAhZBlqNIav/Cig2TUNi9h20QXck0+tztnulb+2T
xfmcK7nawiCcvmJCpUDrf2o2qQrGVpWZGAQZMnJBCkvnWQpgSs8FL6p63mFSDTGC
qwFRoDCf2VgOyWTmiykpFCe5NB5upzbtnmaxht6SJG0VFWFtNbHVaqtPK+a1v549
7xYQ1kDueMC4AwP5EUH22fwDgJodSqsKKy8KvOvKadSbqVAHhDtaRGcU+q9KR8ZK
s5XDGB7EtaQHCatSmpAyD0xxvGCjZxxUx8XT+UKmyDHCQ4Cb7Mg=
=97OO
-----END PGP SIGNATURE-----

--n8d/eIvv8Bq15NV2--