Date: Fri, 5 Dec 2025 14:47:38 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
	Chao Li <li.evan.chao@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: vacuumdb: add --dry-run
Message-ID: <aTNE6gCmTwtMzomK@nathan>
References: <aR5IMz4cngn8hkXI@nathan>
 <CADkLM=dwBjL5fK-Dq_2qhAuHsHPab_Kt+R7KZTA9w_X0K6bENg@mail.gmail.com>
 <CADkLM=d+XROe3JgM5gZno0JGEgxnDDCYsEHgQjg5x7d0OQp5vA@mail.gmail.com>
 <aR-MQgYi_FtSsy66@nathan>
 <CADkLM=ejhuvk9TOmYe09kaWdUoCzPci1aYa9+ADOwzP22e1XeA@mail.gmail.com>
 <aR-TLculrOb2hbRy@nathan>
 <aTICg5LV0Nl6khYj@nathan>
 <CALdSSPjEO-DoHoPyrV9RV8HOU9LXPyak-jJ=mxGXGU4ZA9QB8A@mail.gmail.com>
 <aTM7pgNQesAp79Pn@nathan>
 <CADkLM=f99AzFrdnPdo3PkO27rYtJv5WoGQXrq9Bf8_Y4vVxuBw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=f99AzFrdnPdo3PkO27rYtJv5WoGQXrq9Bf8_Y4vVxuBw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aTNE6gCmTwtMzomK%40nathan>
Precedence: bulk

On Fri, Dec 05, 2025 at 03:34:12PM -0500, Corey Huinker wrote:
>> I guess we could probably remove the top-level "Executing in dry-run mode"
>> message, provided we say the same thing in the per-database message.
>> However, the latter can be turned off with --quiet.  Maybe we should
>> consider disallowing --quiet and --dry-run.
> 
> --quiet does appear to be the sworn enemy of "tell me what you would have
> done if you were really gonna do it". So yeah, disallowing that combination
> would make sense.

On the other hand, --quiet is handy if you're trying to save the output of
--dry-run elsewhere to run later.  (Of course, if you use --all, that
output won't be tremendously useful.)

-- 
nathan