Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSQ0z-00ECri-1H for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Dec 2025 01:26:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vSQ0y-00EKim-05 for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Dec 2025 01:26:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSQ0x-00EKie-1H for pgsql-hackers@lists.postgresql.org; Mon, 08 Dec 2025 01:26:12 +0000 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSQ0s-003lE1-3A for pgsql-hackers@lists.postgresql.org; Mon, 08 Dec 2025 01:26:11 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id AD67BEC0180; Sun, 7 Dec 2025 20:26:04 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Sun, 07 Dec 2025 20:26:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1765157164; x=1765243564; bh=KtP+wpSiLV 3lmvcWNoRmolmup3hyUg/GfLBy7zDtHd4=; b=pxmoXPfWh8yd5uDeH06oG/gd3m KW6FBVJOj2BE8Ut4iTuB9FONcwJeRZ0DYH+/KrIf8M887xpAUnHaEMuYh2tAR+9X KnXHGL1776kTMny5g4bxwUggbH2bok9VRlvQI2G5tzYC44d/pdu7o4DId/SY71Nj 93pXsPjz8hRSUVQZjL6szSeEarOBkMqZHARnjstniEv+qsoGqjemlitDZfCo85Pk QycNxkJPpHu12N06dTJjcsaQCxClBVDZ7w0sWtjAywbxDD6dUjUsne1LzujRpJac mCgfz7drDLljiCXcWkDVfnHgwHeN6Hp6NYEElKOkGKzlgjUvwxrv5dQLFctA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1765157164; x=1765243564; bh=KtP+wpSiLV3lmvcWNoRmolmup3hyUg/GfLB y7zDtHd4=; b=RGiwvvKZV0rvvOiAlfmjvOAo+TXJQ/lktiCyoBi/J5vQGqb++Xc hv2YyFG2w7lkn6KemH6LBcO6OB6Sr0hRCkMRupSFzUWTBzigcQTUfJ6x0/iUeSxT MYKzyb9FpNarYz3+eawK1QfK4pDbhNPRdm7SKpLr1fhtzS7BGogx8NcNVpDt6GEa zC0968KjIoqnqOptFuRgh/2QKMq85oQoQkLvI5iwpIyTl+GmsuN5UBFzEHrJYwM3 VjJDO1lZcm6JKceeLfUwMMRroIVqmrCpBgyYzrhWwzi58hsIDLxbg9txJZpgiaDX Srzh+2KhhH6NyR7LZAwk2YM9tCL6rLyvZJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduheefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtroertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeffudelheeghfekfefgfedthfekuddt vdfhudekgeegheeikefflefhleekheetfeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegtohhrvg ihrdhhuhhinhhkvghrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepthhglhesshhsshdr phhghhdrphgrrdhushdprhgtphhtthhopehjihgrnhdruhhnihhvvghrshgrlhhithihse hgmhgrihhlrdgtohhmpdhrtghpthhtohepthhomhgrshesvhhonhgurhgrrdhmvgdprhgt phhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlh drohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 7 Dec 2025 20:26:02 -0500 (EST) Date: Mon, 8 Dec 2025 10:25:45 +0900 From: Michael Paquier To: Corey Huinker Cc: Tom Lane , jian he , Tomas Vondra , pgsql-hackers@lists.postgresql.org Subject: Re: Extended Statistics set/restore/clear functions. Message-ID: References: <1341064.1764895052@sss.pgh.pa.us> <1353179.1764901790@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1yqzOvEBEG6TJCx4" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --1yqzOvEBEG6TJCx4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 05, 2025 at 12:30:38AM -0500, Corey Huinker wrote: > Attached is a follow-on to Michael's most recent uncommitted patch, > changing the errors that I see as "impossible" to elogs. However, I agree > that they don't add significant workload to the translations, and most > input functions need to avoid any hard error returns lest they be called in > a soft-error context. Reporting the state of the parser in these new elogs is OK for me, but we had more cases that what your patch has been updating. I have included all these cases, making the set of error messages a bit more consistent across the board, and applied the result. -- Michael --1yqzOvEBEG6TJCx4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk2KRkACgkQnvQgOdby QH1/wxAApVyc7xq0LIkdAKjZ4x9jEi0N/1dABSjiglkn1CDHaaau1/ysMo3CXh3D C7rU0H74b2EkKX+VpYjdwbeMg+N8YQ5HAcgd5RzmPp0Zfz6nN6hip2GxkdTY3fhG SoCvYH6pBBPn3WrsEN3fe7mOhTQ+MCSsNzxj1eumI6q0zDcocsbNMBV6IuCnjQ7E O3Im9Spame8+JOateEPFAslyQsXtt02tXW19Pn0rOroskzBX8Kfgf4vZ2tgsaAcN B99X9nzisgGewdiga1alpWMBFbsGGtXKsvfuWRcMDVLZG87jsT5nbTEMiYeUKYRn cDbAFx79I7rrOYc5yjpGuQkLpGEXEKsPWqC61hHTrJkooczb4MoAtp0A8tY2rWjd zf9jxlALHzwrSubiA8KT/iCfYdUrY+9Bfs9mwPBcsxnCJBNX+zLReTU39NvWTBku 4+wa3biLBvDOsGTN4txx89YZLOsxoznf4Mpnrp4jU3b1Bbved4IZ1yhkpJpj8rQJ WV3Rj1PkI0mecvn7BDUKVatx9B3SS8ExsCEeIbS6t30gZgOQ1ehCB2GrnU8n2Pes 46p+iPv9dS7nxIor8+RHmmqsLAJOYu2ctq/MmsYyy6tdGNaoN0C2H2gj6mHYBvOB Ds6Rf+ahee97K8o5OwbEX0798j3tdHSngT5JIbfTy9ZW/KwffEc= =MJnd -----END PGP SIGNATURE----- --1yqzOvEBEG6TJCx4--