Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 8 Dec 2025 15:35:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [Proposal] Adding callback support for custom statistics kinds
Message-ID: <aTZxqzPWr0wMVLq2@paquier.xyz>
References: 
 <CAA5RZ0tvDvHYYLnu-T0DRK0xv1qv2_EK1yHjth5uAqDWz_GvfA@mail.gmail.com>
 <CAA5RZ0thcqk_r_SCB3TdXP9hVV5mG_29yc9GaGr4ujPQmcLDEQ@mail.gmail.com>
 <aSUOaqT53UBIYTKh@paquier.xyz>
 <CAA5RZ0ufds2r3H7QUro_yJDrnUmsQ4ocufqgcsRGoZvxQKeMrA@mail.gmail.com>
 <4FEEC2B8-D9CF-4BD0-AA7E-44CE3E27ADD8@gmail.com>
 <aS_QrGCgB7AMlSdU@paquier.xyz>
 <5EC13E39-B41E-464A-B382-0ACEB18A15BB@gmail.com>
 <CAA5RZ0sJgO6GAwgFxmzg9MVP=rM7Us8KKcWpuqxe-f5qxmpE0g@mail.gmail.com>
 <aTIV8qfcIkht1Hgv@paquier.xyz>
 <CAA5RZ0sG2RUKg=OLY+6-e4q=X9rsLfK3pKn03d=RZQppEDR=Bg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="c6Wqs503Iol2NuCz"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0sG2RUKg=OLY+6-e4q=X9rsLfK3pKn03d=RZQppEDR=Bg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aTZxqzPWr0wMVLq2%40paquier.xyz>
Precedence: bulk


--c6Wqs503Iol2NuCz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 05, 2025 at 07:27:50PM -0600, Sami Imseih wrote:
> Attached is the new test module that replaces the custom statistics
> tests currently in the injection points tests. Under test_custom_stats, t=
here
> are two separate modules: one for variable-amount stats and one for
> fixed-amount stats. With this, we can completely remove the
> stats-related tests and supporting code under
> src/test/modules/injection_points/.

Yes, thanks.  Structurally, this is better and more flexible than what
we had originally, and I have noticed that you have copied the
original files while adding more comments and renaming a bit things:
the structure of the functions was exactly the same.  Anyway, I have
worked on that for a good portion of the day, splitting the module
drop and the new module into two commits, and applied the result after
tweaking quite a few things in terms of names and comments (no
pgstat_*, a bit more "Var" and "Fixed", etc.), applying a much more
consistent set of names across the board for the functions and the
structures.  This cleanup part is moved out of the way now, so that
you ease the introduction of the next pieces you are proposing.=20

The tests for the reset of fixed-sized stats was a nice addition,
indeed.  If you have more areas that you think could be improved,
ideas are of course welcome.
--
Michael

--c6Wqs503Iol2NuCz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk2casACgkQnvQgOdby
QH2lJhAAqhG+QbDS1JSrHXAsNdhFsb5uS6avb0UameFZFRrniVSVNJhtMFf/7Fh3
ngDgo4VlAQtJbhTYvwBdtbCKhWBDlQ5bm0YRph9Z/y7OgMzO9H8D9i6mb7DHYp9y
s9rCk92AUluXzdilzpnH4W+Vu8IRfxeQ1fSuGHol0Osz/GqU0eYN9f0/wnicRzCv
QN7B93YuL1ivOk9PhWj+2QXnx/x0k7ti7575dHgvdN5S2KUAA/HCFi+W6XI/oEEQ
eI2bhkmtdtZfh5njBAtza5FimqYQF+A9nMGeVJKiBKyecHniEJ+UFPR0qFraiVZO
eAcM0t7Px4YErvAYioDuSJJFcfOpg/7ZYqBosM5OgaqXyYsmss0TrSZD62/BFa0K
BBr8aSVujF1Jjj23cMx5Zts6qo7RQD0CG+2yHyolH1Vx+55/UwkeoZaqPoTffo3D
0k3r7S296L7V91FI7rau0e9REM1RxRZ8r1ySgH1q3Uvs2OgrdWWdFHLqGbWt+HdN
zbpLM5oAzGE3EsBPrYleXlQI2XoZe8Zjyy+jdf3HWHYDCS/0R49CINDstP7bVOD4
YgRwA6TZNAmzX6STLg+0HCSj7fbKwOVFP31lBj0DUfWN2y7CeWbddw2YuXjZ/6PZ
o40Rzx5HCw+wFZ04cuiKDq0ZUK07hXcJ59xVoBB2iBSjQbbXEEA=
=lnnz
-----END PGP SIGNATURE-----

--c6Wqs503Iol2NuCz--