Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSyV8-00ASJt-00 for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Dec 2025 14:15:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vSyV6-004wMf-1v for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Dec 2025 14:15:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSyV6-004wMV-10 for pgsql-hackers@lists.postgresql.org; Tue, 09 Dec 2025 14:15:36 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vSyV4-003wMd-38 for pgsql-hackers@lists.postgresql.org; Tue, 09 Dec 2025 14:15:35 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-477b5e0323bso34743335e9.0 for ; Tue, 09 Dec 2025 06:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765289732; x=1765894532; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=evZFvF9xbeOo9KXoG81AToBmqtTRVxH4Fizgxg85Drg=; b=EtyMRIoHW8Esuk6FzQO2Xf5QPY3HRgspeGYD9rEfSwEAalwV9rBGcuxpitlF9YDmcX XE2iK1qVIfy5iUdMa1ZBscF5+IaIgMs+ZUdLSuCgZuI7/Py2y3cYOhKP4HrHyfsnVjIo OcH95bEBIURfBSKQ3ga/mac28G1qtI1N8XucWjy/+hS8gzB0J0HLNoPMGtF9L4kUFaYd MYue5KK51N0DBAmD8Z0wCLmTCaR9mcWO4Ms8XOX7Gtuk+532d6DPnpZNjT6xkxHwLOuE 5aEtuN0u342Y1zKhOZ/B83VusHBpRqBcsqx24x/0AMxIt/Tkdxo9eAbyGXLsprjnYzrp csjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765289732; x=1765894532; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=evZFvF9xbeOo9KXoG81AToBmqtTRVxH4Fizgxg85Drg=; b=H8QQ4HBLJD+l3YjXB/8IXMd3ipHHRw2gkjIcEFNa5QyqLSTM2KA84Jo0M+NqOoBxYU 3B6uSnXsAIVFbWv7a65BX0Uk5z9B/wDb8qjuTDDPFTfTreUUBXMDOQ+KMfsCWKydnRWF GaZa2rvw9nyJyz5fFWAwiKG0MC3xNmImdWlL3aw2PMAdxyLiRIhInoxRJ5JUI1CGj7rT 2efYMnamAt86xR9VmOlSERJl7QYrF6gSJwWLnHo5qb5zEr4wyOmQGdnCwruDUFrtr7Nv hY2tgILnIgHiViZEWcFhRewW/btzBjcXIwew3w8XpQo2f/++mgu73+sozujmT3uZH/Vf nqIw== X-Forwarded-Encrypted: i=1; AJvYcCWbaLfS8NWGBY/TGgUXYnoIqjkruoX6l4BeikHgtBCV8K8V6G+9FOQrk1rxIDDfLSADw1LbnxeQIJLh3K4i@lists.postgresql.org X-Gm-Message-State: AOJu0YzXGKi6kEyTZg82EjTBshrbLIKvdTDEtMlwhmDCupix4UaYD731 U3EF8XI8xnJ4MxXKWhTRLu8q3bbXjjw5n+v5TfjydW5M8ayhXopVhQSG X-Gm-Gg: ASbGncuWYNs1kUzssX7TqdqHkiY2AKGQ5DIfO0/NqG9dvG6NkusiQaUE+7mcuiqJiCc rdLcns5aRmVyQwJqCfi+Pul6o1L5Oqpo1yLKeOhPxDbfNwJmscbcU9FEr3s2gwi87jKDWotHzhH saElreQ7jEOBAcDmgQTQ5atDHmRvQXYqVvFbWBE/g+3B3xg9tGlEoOWBDa1fUMhISPt0C3DTQkF f36y9W2ZUQKPUszSvKN1OniQ98RwT4Yg24lpJ4nMPQV7UYSLx91SBQKyPeeld4K8LM+hS8HBGMf i4cubhG8GdFxaSW3ayRonOHMrp+JEecDGwQQAkz9a7VA1XduOnyq70wD9cU6aTQiA7HaDgvAFkW C6qePgkmrma7V2ZsdvGRVGzYkH01M4+e/q1EKe8yl17d6Yopuz8Yh6wGRUOpnplcVhZ4EMS884G rlm0tPido5ZnzjrNOslCs0jQFxQctK/QkTyZojdEz0OIogzAQs78V6jLPEJTa+KfMv28d/lnc6+ qLus/oE+qYfH4ZWOHLxr+g1qTAHDWllmFgzJzLro6of6Q== X-Google-Smtp-Source: AGHT+IHlCScQFGUUjpfmAH5qmEbwrC5N8rBAb5Sd6wg22d+QpUcOKw3wZX4OkQLZbysGyRoSUg0O0g== X-Received: by 2002:a05:600c:3106:b0:475:d9de:952e with SMTP id 5b1f17b1804b1-47a7fa13b51mr18572295e9.1.1765289732120; Tue, 09 Dec 2025 06:15:32 -0800 (PST) Received: from ip-10-97-1-34.eu-west-3.compute.internal (ec2-15-237-197-144.eu-west-3.compute.amazonaws.com. [15.237.197.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7da1de9fsm16847135e9.14.2025.12.09.06.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 06:15:31 -0800 (PST) Date: Tue, 9 Dec 2025 14:15:30 +0000 From: Bertrand Drouvot To: Jelte Fennema-Nio Cc: Thomas Munro , pgsql-hackers@lists.postgresql.org Subject: Re: Safer hash table initialization macro Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Tue, Dec 09, 2025 at 11:45:11AM +0100, Jelte Fennema-Nio wrote: > On Tue, 9 Dec 2025 at 08:27, Bertrand Drouvot > wrote: > > Thanks for this patch series! > > To clarify: Does that mean +1 from you on the proposed API? Yeah, I think the hash table API needs improvement. I did not look at all the details of your patches, but from what I have seen I think your API proposal make sense. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com