Date: Thu, 11 Dec 2025 15:43:31 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Aleksander Alekseev <aleksander@tigerdata.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
	Bruce Momjian <bruce@momjian.us>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Message-ID: <aTs7A4lbcm0ThXaO@nathan>
References: 
 <CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D+zFWBwae-80do6o-rA@mail.gmail.com>
 <aFVomQjfkDvtQRwo@momjian.us>
 <CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
 <CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
 <CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
 <aPqPK4ERy5-jj185@nathan>
 <CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com>
 <aP-H6kSsGOxaB21k@nathan>
 <aQABs_2dbXmGXDvv@paquier.xyz>
 <7415F7DF-FA45-49E1-AC70-04868714DC8A@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="6vjI3TbFXYVKYNF4"
Content-Disposition: inline
In-Reply-To: <7415F7DF-FA45-49E1-AC70-04868714DC8A@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aTs7A4lbcm0ThXaO%40nathan>
Precedence: bulk


--6vjI3TbFXYVKYNF4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 28, 2025 at 08:36:33AM +0800, Chao Li wrote:
> On Oct 28, 2025, at 07:35, Michael Paquier <michael@paquier.xyz> wrote:
>> On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote:
>>> /*
>>>  * DISABLE_LEADER_PARTICIPATION disables the leader's participation in
>>>  * parallel index builds.  This may be useful as a debugging aid.
>>> -#undef DISABLE_LEADER_PARTICIPATION
>>> + *#undef DISABLE_LEADER_PARTICIPATION
>>>  */
>>> 
>>> IMHO we should either remove this line or move it out of the comment.
>>> AFAICT we ordinarily don't #undef debugging stuff like this, presumably so
>>> you can change it with compile flags.
>> 
>> I would put this one on a separate line, outside the comment.  It's
>> minor, still we use this style in pg_config_manual.h.  See around
>> REALLOCATE_BITMAPSETS.
> 
> +1

Here's a patch for this.  I also changed the #undefs to #defines.

-- 
nathan

--6vjI3TbFXYVKYNF4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v1-0001-fix-some-commented-undefs.patch