Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 12 Dec 2025 11:58:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [Proposal] Adding callback support for custom statistics kinds
Message-ID: <aTuE7kyeDCggXqVf@paquier.xyz>
References: <A5D8954F-2E20-4BF5-BA0E-79FDC06A632F@gmail.com>
 <CAA5RZ0sg6gskHRgfymo9njEWuXDyn0Zwe+0bcX=nByyE7W+6bw@mail.gmail.com>
 <aTepXZ97PsXpuywI@paquier.xyz>
 <BF27BA43-D94D-4DC6-BD91-95EEAD42AD0F@gmail.com>
 <9252DA7C-C611-4A93-A484-E6CD42557C15@gmail.com>
 <CAA5RZ0vQvmatp8VAk6zroyeKDCw+QVq4XmoRNAFogQo6bJEbNQ@mail.gmail.com>
 <4E61FDC4-CFBB-4116-980F-75ADD245A1F6@gmail.com>
 <CAA5RZ0swDCK+7M2KQip0tqUsBK3LUHd3F0ytpsKdDCfygHksKg@mail.gmail.com>
 <aTkpgP9Xe5QJ5sDu@paquier.xyz>
 <CAA5RZ0uC4j2QGK85ma6bkF6YOWBrYX9J3dV2CEMg3d0CBLpHSA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="1iLSqXB2NZkR3Wrm"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0uC4j2QGK85ma6bkF6YOWBrYX9J3dV2CEMg3d0CBLpHSA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aTuE7kyeDCggXqVf%40paquier.xyz>
Precedence: bulk


--1iLSqXB2NZkR3Wrm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 10, 2025 at 12:36:36PM -0600, Sami Imseih wrote:
> .. and after giving this more thought, I actually don't think we should
> do any validation for any of the callbacks. If an extension is writing
> to any file ( core or custom ), naturally they will want to read it back.
> Now I am not sure what these validations are protecting us against.
> Also, maybe the extension wants to just read data from the main stats
> file, I could see that use-case, perhaps.
>=20
> So, I am proposing removing the validation altogether. What do
> you think?

The to and from callbacks are coupled with each other, so there may be
a point in making sure that if one is defined so is the other.  Now, I
have never done any enforcement for the existing from/to serialization
callbacks either because it would be quickly clear for one what needs
to be done when implementing a custom kind.  So I'd agree with just
removing these checks and keep the code simpler.

FWIW, I have begun putting my hands on your patch, editing it at some
degree.  I am not sure that I will be able to finish that today, but
I'm working towards getting something done.
--
Michael

--1iLSqXB2NZkR3Wrm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk7hO4ACgkQnvQgOdby
QH1lZg//URP0boHtH0e+4l4y66pCBBPYv7H5AyTOyZ/r1Qp1IeByM78sR7R6Q6GH
X7O79cxNSlTzvZxXUCuAESusG16ssbsuleD2n9eY3KbuDEDrLYvIOIyr2jOGtLhA
y1r3wJskXFK2fd6yyfKc0Ajw2Zn9R6Rjbv2Gu2W7/0QpSAk+Yp1vL3oQET3p4lcW
HhH8Ihdc0RaaK0HRH4pR+JzIOT+hg3L0Q6C6iRr7UvByXr9xvW6z+XG5eJ1PPTxZ
9hXxCcSV+JcKb3jqbShdHLq6tvyCvcbFcBWTRKuJ/TWX7rCE3sJgyogd5t72HbkR
L+OK82OGqxpTefLNXWI+zW4Gz3zlZODl1x9fEI6BZg2o7uPjJSOjpbjTqOIpT82/
aS9Y3C3HupJZiQaM69YnVwMHXqJSOlm+CbUkaMSDoFdH2UxXMcLOtd2gqrdVC86m
BkoGWvHzAKT9qFMdyoDNGOSYU8j9gjNMyWyLxSUxfZI60On5GLYosVUpFs0yk2/n
L/KAlJYpUoI81Zs6V1I5e1YpaBD53xqp2XQ8Id21qYUxZxMgjsrEMVS338g8LR2a
AUDKIUElA45c3BghHZICWrkQjMhDHHbmc7Evv/0FJOmrS5ZTR9YjszE5/7wT6yCF
1wzyEO63wcIHq6mnLkKmErdLZCym8ji3Vr99kmQ4/cmVsT5fUmM=
=CrWe
-----END PGP SIGNATURE-----

--1iLSqXB2NZkR3Wrm--