Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 13 Dec 2025 11:00:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [Proposal] Adding callback support for custom statistics kinds
Message-ID: <aTzIvl7_aXnBzH-t@paquier.xyz>
References: <BF27BA43-D94D-4DC6-BD91-95EEAD42AD0F@gmail.com>
 <9252DA7C-C611-4A93-A484-E6CD42557C15@gmail.com>
 <CAA5RZ0vQvmatp8VAk6zroyeKDCw+QVq4XmoRNAFogQo6bJEbNQ@mail.gmail.com>
 <4E61FDC4-CFBB-4116-980F-75ADD245A1F6@gmail.com>
 <CAA5RZ0swDCK+7M2KQip0tqUsBK3LUHd3F0ytpsKdDCfygHksKg@mail.gmail.com>
 <aTkpgP9Xe5QJ5sDu@paquier.xyz>
 <CAA5RZ0uC4j2QGK85ma6bkF6YOWBrYX9J3dV2CEMg3d0CBLpHSA@mail.gmail.com>
 <aTuE7kyeDCggXqVf@paquier.xyz>
 <aTvi5ceF-pB1IbDR@paquier.xyz>
 <CAA5RZ0ubfcmkkY7i07CmrkY12H8BsRXDoOutYXjYz0gsq7hm-w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MlseMsaqu6ZDvNrA"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0ubfcmkkY7i07CmrkY12H8BsRXDoOutYXjYz0gsq7hm-w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aTzIvl7_aXnBzH-t%40paquier.xyz>
Precedence: bulk


--MlseMsaqu6ZDvNrA
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 12, 2025 at 06:41:20PM -0600, Sami Imseih wrote:
> I made some changes as well, in v8:
>=20
> 1/ looks like b4cbc106a6ce snuck into v7. I fixed that.

Oops, sorry about that.  I went one reset too deep..  I can see that
my local branch was also wrong, an a rebase fixed it immediately.

> 2/ After looking this over, I realized that =E2=80=9Cextra=E2=80=9D and =
=E2=80=9Cauxiliary=E2=80=9D
> were being used interchangeably. To avoid confusion, I replaced all
> instances of =E2=80=9Cextra=E2=80=9D with =E2=80=9Cauxiliary" in both the=
 comments and
> macros, i.e. TEST_CUSTOM_AUX_DATA_DESC

I can see what you have changed in v8 compared to v7, in terms of the
elog(), the comments and TEST_CUSTOM_AUX_DATA_DESC.  That works for
me.  If somebody has a better idea for a name, these can always be
tweaked at will.
--
Michael

--MlseMsaqu6ZDvNrA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk8yL4ACgkQnvQgOdby
QH1+eg//b52xkW0tCqnV+ykdOIy0orL/wbyBBFnvGMCGUagEEDlKJeg9tVezYBd9
ZsoQwMhNvliD+t63BXppDjB5cZvTIjoG8NuupHgSafYYIXra2yk1WJtqh1Ghj7lr
kGAhKEfv13sGMd77mCRY58Kshe1VnXNROwoDsK83C5cirsYJHET51dcB6FGZcUyh
M39KERHnxNymK8jWHnazW1IboTXR9XYTHHmoSt0Oifzjm/KuuiWSeo8PCL/aAId0
Pn778RffB+Xo49ZqAxKK5EPi6kuWf72hXOm2ow/3xFh8dQD/fHEpdHKxCjbZ1mRP
6NoIvtEYWrSqvYQXFWOFdSZI10T1llu8xIg0nOH4aik3JihElj5PvFgvZ+iH8XqM
hbSlpU8lNrSB7waOs+XuiSDghk8xrpnJRKF2P6Z55Wh7Lv+yCCE55m/jhmCNOvoL
XTVKMHlb54vsFQCNY/bk2gAOEpyHUEWu+lNTwq4EhQ7eOj6GbZK1olAmGnDEZxcZ
Z99TtmDdW6I2+LcZ9rudxd2BHtqggudqQ3Q26Al5HIAMMG0HkHlB7Vej0jceKmk+
USD3MJQKzqwjzO0lSPNSsfRMNe7HMjfw/ru75LpfF6cJB+sGHcnBXOBTFSp5xtEz
OrEbCTm/K5nJUZ9iFMrqMPZsMgkf4QZ+9uxQ4WeHhDAZSF+NQLM=
=i1jN
-----END PGP SIGNATURE-----

--MlseMsaqu6ZDvNrA--