Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vW0Dz-00AT8j-2v for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Dec 2025 22:42:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vW0Dy-00GvbJ-2j for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Dec 2025 22:42:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vW0Dx-00Gvb5-2o for pgsql-hackers@lists.postgresql.org; Wed, 17 Dec 2025 22:42:27 +0000 Received: from fout-b2-smtp.messagingengine.com ([202.12.124.145]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vW0Dv-001JC7-1Y for pgsql-hackers@lists.postgresql.org; Wed, 17 Dec 2025 22:42:26 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 475481D00077; Wed, 17 Dec 2025 17:42:21 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 17 Dec 2025 17:42:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1766011341; x=1766097741; bh=+Joksiv2kI D2d3wvfHdBmEg04RieRoqus6fDshv+f3M=; b=kKZRGQ5rB/P+8ydBkeoGVaNPVG 7dDv0i3giD5sPzx42BWazpsb/5uWpvtkg7KuvLPsqzkw/HF6AvBMFp9TrcM+q5ES b1coxjuDNgnhbLqUML7OfLW0rsOgMp/czEQnLRcZAdzZQ9h/FEqSYzfaTc3OWY3o 8iIKLmT9/EUprrxeoCXGBsxF4X4atiJzjkWIN2PYU3wpEtv5QtHudmLcEifafMZT 3kBwWk1tmKe1vczgke8wELNL4AqCPuq7utY3+UN3u0KU7KFY/ijxhoIjauclj04i fkNDqjuElaKWwqA0o/bJU0chkmsvB5REzCDKO+GYAU+oGvnyuvKzJ1fgNq3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1766011341; x=1766097741; bh=+Joksiv2kID2d3wvfHdBmEg04RieRoqus6f Dshv+f3M=; b=u8mJEPDq7JNjWtVN2pIEmhynnAv7xwpFHp1xeWlYF1paPaHZhVg f439YOsvS3oytfw7H09CQ5kSFKbUldeQjytnNHqx03JW1ghqswRldPZxq8g/W4PB Bldc3X1cCDBuDJCgMNnaSDn3h9wWQOCU/W/wRGDGYoKMPS1/HPLwbg7wr7dBne8F P8d71pVRa1PkvhZUD1bVBIfdjpRxtIqqqgev/PNLM6KF9I/RnyD8bsrgP8Y/HTA4 NH261+Ir+8fUEvimH9pAMDiPCX8zKNzBHkgF+Fvz1QK8qsLYvgbWftLGdbqO5IFl z5c/3KnsdthjzOJs1esgHTYAcRfvqxP+TsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdegfeejlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsrghmih hmshgvihhhsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphgvthgvrhesvghishgvnhht rhgruhhtrdhorhhgpdhrtghpthhtoheplhhirdgvvhgrnhdrtghhrghosehgmhgrihhlrd gtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshht ghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Dec 2025 17:42:19 -0500 (EST) Date: Thu, 18 Dec 2025 07:42:00 +0900 From: Michael Paquier To: Sami Imseih Cc: Peter Eisentraut , Chao Li , PostgreSQL Hackers Subject: Re: [Proposal] Adding callback support for custom statistics kinds Message-ID: References: <4E61FDC4-CFBB-4116-980F-75ADD245A1F6@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CTX+IaMvn6SEja8C" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --CTX+IaMvn6SEja8C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 17, 2025 at 11:01:01AM -0600, Sami Imseih wrote: > I got the attached patch ready with some additional comments in > the callback definitions to clarify the API contract. We only need > to call out the "header' nuance since it's a const in one callback > and not the other. "key" is self documenting being a const in both > cases. The comment sounds like a good idea, so included it and applied the result. Thanks for looking! -- Michael --CTX+IaMvn6SEja8C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlDMbgACgkQnvQgOdby QH1CFBAAgwM5NGaiFitYAFcINE0AFt44Ry1ksT/qwxGXeKWheUc6eZxb/HCkNz6/ iCIqiIyk+/uFD4llZRJv39MGoTF2EyTd1mlKA+tSnXMjc0YAJLa2EruWZbdEv4Tx eKJghipXtgECk1RMQY/4i1zIJAmoJmb4mCZPrliwF/DmHrkV0vQlmQhdat4FeRHg bEsfnLota1q/dzd8ycP2GgLXIPHLzCBrxd6dwIjCi2gCQDjU+NwCdVvs9OyXhYR9 TKG7tDUrkI3MZwEg3tBxe9w9/vfTj2JQPzJ2vpiWW1yiNZ32no5DCrB7aG3t8K9+ B09xspRDlrwsIPP7Vk3cSMeZzLZZWP6KoVtyItVDbCy/BgfrsHi1Gg3Om3+70lwc O8SruCqxcMj8EFjCCoL4O9vA4LcyLaTYsiEBVF8+/DH5JMW6QkrGbxITPkdG37ja 4E1CH/bq+bB8erJTcEIEM3F7MvH6L3KdSw0aut36hhtiviEQWnfJ5DjkyiGCgDyq t6uf60XGPuEt9T2g59a62OJjopK0YGfYpBysGYUi6sRMyAgeaqmGRgaLDFBg+U/O vZXxfD29/4YyHOSZF/dr97BQ7eFx8WhWNK7UO7sEZVIm4KLU+9Mp5QDY4PfYkAQ5 26DcgYp00BGzu0WBi5CRH8yNlG5FpItwkBBA3bz0J9sNuxSXLAE= =+Qpx -----END PGP SIGNATURE----- --CTX+IaMvn6SEja8C--