Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 20 Dec 2025 08:22:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Refactor query normalization into core query jumbling
Message-ID: <aUXeTEpSymo6n7lF@paquier.xyz>
References: 
 <CAA5RZ0tZp5qU0ikZEEqJnxvdSNGh1DWv80sb-k4QAUmiMoOp_Q@mail.gmail.com>
 <aUT1eblRYpwB1nC7@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0vQfE14HyfpoPXDRThVcdCkLgY_HGz+J2qLB9soNUE9QQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="BPgSBVckB1hRQeIE"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0vQfE14HyfpoPXDRThVcdCkLgY_HGz+J2qLB9soNUE9QQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aUXeTEpSymo6n7lF%40paquier.xyz>
Precedence: bulk


--BPgSBVckB1hRQeIE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 19, 2025 at 03:36:16PM -0600, Sami Imseih wrote:
> This way, any extension that wishes to return a normalized string from
> the same JumbleState can invoke this callback and get consistent results.
> pg_stat_statements and other extensions with a need to normalize a query
> string based on the locations of a JumbleState do not need to care about =
the
> internals of normalization, they simply invoke the callback and
> receive the final
> string.

Hmm.  I did not wrap completely my head with your problem, but,
assuming that what you are proposing goes in the right direction, I am=20
wondering if we should not expose a bit more the jumble query APIs so
as the normal default callback can be reused by out-of-core rather
than hide it entirely.  This would mean exposing
GenerateNormalizedQuery(), which also giving a way for callers of
JumbleQuery() to pass down a custom callback?  This would imply
thinking harder about the initialization state we expect in the
structure, but I think that we should try to design things so as
extensions do not need to copy-paste more code from the core tree at
the end, just less of it.

Of course, this sentence is written with the same line of thoughts as
previously mentioned in the other thread we have discussed: extensions
should not be allowed to update a JumbleState after it's been set by
the backend code, so as once the same JumbleState pointer is passed
down across multiple extensions they don't get confused.  If an
extension wants to use their own policy within the JumbleState, they
had better recreate a new independent one if they are unhappy about
has been generated previously.
--
Michael

--BPgSBVckB1hRQeIE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlF3kwACgkQnvQgOdby
QH19hBAAhsIi/wN2NtjFJ8vV7+ru05319iTglkahMpSRQ+zswnz4BslcTNBb5MxP
2KqgyoEivTvgagfCi1mtWf+Sw2zXX3OueRj/91uYRvSpavVi4Fk5uDuSK4rdLgso
wdQOamS9yO1cGD2kfhfd+ER83xTr4+4mlKYUEd2w4Wtm1qZWIrICuTnn64MFMTLu
bML7K6GKnOFgw5MdaCgJbqGlUgCi+JEEqSp50loBSBYxTrOu2Bj5PZU6CHzT50pO
7g6rXiqPNPn8igeg9ntVwYzFxWNxslJDaVHqrQMD8A0b8rbfiAWANisDvPup4Cwy
7UkUPp96cqoLK9vA0fOUw+CTKQcomaL5ZVUinjSfPFJ0tbEtexoS1falYMiSLoZU
exmIb3BnJZZ5bKKWpiSZ+Qzl2pDpFDeuRkxjVa79YflHs/hP9AnjvR3yNgUA80TO
Hjsun50N6vG/VeTq2LUlCXzKVK1x47NmEIIxUjd8XL+jZFpzoawgKU5DZtEtMM7w
eQCaRBAdBmhYAJHVUV8gUtP5L66XbgULKgkdLn1FObYW7cX/DtS8bN+64WRS5J4I
x/NnZBvdZWkXsYTPP0K2ieaEgQWLSViKYPvkkH/vDkyKUUN6W+F1I9JGpUVFQWeO
ybwlXvBQAAL6C6Ct0lNpfTxE/MGKsE9hfJ55fD/ZEx2T1H9jGRU=
=Rjsn
-----END PGP SIGNATURE-----

--BPgSBVckB1hRQeIE--