Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 22 Dec 2025 07:33:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	=?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>,
	Aleksander Alekseev <aleksander@tigerdata.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nathan Bossart <nathandbossart@gmail.com>,
	Chao Li <li.evan.chao@gmail.com>,
	Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Message-ID: <aUh1q5twC8WqXATK@paquier.xyz>
References: <202512121547.dwkzxcs56227@alvherre.pgsql>
 <1000974.1765556221@sss.pgh.pa.us>
 <aUWvRKmVWJsNxKX5@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="lwF1mOZTpWasDAVf"
Content-Disposition: inline
In-Reply-To: <aUWvRKmVWJsNxKX5@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aUh1q5twC8WqXATK%40paquier.xyz>
Precedence: bulk


--lwF1mOZTpWasDAVf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 19, 2025 at 03:02:12PM -0500, Bruce Momjian wrote:
> On Fri, Dec 12, 2025 at 11:17:01AM -0500, Tom Lane wrote:
>> =3D?utf-8?Q?=3DC3=3D81lvaro?=3D Herrera <alvherre@kurilemu.de> writes:
>>> It's strange to see this thread go on about messing with the Perl script
>>> because we're too afraid of pg_bsd_indent.  Maybe we should take
>>> ownership of that code -- improve its own indentation to our
>>> conventions, add comments, rename unclear variables, and so on until we
>>> have something we can work with, and fix these weird bugs and
>>> idiosincratic behaviors we don't like.  I just found out this code dates
>>> back from 1976.
>>=20
>> I've worked with that code a little bit, and it's mostly unreadable
>> spaghetti :-(.  If somebody wants to make an effort to make it not
>> so awful, that'd be great, but I fear it's a very nontrivial project.
>=20
> Yes, this is why we had to wrap the pg_bsd_indent call in Perl.

Removing one layer, finishing with only a C function or a perl script
would be really nice.  I am wondering if removing the perl script
would not be the way to go, just owning the portion of the code we
care about, which is already in the tree anyway.

=46rom what I can see, we rely on a set of options through $indent_opts,
it seems like one would enter a fail-and-retry repeat loop until
things get rather right:=20
- Remove as much code from pg_bsd_indent as possible.
- Integrate some of the options in the perl script into the binary.

If the binary gets slim enough and more understandable, perhaps we
could even keep both, we have all the pgtypedef business which is
specific to the Postgres tree as well.
--
Michael

--lwF1mOZTpWasDAVf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlIdasACgkQnvQgOdby
QH2lHhAAm1d5yX3jLLLIaM2mup6O1tIt3BvzvYnT8qx0mYimG36hKC/jquQyyOC7
RVEXPuN9swPbRRH/7WfmTYGPNFJuQVS5YYyoB8QGkGBuF6yeUbYSB2xN35PG2mzb
BTnKRbgFU+ThjY3o8F+xl4Bx+By7lkHPDzIcVOsQN+3gw6vDmi3ojsnboZ+kyYFJ
c3sTQpic7uP03eSvqr0PsR7TX5hpDxjBfswPDdSAnW+ENEHAB4VZtFyZhu6Pevtu
o1cVcdHdgH9GUYW7M+l+Y2d8LEl17Qpbf/XersdaihN4iSDi0thZEQgblaArhKgF
OzNaov0+basw8EnlzB1CpAvjih88udr25CwEXJO2suf6Jdg5ipNUNzK/ztb5ijLw
W2UdFdn2/Yh3kEsRhvISy1pQQhf09YirYTBchbCCphir2vmpgWUmE9BhjvHQLFkf
8Temtv7NuWgtpzhZBWT9PpcOduoTCZwBvCDFGFhtOBsF0XFas5ru4Z0/Q//5vz2/
FYNFv3HV0ZZULjgotHG9JLEbuRm5t3osf1+xaLJ2jPcKzkbnX0D9rp7C6vmgJy/0
lLFY3wU5qnZ4E7sNuLZeaoWTrjlsIXMlKALSkfO6ZMWgn/EecYt5oQnUM2LSApwX
FEY/NGHKoyIdW5zOvs85RAeQEuSGbHscA8DXHkvU02vBn3+Ix1g=
=XbWC
-----END PGP SIGNATURE-----

--lwF1mOZTpWasDAVf--