Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 25 Dec 2025 10:30:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Naga Appani <nagnrik@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Tomas Vondra <tomas@vondra.me>, Xuneng Zhou <xunengzhou@gmail.com>,
	torikoshia <torikoshia@oss.nttdata.com>,
	Kirill Reshke <reshkekirill@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [Proposal] Expose internal MultiXact member count function for
 efficient monitoring
Message-ID: <aUyTvZMq2CLgNEB4@paquier.xyz>
References: <95850ce1-2d5e-4271-92ea-c2a02e36b303@vondra.me>
 <CA+QeY+Aja_=j1EuY87L06KaPO4EJqqkS4B+Vg9AsWnGM1d_VRA@mail.gmail.com>
 <CAExHW5vDJ526OXv+Hk-=TxPoiL7RR+k+xSF2tyNqtaJHC5aoDQ@mail.gmail.com>
 <CA+QeY+CF2q2M51k5t4rZZ2SNeEq8ORf3Dr8T1+jm72VsHRJfjw@mail.gmail.com>
 <CAExHW5shToKbeiw1eRGeiSyVeCYZUJyw2KUtBKYFn0J3dCGzbA@mail.gmail.com>
 <CA+QeY+CqRjUj93_kV0YmMBqfkgo4WGEoiYOaP_wCMoJ8FOKpog@mail.gmail.com>
 <aUIvP9iZ1F6VSOYp@paquier.xyz>
 <CAExHW5t-di9g+S-7pdXxCA8z3AtCWYn_=Ou9fY0aMg7K0wA2KA@mail.gmail.com>
 <CA+QeY+DO2y-3JfK68Wqerv2wmG43B7aoAhsWa7YrsKZo_ayOtg@mail.gmail.com>
 <aUyJLUMbZumRr0BB@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="H3h2cgA/A+8IoCzp"
Content-Disposition: inline
In-Reply-To: <aUyJLUMbZumRr0BB@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aUyTvZMq2CLgNEB4%40paquier.xyz>
Precedence: bulk


--H3h2cgA/A+8IoCzp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 25, 2025 at 09:45:33AM +0900, Michael Paquier wrote:
> Seems basically sensible here for the structure, including the hints
> and recommendations for the GUCs.

+/* Calculate storage space in bytes for a given number of members */
+static inline int64
+MultiXactMemberStorageSize(MultiXactOffset members)
+{
+	return (int64) (members / MULTIXACT_MEMBERS_PER_MEMBERGROUP) *
+		   MULTIXACT_MEMBERGROUP_SIZE;
+}

By the way, this bit also feels a bit confusing, and this comes down
to the fact that "members" is not an offset, isn't it?  This relates
to MultiXactMemberFreezeThreshold(), that considers the number of
members as an offset, but it is a number of members, a difference
between two offsets.

I am wondering if it would not be cleaner and less confusing to do
things slightly differently (sorry I did not pay much attention to
that previously):
- Change GetMultiXactInfo() to return two offsets, nextOffset and
oldestOffset.
- Use uint64 for members and recalculate the difference in
MultiXactMemberFreezeThreshold() and the function code.  Heikki has
just switched multixact offsets to be 64 bits, yippee.
- Redefine MultiXactMemberStorageSize() so as it does not take a
number of members in input, but as the amount of space taken between
two offsets.  At least that would be more consistent with all the
other inline functions of multixact.h that rely on MultiXactOffset
inputs.  Using a int64 is still OK I guess, there may be a case to
detect "negative" numbers and give a change to the users of the new
inline function to notice that they did a computation wrong, rather
than hiding a signedness problem.
--
Michael

--H3h2cgA/A+8IoCzp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlMk70ACgkQnvQgOdby
QH18Tw/8Dexorg+mT2j1wh/x8F1LjZ/ps5oqS+xa3omdfbvhnUtaItgk+V5G+Mzm
CTWmWMH5UDyPa8FBbKvGO+ZTrD6eoksmArdGYDlo+OUmaVuevxMUPUtvWcQYAsE5
q2O37CAlGHcbV3dWHriPEDxND44wwAzjl9OuX5M3EaL2ai91WhKkNniYQSg62qrI
CImCHF+ldsqR25rYua4NhRg8u5zGUkA+RdYEohhVCmpx4yUQyxdEVQDNmMVJrtR/
ot4HYyPBqGsYG6TXxxWhKYxIwCLuRflnSZTIW1bWKS3B3XYwmhnWXuFPM+LqnGuW
C0b02Wgsg+S66ab2lSxY34reIL7jUIUDLfbttMnyuQjxjKL05bgQ2uE4GDxHZ0oV
ltuTCo910ROws8sljiBXGMq/75c4TA1P7PXgY8JQ+m1kazGaLiuSTeuv9mRfVFhR
OLyTBzCEv4YkGZx0OXhqtT2H7CkmJYgxb2IO6kYJ/bQb7pF+QPWG3oU3YqYZNAk+
FGXXV/R/NqV7zgLAhefYDP2Qk0sdBK//IvPhPhwhXGGE6jzUZdDNU0R2yautsCI1
EA1YLgMAgnfHI7Pt1zwxZSpp5oMwZMlEBByDDKYUPsVu+0npqf5WDySLCMVjZgsG
e7D2nDOxQCxrWozk79gZjr6pJrv/E9dNuTPqku5cTLNhn6ZndiY=
=m7mh
-----END PGP SIGNATURE-----

--H3h2cgA/A+8IoCzp--