Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 30 Dec 2025 13:31:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Lukas Fittl <lukas@fittl.com>
Cc: Sami Imseih <samimseih@gmail.com>, zengman <zengman@halodbtech.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: Refactor query normalization into core query jumbling
Message-ID: <aVNVouHQGFqFz6qu@paquier.xyz>
References: 
 <CAA5RZ0tZp5qU0ikZEEqJnxvdSNGh1DWv80sb-k4QAUmiMoOp_Q@mail.gmail.com>
 <aUT1eblRYpwB1nC7@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0vQfE14HyfpoPXDRThVcdCkLgY_HGz+J2qLB9soNUE9QQ@mail.gmail.com>
 <tencent_2FF1F5A9360E2DD24C6478FB@qq.com>
 <CAA5RZ0uLS9RrpO2roX7p3EHE4-VJkBsGAB970jrbo1-GRDAi0g@mail.gmail.com>
 <aUtm47pcAhZ1Ix0B@paquier.xyz>
 <CAA5RZ0sbWmqdUBFo8JXMJe72pnwjxVY58htJ6pKbwnyQuRctQw@mail.gmail.com>
 <CAP53PkxqGbPw5VzpacyJb2wTofYJadCoUmxV8s2o5tHzKznwbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GZkC6/BzkmUs3phR"
Content-Disposition: inline
In-Reply-To: 
 <CAP53PkxqGbPw5VzpacyJb2wTofYJadCoUmxV8s2o5tHzKznwbg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aVNVouHQGFqFz6qu%40paquier.xyz>
Precedence: bulk


--GZkC6/BzkmUs3phR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 29, 2025 at 06:34:18PM -0800, Lukas Fittl wrote:
> I noticed pg_hint_plan checks the JumbleState argument to determine whether
> or not to run an early check of the hint logic. I'm a little
> confused by this (and if this is about query IDs being available,
> couldn't it just check the  Query having a non-zero queryID?), but
> FWIW: [3]

See also the code before 32ced2e13e75.  We wanted a JumbleState in
this case to be able to generate a normalized query for the hint
table.  Since this commit we only rely on the query ID in the hint
table, so it would not matter for pg_hint_plan if the JumbleState is
removed from this portions of the hooks.

Saying that, yes I think that you are right, we should be able to
remove this dependency on JumbleState in
pg_hint_plan_post_parse_analyze() and rely on the query ID.  I'm
writing down a note about cleaning that on the HEAD branch of the
module..
--
Michael

--GZkC6/BzkmUs3phR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlTVaIACgkQnvQgOdby
QH1+UBAAqssiT2p1Jx93XN41zA1BzFDRWi/iRpwCXs4qxGnLC+pIBU4sxytyJSlF
zJutsnCC0BJoCjgzlVpHuMecb/W4wPE2WIT2YqmJTAWibXY1i4/3DgQi2sKdRmT+
ek0b2cQayBvsB+3SkJ0LnXFcZbTAhs+yDKk/2+H7ph7wr7l7Xbh3qUgMx+Mc4S2w
ruRdsbc7qlaM0iczIkOnUbZYXg35WYeDoTpCkfYTXAgw8Vxq6ICO6mzPRhuikHev
eW0jSeg1F+qAEW2csKq2VAgEfMqsIhm71P5aeyT6MWpcqYEvbAxikkkJPCJ6P73J
NsArHqKmEA241s281L/I48IwCXi8zw2gL79bs7tO9ZENEEXrlhkMdrlrfFxA/C7J
PmtQUGRKdbjoFML5cNI475fAk9CLoNcwYJjB4gLahKciiQg/t0U01ey74IIFE+lV
iiY3JaB+wcIQwIXoyIZaZV3IwhJcsjTBdFFtqrlR3l6z3AndcuisW5hyH1gl/4Ws
TC8DwEL+Ts7CydBxO14zJKmOQKUlZVV6z8RUYKiH7zHFAFbWCfGNVQMjpr8pOXv6
CPdCkNdXVF3JIJWmEbxme1tt8oZz/8nG2M2bpK97eXflK3d9YwfmgkKzUcEjALO+
Jm8vB9iMsyPC3ooCwNbW+upGQqHCqNdU27TLwOQ7Vp+KyQT9/6A=
=XeEo
-----END PGP SIGNATURE-----

--GZkC6/BzkmUs3phR--