Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 6 Jan 2026 14:38:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "Aya Iwata (Fujitsu)" <iwata.aya@fujitsu.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Chao Li <li.evan.chao@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP
 DATABASE
Message-ID: <aVyfvgMplnc6aIE2@paquier.xyz>
References: <OS7PR01MB119648203BD748ED008FA5BF5EAABA@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAFj8pRCn0=jn4yaeg1JoxxxnUNeXm1KCouES8Puq_GgBsXrNTQ@mail.gmail.com>
 <OS7PR01MB1196405302B700736580DEE49EAA8A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAFj8pRBk7zTKoxAAKAihNQuimztniWHPyRWHKp2iHq_2hH+dvQ@mail.gmail.com>
 <OS7PR01MB11964C83E8E543743581250B0EAB3A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAHut+PvP6H2soK05c_0JZC8--=h4nWEtxYE_nJGjRkQr=25F1w@mail.gmail.com>
 <aVs3IpiYjmq3gLEn@paquier.xyz>
 <CAHut+PtSVYKU4vfaRev4FMdbeZ3ukvxRy4X7uK05jv_9WMYafA@mail.gmail.com>
 <OS7PR01MB1196426354C0294148A06AC65EA86A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAHut+PtZh+B_-z_TzmToUhL4-sBrf7dfH0uAb7VU-jkXFmHQSA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="T3klPRSOcfyJw/j5"
Content-Disposition: inline
In-Reply-To: <CAHut+PtZh+B_-z_TzmToUhL4-sBrf7dfH0uAb7VU-jkXFmHQSA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aVyfvgMplnc6aIE2%40paquier.xyz>
Precedence: bulk


--T3klPRSOcfyJw/j5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 06, 2026 at 08:18:39AM +1100, Peter Smith wrote:
> This did not seem like the correct fix for my previous review comment
> [1, comment #3], because the autovacuum backends are still killed with
> SIGTERM, right?

Yes, you are right that this creates a confusing mix.  Bgworkers have
no relationship with SIGTERM in this code.  I have added a sentence to
document the new behavior for interruptible bgworkers, after the
existing ones.  One thing that was also missing is the fact that the
wait can be shortened with the injection point.

> 2.
> +# Confirm that the non-interruptible bgworker is still running.
> +my $result =3D $node->safe_psql(
> + "postgres", qq(
> +        SELECT count(1) FROM pg_stat_activity
> + WHERE backend_type =3D 'worker_spi dynamic';));
>=20
> The indentation of the "SELECT" still does not look correct to me. Did
> you run pgperltidy on this file?

perltidy is happy with that, because it considers the string within
the quoted qq() area as something fine.  At the end this is just a tab
vs whitespace issue, you are right that this should use whitespaces.

I have done a couple of test runs in the CI to be sure, and noticed no
instability in the tests, so applied.  I'll keep an eye on the CFbot
and the buildfarm for the next few days.
--
Michael

--T3klPRSOcfyJw/j5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlcn74ACgkQnvQgOdby
QH0F3hAAqrmZT7bUabTUwdxe5tqPeELIEo6Xo9dX2TQ6/DDFkfIklDo1I4NvNb0/
MHS1TTRG3gxAElT/WVMAsdW+S9C2dtKOtxQHoyJ0NKR55Jg7F1bcC6CJxLsdsaHC
D2NQMM8zzOUYzoYmEOpe5rzaRCobfNMl60d8oiMn7FJFf4wAdGkvoFKRnvIcv54g
AVVXz9p8IlX/MswPLmqQN+xja9d/Eqwxbtqnt3/pGdye+d4W8Bnl6wTT4lhWHA5G
67O86jfwZGrKAvBfguhK3Bff4IimYoR/VVKpAPouX/PNA+O2yiS/PCrO3+y7eZ6y
w40s9TtrrpeVy3ANzCKoGiXDSSBPBg70J46G3N40F/mPpR/oZECUnIJzXIEP07lR
02Dk24Xwfawd7B6bZGO4AFFOyxAvVsAPDaLsizWoXeVbMXBseNR8Td4QHHXCqDea
t39q+F7yqByAUgsMEnDFZFDzQFeUn1Fq4LXJVdQqv4G45CmfmZMYOJUS9MaudX38
4y7C82uqD0LrwOo2SZO8rHNvC9tkatikV+ySKze2emMR25sTaEsNEMB7ABkqa4u2
0HyHNA7n5Cjt26TxCTP7jlEKySLoDfcB/ZVfRg4qvwKR3hzeihXfAU68sd2YtXWx
nZnlBjllJ8D+l/z3tBQLDHU4zVHadeu9xieNN2d8SbfE9Kml4BU=
=pRs+
-----END PGP SIGNATURE-----

--T3klPRSOcfyJw/j5--