Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 9 Jan 2026 08:29:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Lukas Fittl <lukas@fittl.com>,
	Jacob Champion <jacob.champion@enterprisedb.com>,
	Dian Fay <di@nmfay.com>,
	Matheus Alcantara <matheusssilv97@gmail.com>,
	Jakub Wartak <jakub.wartak@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_plan_advice
Message-ID: <aWA94p2KkBmZCpyz@paquier.xyz>
References: <CAOYmi+=g+MMoOpWkk2weXWKJcKH0eKey8gKHHdH0dF4Tiawrhw@mail.gmail.com>
 <CA+TgmobwaT=PXPDDrgDup+jA8KHBbkxigtziD-zNzAKKkQYVgQ@mail.gmail.com>
 <CAOYmi+mOmEW=amDRQMfw6-Fb3ZmDEQFaJzwk8Bc8W8DzaP85XQ@mail.gmail.com>
 <CA+TgmoaX2AMW4cdFM3OngBJxmxpkdmzF33R7-CWhvRLfucbFMg@mail.gmail.com>
 <CAOYmi+njnRGcomnxTY6vsEW3wWigc0ruB0EyWFpb+PVVE8sWpw@mail.gmail.com>
 <CAOYmi+k4AyWCQHK=XVF99KVDuFkqxcADao61OWGLxu0nRYMONQ@mail.gmail.com>
 <CA+TgmoZ0x3ym_oueXRWzbM_=6ucKoPZVGj3rRMLBDC_FnetXDw@mail.gmail.com>
 <CAP53Pkycc=7N2bLzVT3x+qE1JamvRZWev5tFjdLJ1+-AV3Di+Q@mail.gmail.com>
 <CAP53PkxK=oeGySmq7AgN6pp8V0BEcuHY+d9xC640PxOT4QTUyQ@mail.gmail.com>
 <CA+Tgmob4PtUX=EVbhuQW8-zsmLzhyCnVwaLG71Gio=djK3Fu+g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="p54KB3Mjd8/gFK3a"
Content-Disposition: inline
In-Reply-To: <CA+Tgmob4PtUX=EVbhuQW8-zsmLzhyCnVwaLG71Gio=djK3Fu+g@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aWA94p2KkBmZCpyz%40paquier.xyz>
Precedence: bulk


--p54KB3Mjd8/gFK3a
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 08, 2026 at 11:07:31AM -0500, Robert Haas wrote:
> On Wed, Jan 7, 2026 at 2:04=E2=80=AFAM Lukas Fittl <lukas@fittl.com> wrot=
e:
>> That said, good news: After a bunch of iterations, I get a clean
>> pass on the pg_hint_plan regression tests, whilst completely
>> dropping its copying of core code and hackish re-run of
>> set_plain_rel_pathlist. See [0] for a draft PR (on my own fork of
>> pg_hint_plan) with individual patches that explain some regression
>> test differences.
>=20
> That sounds AWESOME.

So you are telling me that I can commit code that deletes code.  Count
me in.  The project has some merge requests that I've been holding on
a bit due to what's happening here and because I did not really look
at the internals that have changed.  It's great to see that you have
begun an investigation, Lukas.

>> The biggest change in the regression test output was due to how the
>> "Parallel" hint worked in pg_hint_plan (basically it was setting
>> parallel_*_cost to zero, and then messed with the gucs that factor
>> into compute_parallel_worker) -- I think the only sensible thing to
>> do is to change that in pg_hint_plan, and instead rely on rejecting
>> non-partial paths with PGS_CONSIDER_NONPARTIAL if "hard"
>> enforcement of parallelism is requested. That caused some minor
>> plan changes, but I think they can still be argued to be matching
>> the user's intent of "make a scan involving this relation
>> parallel".
>=20
> Cool. I'm sort of curious what changed, but maybe it's not important
> enough to spend time discussing right now.

I suspect that this is going to be an incremental integration process,
and it smells to me that it is going to require more than one major
release before being able to remove the whole set of hacks that
pg_hint_plan has been using, particularly with the GUCs, the costing
and the forced update of the backend routines which is a ugly
historical hack.  Saying that, I would need to look at the plan
outputs to be sure, perhaps we would be OK even with slight changes.
These happen every year, because the plans tested are complex enough
that some of the sub-paths are changed, but the hints still work
properly.  This year for v19 we have at least the changes in the
expression names.
--
Michael

--p54KB3Mjd8/gFK3a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlgPeIACgkQnvQgOdby
QH20vw/+I9+6nbMvyaQIAOTZmufsrUEaEr5WKHR0w4tCgNY9N7r/WOTjv7JbMsx4
fdvrgjJcHX92jlVPoRyoyGdPU4gu/6cOB9YcRi8fjQclXTz7VMKqAWqELmaxwpe5
9MN0gn8FKojrG7sIQDObyLCv22en337/auBHaxXeZDaWnejGAtSeIhEwLp2AGEKF
MW0u4UNvvh/lbScca8sshgAVyaIbOvSJjhqy98V0iP4b+2jysmm3+AdqEvAtQCx0
Ehu9AVpq6zNFNn1ESQvZbArcCGxNSvG2YommqhptLjG1kWBoNMcdCREpiap+V2s8
JmTtazBSJUtNsSvIBHe6uOjcggExvM0I7dPbyOSVufSisTWTesFdNf+cOfZU68Rb
eaU2O36uEEpESBxQ8Mir0G07T4ovHx2J6odBE5Wv93lZHowHnFVw24y2VbqprIQK
xbtvlj/bN/Y48mid9+LzxjefA+w0wveK0Z+bb/pEQIs1/sNvW9IhBah8hD+d+Owq
b7hzW5usAHN8oiHnnmsZW4TRmauYmIheeNkv4qdSfc6/FBelf9Agh6Is85dkDLFV
AjchdHvQXKGseUrIKAAL5ylYr2HShQRIK+TyQCXaewbF01/Soq63jPiWUkz+/8c3
QRsvFO61K9lmikmAprl9Weiaq5FPvnm7EPQv8q7K/slnMPHva/M=
=hwza
-----END PGP SIGNATURE-----

--p54KB3Mjd8/gFK3a--