Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vf4mc-003oqw-0K for pgsql-hackers@arkaria.postgresql.org; Sun, 11 Jan 2026 23:23:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vf4ma-00CXNl-0W for pgsql-hackers@arkaria.postgresql.org; Sun, 11 Jan 2026 23:23:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vf4mZ-00CXNd-0s for pgsql-hackers@lists.postgresql.org; Sun, 11 Jan 2026 23:23:40 +0000 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vf4mW-0064Yl-1a for pgsql-hackers@postgresql.org; Sun, 11 Jan 2026 23:23:39 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id DD10B7A006B; Sun, 11 Jan 2026 18:23:33 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sun, 11 Jan 2026 18:23:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1768173813; x=1768260213; bh=mlY9by1i7k 2tyiYq7aakffiJO1znOVMPUFNkm5Qunp0=; b=OZGL48zgZguPQO4+0M+SG25BTA denUVDkh0BPT5K/75pJKYwRMEyeYT0CSKjIUfYvkCu/ohe3z8Sl9R6HMZoCGcYd9 LGzneZf3Lb/zXcndKT5bY4KAwXzMSvIhWay54TuNA0CwPPaG7ts78BMjHvA45MpA QRxcF9sfRMdgzXAFt3MsND+/2eZBeVF3MXp6RsSZOsKvbkwXbYAoEBbNno0SynqX qUZvVfQh0urHi/Zh2RQ8KhNCdgPpHCFapEHNpHEjRLGD0xvSKPkuG1MF8Ch/jQEJ 8LtYxA9pHH1+XKtxFYqJch6oJN9xF6zHkj6wMUUDapelCnqXYHvjGo30ud5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1768173813; x=1768260213; bh=mlY9by1i7k2tyiYq7aakffiJO1znOVMPUFN km5Qunp0=; b=OIitBu5xXMtU1W42W25jKhupNXRckzlKrcohVB+CCculxgiWeDR 50d9bqsy85ZT8werTgg7Siv8+4Og8ibiY2D07A548ScJ00b3XkdMikxk9h2Fm6nF I/h7IA8jZIt5KMjcfDCcgG2bDK6tpWQgSEAtO8eIvfAk08mUK9U+LA3aDYCoLQUT vrLYXXjfDbveGoApYmwzF9qLFYL5V5oy9JiP/rVWCwUwd16LJncakvY2pSNj4sHW 2fTigouxj7s9scqqSF1y7D9c6YB45wNP2KUFlTrxpWaFlkDUU+5WuwETYwEPBqkf 4xlyqXXQpmwmhcoihDnWlSlOXEA2Mvm5lhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduudehkeekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprhgvsh hhkhgvkhhirhhilhhlsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprhhkhhgrphhovhes higrnhguvgigqdhtvggrmhdrrhhupdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsh esphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Jan 2026 18:23:31 -0500 (EST) Date: Mon, 12 Jan 2026 08:23:18 +0900 From: Michael Paquier To: Kirill Reshke Cc: Roman Khapov , pgsql-hackers Subject: Re: Use correct macro for accessing offset numbers. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0l6ok6Hl+HLDluEg" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0l6ok6Hl+HLDluEg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 11, 2026 at 04:58:39PM +0500, Kirill Reshke wrote: > Maybe, I have stopped some more cases, in v2-0001 Right. It's true that we could be more consistent for all these based on their base type, some of them, particularly in the GIN code now, caring about using the correct macro. It may be a good occasion to double-check the whole tree for similar holes based on unsigned types. -- Michael --0l6ok6Hl+HLDluEg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlkMOYACgkQnvQgOdby QH1P0Q//UvDK3im8b+KXL08pcd+51H4wCS635HK67+6H8TLRvFk+HqeE/CCNswAS w2BqoC60Jf71DLY5iTBIl6Oe2xsEfw6088NXOaRwTuKklBqPL6PhJdAJP1LgLCzC aeVnUXw5psZ4RPEAJDHMUfZmgC29HZ5WW4653QhR6m/WMbrCnspjMBrLmYCfHlfS x+G36Wj4/Xyluv6rujVNMKeJYHpPADE+lVt4Vcat0pEAtpaKhgVVdaypM2OppxJP xiqhIPjNguQshbYj90e91OVBvFxp1gC/HifDQEazfLltZF6R+hz20g28fOe2nU57 VSMdql4I216ZBsIh/U9/9Mhtn9G+qGmgeYBWjIm1dFBFsJ4zwo1n67OnCsu3del4 e+J6DMSmC94iu3baXMaFelL8yjRPjF3R5bbIWYNdIjOHz8WLRTIeqwTQivTPwGNA SELF+SnpcXNP5CktAXY3iU5bNp2hcQYo9VXy1TJEEOI3ig4aYTefE9oZvX72BeQA ggIqq5qMchOtp/paMhGsvfh5P6zeNlq2CG8C7lNpOLx+JuD/11Rm7Qhefe8ubzJH IfA+5NCJYe5pOxT8ZE9skFhEYSXGYXrjh6z/DJTKtPCyHciQlviuFIC6sOI0HH0P isqiwHw/tCuFoCJf/3OljMyk0l3Q1lElwMVqk3zxzU1q/+Ywq8M= =PwCH -----END PGP SIGNATURE----- --0l6ok6Hl+HLDluEg--