Date: Tue, 20 Jan 2026 10:15:13 -0800
From: Mark Wong <markwkm@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: updates for handling optional argument in system functions
Message-ID: <aW_GMVYZqGnebYLE@o>
References: <aTiwu9o8vBkLreAL@ltdrgnflg2>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="3/nz5wg6+DYwHsLU"
Content-Disposition: inline
In-Reply-To: <aTiwu9o8vBkLreAL@ltdrgnflg2>
Archived-At: <https://www.postgresql.org/message-id/aW_GMVYZqGnebYLE%40o>
Precedence: bulk


--3/nz5wg6+DYwHsLU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi everyone,

On Tue, Dec 09, 2025 at 03:28:59PM -0800, Mark Wong wrote:
> Hi everyone,
> 
> I noticed how it was preferred to define optional arguments with the
> system functions in system_functions.sql instead of defining them in
> pg_proc.dat.
> 
> I took a gross stab at updating the ones that ended in _ext, which
> turned out to be 7 declarations across 6 system functions, and created a
> patch per system function, hoping it would be easier to review.
> 
> Perhaps the most interesting thing to share is the total reduction of
> the lines of code, although system_functions.sql only grows:
> 
>  src/backend/catalog/system_functions.sql |  49 ++++++++
>  src/backend/utils/adt/ruleutils.c        | 130 ----------------------
>  src/include/catalog/pg_proc.dat          |  36 ++----
>  3 files changed, 56 insertions(+), 159 deletions(-)
> 
> 
> Is that something we want?

I fixed an error caught by the address sanitizer in CI [1] and am uploading a
new patchset.  The only change is to 2 lines in
v2-0005-Handle-pg_get_expr-default-args-in-system_functio.patch to update a
call to pg_get_expr with the correct number of arguments in tablecmds.c.

Regards,
Mark

[1] https://cirrus-ci.com/task/6109065824174080
--
Mark Wong <markwkm@gmail.com>
EDB https://enterprisedb.com

--3/nz5wg6+DYwHsLU
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v2-0001-Handle-pg_get_ruledef-default-args-in-system_func.patch"