Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 22 Jan 2026 14:35:40 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	jian he <jian.universality@gmail.com>, Peter Geoghegan <pg@bowt.ie>
Subject: Re: Having problems generating a code coverage report
Message-ID: <aXG3LM7z9BDSvF6U@paquier.xyz>
References: <CAH2-WzkTDv1PGhyssyHaV1smSEUNktDV3ACfwZsL-iE2=9hOVA@mail.gmail.com>
 <ZyLLtHK2hir2H-vV@paquier.xyz>
 <CAJ7c6TPYPF93+yWi=ThKiOsnhqLpeTmctMrJWz3xRQobGSY6BA@mail.gmail.com>
 <CACJufxG+vX_pfPNJTo1WXP_QzGO1KXrVa0yYMkpBqL8nJvQ-VA@mail.gmail.com>
 <CAJ7c6TMhH2DK6uAGekrn5Xbd5PcPMkTfN4Ot2EfBkuRB3QVy7g@mail.gmail.com>
 <CAJ7c6TNg-4Lc4rXkM3SA95LCUef5QPvfiTAOAe58=8g6oenzuw@mail.gmail.com>
 <CAJ7c6TOkAMyHuNPWnF5S9ciOtB52reNgcv50XtyQNb2gY_DYyA@mail.gmail.com>
 <nqql77bmqixd232hrb6paw47evj6ramp6omsatwoofuzflcwak@j6t2wru3iqfd>
 <aXFz4wzIsgFLiCSD@paquier.xyz>
 <bxrbuxmpin6a3gunynde7c67ircaud5sxmjgid5kpidyzic55a@tqsmafqk6wah>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VG8jXvqqeDObyFSc"
Content-Disposition: inline
In-Reply-To: <bxrbuxmpin6a3gunynde7c67ircaud5sxmjgid5kpidyzic55a@tqsmafqk6wah>
Archived-At: <https://www.postgresql.org/message-id/aXG3LM7z9BDSvF6U%40paquier.xyz>
Precedence: bulk


--VG8jXvqqeDObyFSc
Content-Type: multipart/mixed; boundary="l0c2ogYZ/WudF+hI"
Content-Disposition: inline


--l0c2ogYZ/WudF+hI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 21, 2026 at 08:59:45PM -0500, Andres Freund wrote:
> I have the following .lcovrc in my postgres source dir:
>=20
> ignore_errors=3Dinconsistent,gcov,range
> check_data_consistency=3D0
> stop_on_error=3D0
> genhtml_hierarchical=3D1
> genhtml_show_navigation=3D1
> parallel=3D16
> geninfo_gcov_tool=3D/usr/bin/gcov-15
>=20
> (assuming you build with gcc 15)
>=20
> With that meson coverage information works (i.e. ninja coverage-html) for=
 both
> lcov 2.0 and 2.4 as long as the build directory is outside of the source
> directory. Both on Debian Sid and macos.

Thanks for sharing.  Yes, I have a matching gcc version at 15.2
currently.  I have been playing with this area of the configuration
for some time without finding the correct combination before giving
up, and these suggestions are actually helping for meson.  So now I
can get a report offline.  Yeah at least it's one thing working.

Hmm.  configure with and without VPATH still burp at me on HEAD.  If I
tweak the lcov commands in src/Makefile.global.in like in the attached=20
patch then the non-VPATH build can work, where I remove the srcdir
part (aka reverting c3d9a66024a9).  For the VPATH build, this patch
does not work at all, it generates an incomplete report, ignoring
entirely contrib/, with its base index.html starting inside src/,
missing a bunch of subdirectories.  I can live with this custom patch
for now, just wondering if anybody else sees what I am seeing for a
few months now.

Thoughts?  At least two out of the three methods are working with the
attached instead of one out of three.  Not sure what to do with VPATH,
but well.
--
Michael

--l0c2ogYZ/WudF+hI
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="0001-Tweak-lcov-commands.patch"
Content-Transfer-Encoding: quoted-printable

=46rom db627eb90cf625249a670300e295cff1c69c0a88 Mon Sep 17 00:00:00 2001
=46rom: Michael Paquier <michael@paquier.xyz>
Date: Thu, 22 Jan 2026 14:32:45 +0900
Subject: [PATCH] Tweak lcov commands

This fixes coverage reports for non-VPATH builds, generates incorrect
reports with VPATH builds.
---
 src/Makefile.global.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index 947a2d79e291..d066ed162034 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -1061,12 +1061,12 @@ LCOVFLAGS =3D -q --no-external
 all_gcno_files =3D $(shell find . -name '*.gcno' -print)
=20
 lcov_base.info: $(all_gcno_files)
-	$(LCOV) $(LCOVFLAGS) -c -i -d . -d $(srcdir) -o $@
+	$(LCOV) $(LCOVFLAGS) -c -i -d . -o $@
=20
 all_gcda_files =3D $(shell find . -name '*.gcda' -print)
=20
 lcov_test.info: $(all_gcda_files)
-	$(LCOV) $(LCOVFLAGS) -c -d . -d $(srcdir) -o $@
+	$(LCOV) $(LCOVFLAGS) -c -d . -o $@
=20
=20
 # hook for clean-up
--=20
2.51.0


--l0c2ogYZ/WudF+hI--

--VG8jXvqqeDObyFSc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlxtywACgkQnvQgOdby
QH0Znw//Q/c88jOvAapyovpu+IGJzHWhVrp33j9vJEmL/tXkEWlse6fI1HviyzQu
lx6BrN+zfc39XlkwP07YsICsX2t/48nimu9ONtxoU/r14k0Vq3aTHc1gF+7fIELn
xAl6pIhy8rr5B+SnaVweqoQvoHOaq/FTWbl4xYMP7WYRRYDNUwYhjk8XDEt1sDnO
uY4FQviISWtMDGQttjhXSvd5ZCI4L1tNQp5+pRLxva7UDKrT8MZdObXL+Ys4IZsy
AkCfYC4KNC7zws3HtZnKgTQyDPNqfHqL33vMeWiGwTngO4RPmlR0CquBmfNZUQRS
O9UdQY/+i47Cvx4AhQzH9BmX0f8Fcw/ZKmdfsIdzlZyNiwstPkYoslfqFJ3SsLlL
tw5GTabKMBh9KblC9ReiYUMMKkMqK5z1LUxyiyT52IHdeQXmItAhSXRX3iXOYvUz
cm5yf+COF4gsCcMcJ+z5Qo2KEvZNhSXd806ur8QygHZm6CjaxGtAZXcKUGobZ4wo
4jUDRm44vnTuOZPbRPWnXx5JnJQ916NkH513w0K/mkhGcflVc2N+mLC8qHd93gNj
ulAA8CUfwD+tQLjJDsg9QoYo97fvJwbg+PgLuDMbOBNclQ18J4awq2dj90MgNASC
Ofg4r6pxUz3RyDQkgpnLN3rhILZ+gOWRfsJIn6SZ3/zQ7oCpQh0=
=LKLV
-----END PGP SIGNATURE-----

--VG8jXvqqeDObyFSc--