Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 26 Jan 2026 16:42:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Tender Wang <tndrwang@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Extended Statistics set/restore/clear functions.
Message-ID: <aXca7jnwtzFSYr4s@paquier.xyz>
References: <aW3UcP6rGXMLjkwm@paquier.xyz>
 <CADkLM=dJ4bQ3e4Cc+vaVFmnrL37Y5hPJ1u0AYXE6fSkh_=+sTg@mail.gmail.com>
 <aXAXMwHYF1qyUaP5@paquier.xyz>
 <CADkLM=c3s-BtSebTHggY__DOYFMCdknaLuJHwG0o817o0Q9tNA@mail.gmail.com>
 <aXHGoMAnzV5njUEo@paquier.xyz>
 <CADkLM=c3JivzHNXLt-X_JicYknRYwLTiOCHOPiKagm2_vdrFUg@mail.gmail.com>
 <aXVw4LGO4fWunn4n@paquier.xyz>
 <CADkLM=f4+3_HrXSAaEic5VGGd-fOjS4jGnr1WGJYrL7vf3ZJnw@mail.gmail.com>
 <aXWBhkru03FnrfIW@paquier.xyz>
 <CADkLM=c7DY3Jv6ef0n_MGUJ1FyTMUoT697LbkST05nraVGNHYg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ATAqsULVSwShJicQ"
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=c7DY3Jv6ef0n_MGUJ1FyTMUoT697LbkST05nraVGNHYg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aXca7jnwtzFSYr4s%40paquier.xyz>
Precedence: bulk


--ATAqsULVSwShJicQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 25, 2026 at 05:20:13AM -0500, Corey Huinker wrote:
> Ok, here's my attempt at splitting things out:
>=20
> 0001 - Add attribute stats test for multiranges

This was indeed independent of the rest, qualifying as a test defect
on v18, so applied first.=20

> 0002 - Basic restore functionality ndistinct

This has been combined with portions of 0007 to make sure that some
docs are there, with irrelevant portions related to other stats kinds
removed.

> 0003 - add dependencies

This one is simple.  It still needs a couple of adjustments (elog
messages on one line, one more test).

> 0004 - add mcv
> 0005 - add expressions

These would be next in line.

> 0006 - Add in the before/after diff test on a stats object (in theory this
> could be added after 0002)

I think that this would mean 0005 now.

> 0007 - add SGML

Partially done.

> 0008 - restore MAINTAIN test (in theory this could be merged into 0002)

I was hesitating to do exactly that, but just split things at the end.
This patch was actually incorrect, with regress_test_extstat_clear
as role name getting partially used.  The output was wrong.

Another side note: I am not sure how the CI or the buldfarm did not
notice that, but I've found a bug in the tuple initialization logic
while reviewing more the code, fixed in 114e84c532d1.  Perhaps my
build environment was more efficient in detecting that.
--
Michael

--ATAqsULVSwShJicQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAml3Gu4ACgkQnvQgOdby
QH3dkQ/5Ae5boISQvkWydyFgaSytYAK1qAhg2I45SbZejVFiOObPcJVavnLsznAh
lTRBngl8gENzbjOclr0bzMFBCy7Qia+g69m9EoQSG6tWjTiymu+j6aVtbEN7w8Us
ohIdPn/V1oVuZXKwc+MhTSxpm5WVaG3AswfXq6u7Tw/Msye5yB3BZtpVKYXVsd7x
SytKZw6fN7Mk/Uu0BjfWpX5WQE3oQDpCGy+dukC8Va5/n00lXzkkeZTh4w+dart2
b3fxHgCQgzvn/x/l3INnGXBOuXFQbo7LZh+kwrlWuG18N6wyxSScgCulQROGeH1D
GYMbhZJ7hRWwPNgr/CLaRSPhT24FRR+w8fDXoMZgseUdG9bzteopM44aZZX53jrw
85SPrup8zAG/MwI3dfNiBSd49JWFAmntj/10u0tgClPqMkA5r19Qt8ToamRfddU9
AKDR2eB0mO0Kns7DmQJrjCBIYhSdlDJkybYZyVXvY8Xh+KGSSiIRaFAmAsXoS98d
QXDR8AUSQ2rfRiWA2GpyLEO36geCDxjmb8jobFPkyrBVN6tA4CHU3LNxfBAUIg2U
I02915OgDNlIQkMzr4HqdXLibwopziavzcKzOlDP9YEgca/qgGSiQTXtON13y/5k
p+cA7N7Mi+2qysKU9zjbYBj4ohJYnOVGjey656PBUBvZzEBin8Q=
=RdSs
-----END PGP SIGNATURE-----

--ATAqsULVSwShJicQ--