Date: Mon, 26 Jan 2026 08:41:53 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Safer hash table initialization macro
Message-ID: <aXco0XWaces41QFp@ip-10-97-1-34.eu-west-3.compute.internal>
References: <CAGECzQSnhom3wFnY6a7xepGfxzzVmwyNCcJQE=y8UYS-g2G=RQ@mail.gmail.com>
 <CA+hUKGLZPZ4DgJs46-dkkkF5pi0gm23SerJY0HbOUP5r7siPsg@mail.gmail.com>
 <DESS1U66SWHO.2JT1YL2Q20K0F@jeltef.nl>
 <aTfPRxNYuYWVLI+3@ip-10-97-1-34.eu-west-3.compute.internal>
 <DFKVK5R7G2ND.1EH6WD16255OW@jeltef.nl>
 <aWXzzzQcn3hbqG3L@ip-10-97-1-34.eu-west-3.compute.internal>
 <DFNCUVLOL3E1.37T3ZSNLVDW42@jeltef.nl>
 <aWdMaa/3m1n9wcX5@ip-10-97-1-34.eu-west-3.compute.internal>
 <DFO6J99E4HOY.29NFF8O6W6TFH@jeltef.nl>
 <DFY2DVPSXAZX.1BAGDNB27D0F2@jeltef.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <DFY2DVPSXAZX.1BAGDNB27D0F2@jeltef.nl>
Archived-At: <https://www.postgresql.org/message-id/aXco0XWaces41QFp%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Mon, Jan 26, 2026 at 12:38:15AM +0100, Jelte Fennema-Nio wrote:
> On Wed Jan 14, 2026 at 9:46 AM CET, Jelte Fennema-Nio wrote:
> > Changed wording and changed to NOTE.
> 
> Attached is v7 which is rebased and changed the hash_create calls
> introduced by 282b1cde9de.

Thanks!

The changes make sense to me.

Just a pgindent nit, in 0003:

$ git diff
diff --git a/src/backend/commands/async.c b/src/backend/commands/async.c
index 73f93512f9b..0a1e7c709c9 100644
--- a/src/backend/commands/async.c
+++ b/src/backend/commands/async.c
@@ -3162,8 +3162,8 @@ AddEventToPendingNotifies(Notification *n)
                Assert(pendingNotifies->uniqueChannelHash == NULL);
                pendingNotifies->uniqueChannelHash =
                        hash_make_cxt(ChannelName, channel, "Pending Notify Channel Names",
-                                                        64L,
-                                                        CurTransactionContext);
+                                                 64L,
+                                                 CurTransactionContext);


Also, I can see (I think it's coming from 0004):

In file included from ../../../../src/include/access/hash.h:28,
                 from typcache.c:46:
typcache.c: In function ‘TypeCacheRelCallback’:
typcache.c:2472:46: warning: declaration of ‘typentry’ shadows a previous local [-Wshadow=compatible-local]
 2472 |                 foreach_hash(TypeCacheEntry, typentry, TypeCacheHash)
      |                                              ^~~~~~~~
../../../../src/include/utils/hsearch.h:314:20: note: in definition of macro ‘foreach_hash’
  314 |         for (type *var = NULL, *var##__outerloop = (type *) 1; \
      |                    ^~~
typcache.c:2412:25: note: shadowed declaration is here
 2412 |         TypeCacheEntry *typentry;
      |                         ^~~~~~~~

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com