Date: Mon, 26 Jan 2026 10:26:11 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Safer hash table initialization macro
Message-ID: <aXdBQ+fBKUcqLPzN@ip-10-97-1-34.eu-west-3.compute.internal>
References: <DESS1U66SWHO.2JT1YL2Q20K0F@jeltef.nl>
 <aTfPRxNYuYWVLI+3@ip-10-97-1-34.eu-west-3.compute.internal>
 <DFKVK5R7G2ND.1EH6WD16255OW@jeltef.nl>
 <aWXzzzQcn3hbqG3L@ip-10-97-1-34.eu-west-3.compute.internal>
 <DFNCUVLOL3E1.37T3ZSNLVDW42@jeltef.nl>
 <aWdMaa/3m1n9wcX5@ip-10-97-1-34.eu-west-3.compute.internal>
 <DFO6J99E4HOY.29NFF8O6W6TFH@jeltef.nl>
 <DFY2DVPSXAZX.1BAGDNB27D0F2@jeltef.nl>
 <aXco0XWaces41QFp@ip-10-97-1-34.eu-west-3.compute.internal>
 <DFYFQDUFZ38Q.1LEJWN1P20X8Q@jeltef.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DFYFQDUFZ38Q.1LEJWN1P20X8Q@jeltef.nl>
Archived-At: <https://www.postgresql.org/message-id/aXdBQ%2BfBKUcqLPzN%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Mon, Jan 26, 2026 at 11:05:49AM +0100, Jelte Fennema-Nio wrote:
> On Mon Jan 26, 2026 at 9:41 AM CET, Bertrand Drouvot wrote:
> > Also, I can see (I think it's coming from 0004):
> 
> Are you sure you applied the latest one, I had seen that in CI and fixed
> it in v7. Should definitely be fixed now at least.

I can still see it. If I apply from 0001 to 0004 and compile, I see it. It looks
like it's fixed in 0005:

index 54a418a2503..e102adf9f83 100644
--- a/src/backend/utils/cache/typcache.c
+++ b/src/backend/utils/cache/typcache.c
@@ -2409,14 +2409,13 @@ InvalidateCompositeTypeCacheEntry(TypeCacheEntry *typentry)
 static void
 TypeCacheRelCallback(Datum arg, Oid relid)
 {
-       TypeCacheEntry *typentry;
-
        /*
         * RelIdToTypeIdCacheHash and TypeCacheHash should exist, otherwise this
         * callback wouldn't be registered
         */
        if (OidIsValid(relid))
        {
+               TypeCacheEntry *typentry;
                RelIdToTypeIdCacheEntry *relentry;

                /*


but I think that the fix should be in 0004 so that each sub-patch compile without
warnings.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com