Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 27 Jan 2026 16:48:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Message-ID: <aXhty3YQceFniabz@paquier.xyz>
References: <CAEoWx2kggo1N2kDH6OSfXHL_5gKg3DqQ0PdNuL4LH4XSTKJ3-g@mail.gmail.com>
 <CAEoWx2k5800OjHO5KhTDv4JFYpDmyfh3MTtuB=7PP-0hLmG8yQ@mail.gmail.com>
 <07773235-2E94-478F-BEF6-38C73B0553B8@gmail.com>
 <EA6CB317-60C2-4BA9-8E02-DBCAD384F107@gmail.com>
 <CAN4CZFMUJWM0veLK93Ew8mYaL5pcU6G550STh6AZ-_LWV2zS+w@mail.gmail.com>
 <16D5D52A-1B99-4371-982E-257C195D2924@gmail.com>
 <CAN4CZFPX_t9q4W=jTh4jW4TOz=Xhfv0gPi9jG0MfXv9Ek7BO5w@mail.gmail.com>
 <5244008D-79E1-484B-9407-21F5D388EC7F@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ebEiKKCdGbcsU4Ra"
Content-Disposition: inline
In-Reply-To: <5244008D-79E1-484B-9407-21F5D388EC7F@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aXhty3YQceFniabz%40paquier.xyz>
Precedence: bulk


--ebEiKKCdGbcsU4Ra
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 27, 2026 at 07:13:04AM +0800, Chao Li wrote:
> I added two new test cases in 0002 that trigger the check.
>=20
> BTW, this is the CF entry:
> https://commitfest.postgresql.org/patch/6415/. You may mark yourself
> as a reviewer, and once you consider the patch is ready to go, would
> you mind change the status to Ready For Committer?=20

There is more to this set of changes than it looks at first sight.

Hence, one question about 0001: can the previous error path in
mark_index_clustered() be reached through a different mean than ALTER
TABLE?  If yes, we should have a test for it.  If no, it could be
switched to an elog(ERROR) or an assertion.  The code paths leading to
the previous error should be analyzed further.
--
Michael

--ebEiKKCdGbcsU4Ra
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAml4bcsACgkQnvQgOdby
QH1wCQ/9GYGKAOd3OuyC0Ae6jPPpfr0xvCiUlnkNR0hq5Lavcy35pLyG29933+nM
gi2LMUCnoM8nfnI9wFHFPOWF+KY1rcwkkj5thpWsdnTynun0+/cXVYrXdDpdxaBs
HmF/bHsx2/tTSTp0hYU23hpD7wKo3h4atLhk3dNNZfyAPKb3eo2w3iCKTnihPohc
yLqL8u0ypRMOtAjPtnYrS4EqmSF7BEEoB1mEuxDBje9WaYY35J4IE6mukqGUX8V3
zC5UaY5Un4eVxfr6gtSEcCGu1k8CHKoaHrYnFoFgj+AdL+i8mnY9yJ43ZX33GEXg
eAgsAuE6oUqIDgWca/cyy3rbJ6kWhwGMvvQ14glHie5zWLYQZHMtM9B4F3Y515ht
iqe9/YexrujLvlqQ1PKAtzaInLVG4Jlr0FMUP/df57X75eX26XRTC21659IYa5BC
F11EkzwkGoga+UOdam+I9I48SBsFg3I7OF19leQOLeMSbAgpiq9VGd9YGAWS25LV
vFB2IrMw791LZodGDG0ZkJ4hyrq8gr8SR+wonbOUjFKBYnL/LtK28SehqeOdsTMP
P995RLTURqIV2wE/EdvICzwsyfyXhP/xPwh7ASyDr0oUUAv2THi0o5DAJUvcNs5i
c61uhDT24j72oB4328+xaTgHtFKREDwnIsse9Gyf95J5kYThLdw=
=3hi5
-----END PGP SIGNATURE-----

--ebEiKKCdGbcsU4Ra--