Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vlMPQ-00ANhR-0I for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Jan 2026 07:25:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vlMPP-0070qv-0F for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Jan 2026 07:25:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vlMPO-0070qj-0z for pgsql-hackers@lists.postgresql.org; Thu, 29 Jan 2026 07:25:43 +0000 Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vlMPL-000000011X7-32S6 for pgsql-hackers@postgresql.org; Thu, 29 Jan 2026 07:25:42 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id DC7E7EC0295; Thu, 29 Jan 2026 02:25:37 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Thu, 29 Jan 2026 02:25:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1769671537; x=1769757937; bh=Rw3L9f7jAr NNoo3WaNa2/cbAf1fWOVXUxM8hqTW888o=; b=GzZQGbuLP6vF8NBnEbACIla5hc XSTJedeEVS+Qe4PlNw7FrIt2ogY67TvE35f4KGdOlYvaKEF2eJFzU2KYW0c2kwZv RSJmqfDVY4z+2XYb/iVjjTpM8e9vddSzDUuxX5OJpz9cP1fbVUy00i+pJ/ycMgjH kJzlhtYITcj2jaKD0FDV4c5Sd6c9vRQfMkLUYOjwbKodHkrUxMVcgofFXtshaS54 UPAwOPfoP8z0qD2+Y5h2oW4XKkoILhv1GENHL7iA8L2L/fkuW2oMROSHvU5A0Vbc 5tiXYhRzgV3a8w0BewMloIkDt0zUmpZB+Xf220i7A8Plr8fjZBKkstD9F0EA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1769671537; x=1769757937; bh=Rw3L9f7jArNNoo3WaNa2/cbAf1fWOVXUxM8 hqTW888o=; b=WE/DRqWz31i10P8NUo27N84b9iOeVQRrTE0KQ9kco8vIY4spS54 PWQrJG/jlkqubvulCgoOSQw8q6OI1NakQtlnp+m42Tw5OX8k0wORM+wWxeAfXf6A 9cplJ9oJuOPGUU4dICacaZwiSTSPuA6LuDuRlkcHOBJf0rrlOesFUjLQQHyupkDp kWe4IORJDB8SGHQu98f1jksx1BJgrWW3jI/Kffpzx4rcv9ZBtijyrjk0NOYQKxOQ 6odi4wwW4L4XsmeGMDbTFilEtM3ImVqLnDnPUq/ozzEFIU3TTNh6pwzbDDdqoXSS uOHo4DpCp8Pqo8mF+BWe5kQwKQo4ENojC7A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduieehheelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprgguih hgohhllhgrmhhuughisehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghlvghkshgrnhgu vghrsehtihhgvghruggrthgrrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvg hrshesphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jan 2026 02:25:35 -0500 (EST) Date: Thu, 29 Jan 2026 16:25:31 +0900 From: Michael Paquier To: Aditya Gollamudi Cc: Aleksander Alekseev , PostgreSQL Development Subject: Re: [PATCH] Refactor *_abbrev_convert() functions Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8DWFswzdEwG5T3QJ" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --8DWFswzdEwG5T3QJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 24, 2026 at 02:27:04PM -0800, Aditya Gollamudi wrote: > I reviewed this change and the surrounding code and this seems good! > All tests pass locally for me. Hopefully this gets picked up soon. Yep, that looks rather right. Will double-check all that later. -- Michael --8DWFswzdEwG5T3QJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAml7C2sACgkQnvQgOdby QH0LxA/+MGLUuZ1cfmKIEV/eDa9PXZ0YdqCnVhN3Aj20eyIx9z6QvYoZ6oF2lESp YxkwjABRv1hlXXnMXaMVXbX97KlFL8Td2/L/0IfCS2Yvf39r6JVPvVVXt3+bMMzs oJas/TGqAhqWpV+pl4+35lS47O3pTgvxVFCkACd/jl4JGzPJZ7lCk1E8FfOTojv8 qLV5Rj8o5cJEC3lrw6qBUSChb72EEwTXCV1j8tjs1hheCwh/Ej74k6e6sMWTh9pT GZwkQ9ZN2o8SpuHeyELPd5PVMQw+nlqjOx8zfU+5HPRWyTeOFsUDBhIgrsGqPGtB kdnh/AwOhh7fNS5hWcMPsvF4ZRmRswXCfX3VaPd+/rLv9WvavzR/6ZyvZFzLcfdU mcEGdJxX8P+IWVS/uyQMKRAivNgXIBLF+L/DSxWgCJQ2jBOZuhkTUNQdLllrpXCx k7fKEf/f6wWAjNozjKP5qM6fzUrrlQG3zoUIEuRMVdghoIYkL8Gvpxr4KiktaYTk XmDZk4yUIMm5Dz/G0nYWkjyRneMQemzntHWAMdHHtKYNgwJRtX35mfIlO6vCsajI eIgFn/njnuXFu4vK0QlNdXnZNCY6Fjk4Okymwgb6MBlZ/HnUb3khi9PstORfy8S+ m7E82rUGB9gKsyZ3I/SCRc3iHK8MGjuS53F9o5tVE32ydhpLwhA= =nkkf -----END PGP SIGNATURE----- --8DWFswzdEwG5T3QJ--