Date: Fri, 30 Jan 2026 11:16:26 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	Michael Paquier <michael@paquier.xyz>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Quan Zongliang <quanzongliang@yeah.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Message-ID: <aXyTCrlkoewFa9lD@ip-10-97-1-34.eu-west-3.compute.internal>
References: <aRtd2dw8FO1nNX7k@ip-10-97-1-34.eu-west-3.compute.internal>
 <202601291744.chmxe2jjofs6@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="31r/W+W8Qcw0VOW+"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202601291744.chmxe2jjofs6@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/aXyTCrlkoewFa9lD%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk


--31r/W+W8Qcw0VOW+
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi,

On Thu, Jan 29, 2026 at 06:45:12PM +0100, Álvaro Herrera wrote:
> On 2025-Nov-17, Bertrand Drouvot wrote:
> 
> > On Mon, Nov 17, 2025 at 01:12:24PM +0000, Bertrand Drouvot wrote:
> > > The script has been updated and the patch too (finding a new replacement in
> > > gist.c).
> > 
> > Finally, adding GistNSN to the game (as a typedef XLogRecPtr) gives the attached.
> 
> I've pushed this.

Thanks!

I just looked at the cocci script used for that and realized (with more Coccinelle
practice) that it could be simplified. It's done in [1], and lead to a few more
cases discovered and fixed in the attached. I think that, with the attached, we
cover them all.

[1]: https://github.com/bdrouvot/coccinelle_on_pg/blob/main/replace_literal_0_assignement_with_InvalidXLogRecPtr.cocci

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--31r/W+W8Qcw0VOW+
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v1-0001-Fix-other-cases-of-literal-0-instead-of-InvalidXL.patch"