Feedback-ID: id4a34324:Fastmail
Date: Thu, 12 Feb 2026 19:51:18 -0500
From: Andres Freund <andres@anarazel.de>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Replace literal 0 values with the appropriate Invalid* constants
Message-ID: <aY501dOolZoqEW_H@alap3.anarazel.de>
References: <aY2oKlSpikgO9m+X@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aY2oKlSpikgO9m+X@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/aY501dOolZoqEW_H%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2026-02-12 10:15:06 +0000, Bertrand Drouvot wrote:
> There are some places where we are using literal 0 instead of the proper Invalid*
> constant.
> 
> I think it's better to use the proper constant instead: It improves code clarity
> by making it explicit that these are invalid values rather than ambiguous zero
> literals.

I think we should reject these and other similar patches, they generate way
more noise than they are improving the code. If you edit the code for other
reasons and update the initialization in the course of that, ok, but these
wholesale searches for initializing with 0 use up bandwidth that we could use
for much more worthwhile things.

Greetings,

Andres Freund