Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vqpod-001Svk-0P for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Feb 2026 09:50:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vqpob-00DQdU-1M for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Feb 2026 09:50:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vqpoa-00DQdL-1m for pgsql-hackers@lists.postgresql.org; Fri, 13 Feb 2026 09:50:21 +0000 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vqpoY-00000000T6O-1oJk for pgsql-hackers@postgresql.org; Fri, 13 Feb 2026 09:50:21 +0000 Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailfout.stl.internal (Postfix) with ESMTP id 98B421D001A8; Fri, 13 Feb 2026 04:50:15 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Fri, 13 Feb 2026 04:50:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1770976215; x=1771062615; bh=qTyhw7sZe/ 75cqOS2jrU8rvQGLnUALS6qtkzjdypPxk=; b=TW+IA0XZYlHuMd6ABhNTVJm26b TR+FtF5/WNAWya7UPRITtth/4hdeg1H4mZr396Tz/0QlGGqKo5SYyOd/ggvWpt0A BVoe1AWFHGHBZveR/40TyClq7HmVsvcgY3Aw3/Po0q1YsWT+7VELZzdlcUHscsdW 0d80DtwjsE3eCaKqCJlnFhpNoT7R1R00IH0s/BRJRcxAODFvzw8dsFDH6xPdRspH nCKF5EmppauaCuwhWmMSHXujjltaK6reb2QzRS9p0sntDREAT0YFQstEOGgyYBM4 bA6dNVZ35PWydz/kbIhC+klBk0yjCZUxRZlCizEeFZ7MIO0t2aueJDu0zU9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1770976215; x=1771062615; bh=qTyhw7sZe/75cqOS2jrU8rvQGLnUALS6qtk zjdypPxk=; b=b6ez6fvOI8m95yRfC+y1hwFeBBtUxFpwmdZRRMC1yX2iP6YXYjv 0ci/lx/J0+jSDP0T1OcfrC5b6tIMUB8N05HoL49HCC4EeyMY1P6mq7QgOfWvvJzd SDC/c+cJF2YVEYmlAxaY+tsbYxOylyF3pPnAyl3Xk+UuN493SkkV+43LoMWTqvE1 4mta117BnliGoTh+Xzg24LtK+yT+WINvtufSPJ9Z3kL81uY31F+jsRRD73qn1MpD Ywtlop2pjMMlhqaKgeRvDptclcG9jJFJZxQXu7O0VtoguYKOihSczyVgw0bSx8xY l7Llcixf8WmQ4pUhcqVBKn9oz9YKzTqseJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvtdejleefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprghnth hhohhnihhnrdgsohhnnhgvfhhohiesuggrthgrughoghhhqhdrtghomhdprhgtphhtthho pehpghhsqhhlqdhhrggtkhgvrhhssehpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Feb 2026 04:50:13 -0500 (EST) Date: Fri, 13 Feb 2026 18:50:08 +0900 From: Michael Paquier To: Anthonin Bonnefoy Cc: PostgreSQL Hackers Subject: Re: Fix uninitialized xl_running_xacts padding Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wMIK/hQFVcZnnYgQ" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --wMIK/hQFVcZnnYgQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 13, 2026 at 10:39:14AM +0100, Anthonin Bonnefoy wrote: > The 3 bytes of padding after subxid_overflow were left uninitialized, > leading to the random 'ca ce 9b' data being written in the WAL. The > attached patch fixes the issue by zeroing the xl_running_xacts > structure in LogCurrentRunningXacts using MemSet. This uninitialized padding exists for as long as this code exists, down to efc16ea52067. No objection here to clean up that on HEAD. -- Michael --wMIK/hQFVcZnnYgQ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmO89AACgkQnvQgOdby QH1yQA//ShGiDQ1YQHsdXSqALUXTQt3fW1Z/gS49HklS4RVv9y+uZqtg58/Pw7yl 8a2xX8n9YXW8T9yNxw33Y0hVtSdHa2kv+LH2JYW1hUDm1tH3JIRMRyIg+cOn4J5a /8pUW74qZE1/w6JU073qom7JB5vI9NOvChlnxd2jil61fZaeKLviGlHYHD91Qdr5 WQpSmvoN+qDT47EZo8yoWaq08o3mrTXOpFz0EhYsig9W5WwRkE+EydwBWDKsYsXZ 7dx/qHNpxxLY2UR6faYQrZXQkYAC+orZ4A0bSUqvyYRWp9NJTbeiqk8SyXfBkh9B uF4KhmoRgEZrLJF31ZymP+IKlh4MDrJuhaRbuqVAg8M58C76YWgALUQZWs6h7y1s JiJbzU4a4nLToDk1I0Nv+TE4PVPA74MOgE/FoBoWw1VwoGzV3MwqSjgGSOKguvI4 nxX8etJDEL9VQ596nPhSmRhM97B+mKbhAr6c0JmCtI2Ahgd9iAQub4NQkF58OhMO b80ytcAwUvORbd7d+o6TvGvBqoMrsPh1FksKo22eGytes/TrjLeW14WpQ7e3eMYV GWMGy5afHGiZkxaxqrODQgH0LGrlVtA1JgnPWIUzuUcVOwZCU+cVUt/rpocfN1RF DbScwlpHiK2afTHg/hSGECobar3xJLXgSNtSvYs9dR0gLSrdhYg= =465G -----END PGP SIGNATURE----- --wMIK/hQFVcZnnYgQ--