Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 2 Feb 2026 12:54:26 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Incorrect errno used in OpenWalSummaryFile()
Message-ID: <aYAf8qDHbpBZ3Rml@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9SZJvrcclY8Y4Q36"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/aYAf8qDHbpBZ3Rml%40paquier.xyz>
Precedence: bulk


--9SZJvrcclY8Y4Q36
Content-Type: multipart/mixed; boundary="3+Le/7UDIuAabD8I"
Content-Disposition: inline


--3+Le/7UDIuAabD8I
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

While looking at walsummary.c for a different thread, I have bumped
into this code:
OpenWalSummaryFile(WalSummaryFile *ws, bool missing_ok)
[...]
    file = PathNameOpenFile(path, O_RDONLY);
    if (file < 0 && (errno != EEXIST || !missing_ok))
        ereport(ERROR,
                (errcode_for_file_access(),
                 errmsg("could not open file \"%s\": %m", path)));

And it seems to me that this EEXIST should be an ENOENT?  The top of
the function also documents that we want to handle an error when a
summary file does not exist.  The comment makes sense to me, not the
code.

It's also worth noting that this function has two callers, both use
missing_ok = false, meaning that the errno check does not really
matter today.  If someone plays with this code on HEAD or the
back-branches and decides to introduce a missing_ok=true call, it
could matter, so I'd rather not change this function signature.

This issue has been mentioned here as well, I've just bumped into it
independently a few hours ago:
https://www.postgresql.org/message-id/tencent_1CA40FCC21C1C770712BC089@qq.com

Regards,
--
Michael

--3+Le/7UDIuAabD8I
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=wal-summary-errno.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/backend/backup/walsummary.c b/src/backend/backup/walsummar=
y.c
index 4ee510092f99..4cd1824fbc6b 100644
--- a/src/backend/backup/walsummary.c
+++ b/src/backend/backup/walsummary.c
@@ -214,7 +214,7 @@ OpenWalSummaryFile(WalSummaryFile *ws, bool missing_ok)
 			 LSN_FORMAT_ARGS(ws->end_lsn));
=20
 	file =3D PathNameOpenFile(path, O_RDONLY);
-	if (file < 0 && (errno !=3D EEXIST || !missing_ok))
+	if (file < 0 && (errno !=3D ENOENT || !missing_ok))
 		ereport(ERROR,
 				(errcode_for_file_access(),
 				 errmsg("could not open file \"%s\": %m", path)));

--3+Le/7UDIuAabD8I--

--9SZJvrcclY8Y4Q36
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmAH/IACgkQnvQgOdby
QH15OQ/8Cgh0nfLCB6iOFbC0Ip4r9Lmxsh32pKeg/VtpYwkfLEzfJCwSRZSiBB2i
vfWD8QF+qiJDFlCvp0UG7ElGiSaj/NT3JkWLmNXg1tB80hmvaWnwKUAvd0qkL9iD
zURUS0MdV6swZKMH2S01ndDmK69C+7PiZAW96g3TJnejfGkhOCKrmkL3o2se0kHN
N68KQETEGo9408poVrgk5ztPj4ON7pW2j0Ovg2pOfcQq5FQm/qDMWFcTnUtvaPDA
eK+F/O84DQJfzkuZqaPHAt/SXgMrp0lDURV46vyG/6SV1MSEAu1Ip6wqoVHJ2vmW
jlaYtwxbFdXtNcKhUs/TntVMj0MGfT22dVIy3hZ/yMCZnmdKUvzKmdFPRQg1XRf+
s0mdqYVuMfHJkTPkMs7XCWGFy5rbABkn/RWNHVnQ2u5Is9MJoy0vuOrzaC8E5ylx
4nuIRcH7nvrnUTWYJSSYiAKofwmd+N5jBe5YGHoXo/UDqu5PlQwH45ZGiuZWgmWy
Cf+RQLOUY9LZsDk9ZjJCAFzmKJ3XEG4kHNnStHCkHjHAt/k8OST+anhJAqyJdo50
SiwxWrZtmqkkftgQQFmT4/99EK3vMh2Z3/hIusvh9GOewbCVueqNx2/mNK0Co5Bb
3j27AX5WuvuLGiNPUL8wwEoLcgCj9PnFt9dHySJbpCX+tN87Q8k=
=tbu2
-----END PGP SIGNATURE-----

--9SZJvrcclY8Y4Q36--