Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 2 Feb 2026 16:55:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrey Silitskiy <a.silitskiy@postgrespro.ru>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Vitaly Davydov <v.davydov@postgrespro.ru>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	"Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>,
	"sawada.mshk@gmail.com" <sawada.mshk@gmail.com>,
	"peter.eisentraut@enterprisedb.com" <peter.eisentraut@enterprisedb.com>,
	"dilipbalaut@gmail.com" <dilipbalaut@gmail.com>,
	"andres@anarazel.de" <andres@anarazel.de>,
	"amit.kapila16@gmail.com" <amit.kapila16@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	Alexander Korotkov <aekorotkov@gmail.com>,
	Fujii Masao <masao.fujii@gmail.com>
Subject: Re: Exit walsender before confirming remote flush in logical
 replication
Message-ID: <aYBYj_RaGxFoHdXz@paquier.xyz>
References: <CAHGQGwFHJ-80uwd8jgSsm9ZL_HBvi5SXa6O6nktXiOicxHKKxQ@mail.gmail.com>
 <dcf6a30c-ad28-4644-8523-58f9779156c2@postgrespro.ru>
 <CAHGQGwFk51nAFs20-dq2SLONdeyhYcvDQb_jZiPiJt5Rinb8Ug@mail.gmail.com>
 <3d024a19-1256-4177-942a-d7173dacba74@postgrespro.ru>
 <CAHGQGwHo6XgsS5NCiC9hwa3SqUBTHSLmcqNUVg=BSv76oDOFsw@mail.gmail.com>
 <e25567b4-9893-48bf-ac17-0e884f1acef9@postgrespro.ru>
 <d062db6a-8040-41eb-b3c9-32c3af30ef2b@postgrespro.ru>
 <CAHGQGwGotoS0VeMDdK6ezkhvdQpWZ5oJvO3QKJKEV6Pc+rZ_9A@mail.gmail.com>
 <d91f4092-8dd8-4ecf-b26a-cd79d84cb444@postgrespro.ru>
 <045cf632-1354-4d42-a8ea-cc02eaa80d68@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xPnaRxa+SAJ7QQqJ"
Content-Disposition: inline
In-Reply-To: <045cf632-1354-4d42-a8ea-cc02eaa80d68@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/aYBYj_RaGxFoHdXz%40paquier.xyz>
Precedence: bulk


--xPnaRxa+SAJ7QQqJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 02, 2026 at 02:52:36AM +0700, Andrey Silitskiy wrote:
> +/*
> + * Shutdown walsender in immediate mode.
> + */
> +static void
> +WalSndDoneImmediate()
> +{
> +	QueryCompletion qc;
> +
> +	/* Try to inform receiver that XLOG streaming is done */
> +	SetQueryCompletion(&qc, CMDTAG_COPY, 0);
> +	EndCommand(&qc, DestRemote, false);

Couldn't that be potentially dangerous, particularly if
wal_sender_shutdown_mode is set to immediate, meaning that it applies
to all the WAL senders?  The WAL receiver side could be on a backend
with an older backend version than the WAL sender where this new GUC
exists.  Hence, a completion could be understood incorrectly by a WAL
receiver depending on how the receiving side is coded?  Assuming this
is merged into v19 in this shape, a receiver connecting to a newer
server would get a new bevahior compared to older versions, without
the receiver being aware of that.

I suspect that this option, as designed, is potentially a footgun that=20
could surprise many users, especially as it is super aggressive in
shutting down everything on sight, unconditionally.
--
Michael

--xPnaRxa+SAJ7QQqJ
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmAWI8ACgkQnvQgOdby
QH0pCw//QwrlRwn7lZ4mTVgtzGjXrYqCT1SypKlvkiN5RPI/m2kbketoEHaXXvIg
InYgm4rSLFPF1XK5tq3dvkOdEy/qfsjNYDOdGKtbOeiCm+6Zo48orch7GSqOkuJO
aeaq8XzvJMkJlh/5M9THZ1ZGNeBpO0mLvOzGc4MkFJ0kvI34Q6wNOICDkfSg19ee
jRnhKviwncLC2cA4wSI2X1WTG6W5Hy935gYvKwnz0pbaTzJ2doLw3p0fjW4FUnep
K+KfRXFe7ycCyPN93I9KRUdQxB6rxn8FY83xgvH0zqvjR1GDcFVTMxM0ekMuvRDp
vkctOXA5XDnrqM8oDeQOHbXHcf4RPkQHR7w4vbrKFE+Ec69u7ENTzUUOv43AwSd+
jLhGGlN3hOoQ5LYH/Zb4wyFYpTsUmIQH74qLv/Lg32ozA6BsaGCkS2PLu6BqRDBi
MSwptTe8ZcfqNvlBQeVo2qmA163cG3UO02Pn870Q0+FC7Wae5QDi7TF/P5YoHIDQ
4gP8VCetjhSNCphbtifya3sW7YjjdGj+/g5TuIC/bf1PkV3bSiIhMkaP1lCqDb1c
gQY3k8UfXQyG3UsaXgLuPTMv5wzecldepUcujRN+aUPSIXiMwsvbInp97zXZMbOv
SWa9GB7InTUrVFtkTTGu11Lt7Qkmt4qJ7Dp1BFoyYxM7H5LXycs=
=jOcg
-----END PGP SIGNATURE-----

--xPnaRxa+SAJ7QQqJ--