Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vnIQL-004mJ2-2C
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 03 Feb 2026 15:34:41 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vnIQK-005Pq2-2R
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 03 Feb 2026 15:34:40 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <nathandbossart@gmail.com>)
	id 1vnIQK-005Ppu-1U
	for pgsql-hackers@lists.postgresql.org;
	Tue, 03 Feb 2026 15:34:40 +0000
Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.98.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1vnIQH-00000000rCO-2CdZ
	for pgsql-hackers@postgresql.org;
	Tue, 03 Feb 2026 15:34:39 +0000
Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-4095b6f9c5aso3562569fac.0
        for <pgsql-hackers@postgresql.org>; Tue, 03 Feb 2026 07:34:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1770132875; x=1770737675; darn=postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=S3CWHLbifVPB7fs2DUm9nrhyZLQHDD0z7NlJcj2Qz0E=;
        b=m/cUSGC/zP7KN2O9wJyyzSVH2XYy0Zb7aqtmu/ocEuF6EyS/C1Xn0FnZ5V3OCGKhYW
         a1QXz8EXbBs/1wI8CIJqXiZLahCuwnl0n26x4I1pPf9k8So2OIk8wN9t9qZw4jLJ5KWf
         5G55AuhB6f42zLYXlNmLPr56EmAP848+9/kjiyvr87lOSHiMypy/aszb82ScQ8t0XiXM
         YR7nzb94XFQD0FXgH54FPCfbJ2pouF4OQAp6joCk5g0IssdnJ//VHPi4jw/UN0kwCZML
         5yqF3aYFgn0NFe0Lx/QrKOD89WkUNGG4arQs3KCZ00M5RkNoEBFAhUWIVM5F7eM3FZyp
         X5kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770132875; x=1770737675;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=S3CWHLbifVPB7fs2DUm9nrhyZLQHDD0z7NlJcj2Qz0E=;
        b=uhNNrD03rNqs0n3mLjARuWdWLS8nolO05tf9Tu9ZSuDQDYnIKn8qIXc7jN15DU9vag
         Y7w6UpHYbx76dxcFkIFIKyi7i+i2kdNEPIKJCuO4qXWxYBtEdpDuIFt9pkJwiTJ7yx0E
         +wdTr17Iew0mpa9SOxoDU8aqWKlFGdIqborIuT2PSYLdxLLmtqQtJ9wjYkDZxgCc7DjO
         J32G2AyOUyaUY9pNO1WrQeLuJjZLTJMd3H7gzZcpMiCGN1l8qcxumkFxWHlDnM2ACh5G
         jdddnVYi4BbUgeWYuILJcKae3zsiUntY0vMCHoWjI2KSrYTYuQk41Mu+GZlJmuW926Tk
         kZ+Q==
X-Forwarded-Encrypted: i=1; AJvYcCXwYXZz2z4dUuDmBvReflxMRRCr1BzxxiCBAuFssolMVzn8HOpL8GkOm4ohPICIHCop9XnH1F0WrGzGAObE@postgresql.org
X-Gm-Message-State: AOJu0YxFkXGeZyuB9wXyawAwLLg+Pu9ZWfnm32TVU7SfIqAkGo52yLQc
	NxUhAwGKbpoN5gm/fHkXS73TKEy8DuWSfy2yNMBq3sNtaueJgTGbDdqq
X-Gm-Gg: AZuq6aIaqv39EnnAP9VkVFz6D1Tf9HJQeB5x17ffGqP1K0sv4wzcvrahuq3fJTzVRHo
	3xPy5LPN4JWkdlWKmrxQK/NlMSY+57oM2o6jwUJcMyAxtXn5zJW3sIFa7rVEq7GMVAIfvVwjdpH
	eDsAQal4bcqWvMoGPqh8J1WDcHM94bA5p470/VU5xukRHUzMiQqcGIn6OLMnOjKdNemAulvL5P6
	zsMbKlCdv0G4LJBWji8Spn5nY2sIOmi32u0dgEISrUW73aJfG1ZNaR5qecpCh8l8O3Rb4aLKBXF
	yV6QVHvrN7Hk194oxVT4IXRNsIgmRyaEE5njKGfQRKvgX+Kw6r0u6/9xJyhQ40we7pGxMSkVi8y
	uKtzTTwD3LgdLQh4oj7TVFUgWHioD79F5hZykz90Z1/k3bMrHPWGQgO6D+sjknRt7kRpwHKYc52
	05eQLtIDOIvdDl6mE0SP8NKMmN4GoZc75XMsSxNWPlrQRX1l/cC4rFLDu0zp8/ZLKlKd/2W11Hx
	d5d
X-Received: by 2002:a05:6870:a70b:b0:404:3941:4d60 with SMTP id 586e51a60fabf-409a6a54cb3mr7920456fac.2.1770132875149;
        Tue, 03 Feb 2026 07:34:35 -0800 (PST)
Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40980497603sm11815757fac.21.2026.02.03.07.34.34
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 03 Feb 2026 07:34:34 -0800 (PST)
Date: Tue, 3 Feb 2026 09:34:33 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: zengman <zengman@halodbtech.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Message-ID: <aYIViZ-zoeH3OIy-@nathan>
References: <tencent_17B13D9206FD633428A9DA3A@qq.com>
 <1226920.1770129949@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1226920.1770129949@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/aYIViZ-zoeH3OIy-%40nathan>
Precedence: bulk

On Tue, Feb 03, 2026 at 09:45:49AM -0500, Tom Lane wrote:
> I think we should reject this as useless code churn.  The parameter
> was needed in the past and might be needed again in the future.
> It's fairly common for other AtEOXact functions to take an isCommit
> flag, so I don't find it surprising for these to have one.

+1

-- 
nathan